From: Peter Wu <lekensteyn@gmail.com>
To: Francois Romieu <romieu@fr.zoreil.com>
Cc: netdev@vger.kernel.org,
Realtek linux nic maintainers <nic_swsd@realtek.com>
Subject: [r8169] About the "PHY reset until link up" warning
Date: Mon, 22 Jul 2013 12:42:50 +0200 [thread overview]
Message-ID: <2215813.0syAhGCZsc@al> (raw)
Hi,
When a cable is not connected while an interface goes up, the "PHY reset until
link up" warning is logged. Looking back in the history, this warning was
added in:
commit a7154cb8326c6015b6c5d9ce482d2a1f4c268d99
Author: François Romieu <romieu@fr.zoreil.com>
Date: Wed Jun 2 12:03:02 2004 -0400
[PATCH] r8169: link handling and phy reset rework
Link handling changes (Andy Lutomirski <luto@myrealbox.com>):
- removed rtl8169_hw_phy_reset() and its busy loop;
- RTL8169_PHY_TIMEOUT is x10 to account for the removal of the
phy_link_down_cnt loop in rtl8169_phy_timer();
- added spinlocking in timer context for rtl8169_phy_timer to avoid
messing with the {set/get}_settings commands issued via ethtool;
- more TBI stuff.
This patch differs from the former version on the following points:
- the LinkChg irq does not enable the phy timer when the link goes
down any more;
- the phy timer is not enabled in rtl8169_set_speed();
- removal of the initial renegotiation hack.
(via git://git.kernel.org/pub/scm/linux/kernel/git/tglx/history.git)
If this is a (hardware) bug workaround, can't it be restricted to that specific
hardware or removed altogether (perhaps firmware / other updates fixed it
already?). Otherwise, what about removing this debug message?
Manually running "ip link set eth1 down" brings the interface down and no
resets are being attempted. Another way to stop resetting the interface is
inserting a cable, wait for link up and remove it again. This presumably works
because rtl8169_down() removes the reset timer.
Regards,
Peter
next reply other threads:[~2013-07-22 10:42 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-07-22 10:42 Peter Wu [this message]
2013-07-22 21:43 ` [r8169] About the "PHY reset until link up" warning Francois Romieu
2013-07-22 21:48 ` David Miller
2013-07-22 22:45 ` Francois Romieu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=2215813.0syAhGCZsc@al \
--to=lekensteyn@gmail.com \
--cc=netdev@vger.kernel.org \
--cc=nic_swsd@realtek.com \
--cc=romieu@fr.zoreil.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).