From: David Ahern <dsahern@kernel.org>
To: Carlos Bilbao <carlos.bilbao@lambdal.com>,
davem@davemloft.net, kuba@kernel.org, jmaxwell37@gmail.com,
linux-decnet-user@lists.sourceforge.net
Cc: linux-kernel@vger.kernel.org, netdev@vger.kernel.org, bilbao@vt.edu
Subject: Re: [PATCH] net: decnet: fix build error due to incompatible pointer type, in dn_dst_gc
Date: Sat, 24 Jan 2026 13:33:24 -0700 [thread overview]
Message-ID: <222170f6-0095-4930-b6b7-cc309ba45ac1@kernel.org> (raw)
In-Reply-To: <ecb0ffd9-4a1f-4579-bff8-264aedb5bab1@lambdal.com>
On 1/23/26 4:23 PM, Carlos Bilbao wrote:
> Update the signature of dn_dst_gc() to return void instead of int.
>
> This change is required because the .gc member of struct dst_ops was
> updated to a void return type in a previous commit [1]. This leads to the
> following build error:
>
> net/decnet/dn_route.c:132:10: error: initialization of 'void (*)(struct dst_ops *)' from incompatible pointer type 'int (*)(struct dst_ops *)' [-Werror=incompatible-pointer-types]
>
> Note that dst_alloc() inside net/core/dst.c was already updated to
> ignore the return value of this callback.
>
> [1] https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/commit?id=af6d10345ca76670c1b7c37799f0d5576ccef277
>
> Fixes: af6d10345ca7 ("ipv6: remove max_size check inline with ipv4")
> Signed-off-by: Carlos Bilbao (Lambda) <carlos.bilbao@kernel.org>
> ---
> net/decnet/dn_route.c | 6 ++----
> 1 file changed, 2 insertions(+), 4 deletions(-)
>
commit 1202cdd665315c525b5237e96e0bedc76d7e754f
Author: Stephen Hemminger <stephen@networkplumber.org>
Date: Wed Aug 17 17:43:21 2022 -0700
Remove DECnet support from kernel
prev parent reply other threads:[~2026-01-24 20:33 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-01-23 23:23 [PATCH] net: decnet: fix build error due to incompatible pointer type, in dn_dst_gc Carlos Bilbao
2026-01-24 20:33 ` David Ahern [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=222170f6-0095-4930-b6b7-cc309ba45ac1@kernel.org \
--to=dsahern@kernel.org \
--cc=bilbao@vt.edu \
--cc=carlos.bilbao@lambdal.com \
--cc=davem@davemloft.net \
--cc=jmaxwell37@gmail.com \
--cc=kuba@kernel.org \
--cc=linux-decnet-user@lists.sourceforge.net \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox