From: Luca Boccassi <bluca@debian.org>
To: Alexei Starovoitov <alexei.starovoitov@gmail.com>,
Andrey Ignatov <rdna@fb.com>
Cc: "netdev@vger.kernel.org" <netdev@vger.kernel.org>,
bpf@vger.kernel.org, daniel@iogearbox.net
Subject: Re: [PATCH bpf-next v4] tools/bpf: generate pkg-config file for libbpf
Date: Thu, 21 Mar 2019 22:23:42 +0000 [thread overview]
Message-ID: <222d76b75d0d8efceb060aed445593d01647619e.camel@debian.org> (raw)
In-Reply-To: <20190321220107.pcvf6e23kun4gj7r@ast-mbp.dhcp.thefacebook.com>
[-- Attachment #1: Type: text/plain, Size: 1993 bytes --]
On Thu, 2019-03-21 at 15:01 -0700, Alexei Starovoitov wrote:
> On Thu, Mar 21, 2019 at 04:00:46PM +0000, Andrey Ignatov wrote:
> > luca.boccassi@gmail.com <luca.boccassi@gmail.com> [Thu, 2019-03-21
> > 03:26 -0700]:
> > > From: Luca Boccassi <bluca@debian.org>
> > >
> > > Generate a libbpf.pc file at build time so that users can rely
> > > on pkg-config to find the library, its CFLAGS and LDFLAGS.
> > >
> > > Signed-off-by: Luca Boccassi <bluca@debian.org>
> ...
> > > diff --git a/tools/lib/bpf/libbpf.pc.template
> > > b/tools/lib/bpf/libbpf.pc.template
> > > new file mode 100644
> > > index 000000000000..0ecd334c109f
> > > --- /dev/null
> > > +++ b/tools/lib/bpf/libbpf.pc.template
> > > @@ -0,0 +1,11 @@
> > > +prefix=@PREFIX@
> > > +libdir=@LIBDIR@
> > > +includedir=${prefix}/include
> > > +
> > > +Name: libbpf
> > > +URL:
> > > https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git
> > > +Description: Linux kernel BPF library
>
> github/libbpf/libbpf is a true mirror of kernel's libbpf.
> I think if we start shipping libbpf.so from kernel and from github
> it will be very confusing to the users...
> Which one is the true libbpf?
I'm afraid that ship already sailed :-) Users and distributions are
already consuming libbpf from the kernel tree.
> Also the package should mention the license.
> And the license for libbpf is dual lgpl/bsd.
I followed the template from the other pkgconfig file (in traceevent)
which does not have it, but I can add it in v5.
> But if we point to the url above it will not make much sense.
> I think the packages URL should point to github/libbpf/libbpf
> and packaging scripts should be in github only.
If only one side ships the pc file, then you'll have half the users
installing libbpf without a pc file, and the other half with it, so it
would defeat the point of having one in the first place.
> Daniel,
> what do you think?
>
--
Kind regards,
Luca Boccassi
[-- Attachment #2: This is a digitally signed message part --]
[-- Type: application/pgp-signature, Size: 488 bytes --]
next prev parent reply other threads:[~2019-03-21 22:23 UTC|newest]
Thread overview: 31+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-03-19 21:06 [PATCH bpf-next] tools/bpf: generate pkg-config file for libbpf Luca Boccassi
2019-03-19 21:23 ` Stanislav Fomichev
2019-03-19 23:02 ` Luca Boccassi
2019-03-19 23:12 ` Stanislav Fomichev
2019-03-19 23:00 ` [PATCH bpf-next v2] " Luca Boccassi
2019-03-19 23:17 ` Stanislav Fomichev
2019-03-20 13:22 ` Luca Boccassi
2019-03-20 13:30 ` Luca Boccassi
2019-03-20 17:21 ` Stanislav Fomichev
2019-03-20 20:39 ` Luca Boccassi
2019-03-20 20:44 ` Stanislav Fomichev
2019-03-20 20:54 ` Daniel Borkmann
2019-03-20 21:13 ` Stanislav Fomichev
2019-03-20 13:28 ` [PATCH bpf-next v3] " luca.boccassi
2019-03-20 23:58 ` Andrey Ignatov
2019-03-21 10:29 ` Luca Boccassi
2019-03-21 10:25 ` [PATCH bpf-next v4] " luca.boccassi
2019-03-21 16:00 ` Andrey Ignatov
2019-03-21 22:01 ` Alexei Starovoitov
2019-03-21 22:19 ` Daniel Borkmann
2019-03-21 22:34 ` Luca Boccassi
2019-03-21 22:23 ` Luca Boccassi [this message]
2019-03-21 22:27 ` [PATCH bpf-next v5] " luca.boccassi
2019-03-21 22:33 ` [PATCH bpf-next v6] " luca.boccassi
2019-03-21 22:43 ` Alexei Starovoitov
2019-03-21 23:10 ` Luca Boccassi
2019-03-21 23:09 ` [PATCH bpf-next v7] " luca.boccassi
2019-03-26 20:12 ` Alexei Starovoitov
2019-03-26 20:17 ` Luca Boccassi
2019-03-28 11:33 ` [PATCH bpf-next v8] " luca.boccassi
2019-03-28 16:09 ` Daniel Borkmann
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=222d76b75d0d8efceb060aed445593d01647619e.camel@debian.org \
--to=bluca@debian.org \
--cc=alexei.starovoitov@gmail.com \
--cc=bpf@vger.kernel.org \
--cc=daniel@iogearbox.net \
--cc=netdev@vger.kernel.org \
--cc=rdna@fb.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).