From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 731C72874F8 for ; Wed, 8 Apr 2026 10:54:10 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=170.10.129.124 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1775645651; cv=none; b=VOzmoHxSggcX8sRAuIY4Q+i10xD95FX40qbDAY7jpgSLqGbLYC/fnVyw6fdryLF0fdaCjfPTVBY1F3KOfAg/jSb7QTdkAUesNdK5lZxSphjwYVDXatmZZJaCHkRRS/VrQx3RCubHwrh2r8uWGjxnokJgEJ1/rueI67xuEudPteY= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1775645651; c=relaxed/simple; bh=Qg4IhS0Qdpxb6/qhQxkeUSVPSaiglX0bHabdDboIuac=; h=From:In-Reply-To:References:To:Cc:Subject:MIME-Version: Content-Type:Date:Message-ID; b=fcXsrsSiqNZ0eBpkojsfIAAmJckstrFpeCak8JI3vSI5QnJHfXw79h5pLh+9VT5a7EgszbaT64Fn9Y5ToX8Z242EfxMb1iL+ZanpVuCNAuLfz/RKNK8iLZwNydyapfUMYdw8VToA9nfj/LXLVn/THc4fywwUmTVLETyjej2hAIw= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=redhat.com; spf=pass smtp.mailfrom=redhat.com; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b=YX8n8TcA; arc=none smtp.client-ip=170.10.129.124 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=redhat.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=redhat.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b="YX8n8TcA" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1775645649; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=jY1ukOkI+Lcpd2UuRoCXivEO6jxQxrYJgx37ibiZJKg=; b=YX8n8TcAtv6X3t2cz/QFU/uhNj3z8dqtUb2yA1HC4jzFxXZ/GttEiZ0BtJGiwIW2uy41zI 2W8SaJR1fJO3IjC2LOKBgTXwC23uSOOaRrQ/9qCsVAT9VqdwCmATzofM4xKiVH1ZAfVXSr 7AgO2LUciHrtB4V2xSLXQQnFRKDaV0Y= Received: from mx-prod-mc-05.mail-002.prod.us-west-2.aws.redhat.com (ec2-54-186-198-63.us-west-2.compute.amazonaws.com [54.186.198.63]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-627-EzblanOwN2yQztDPQf64fg-1; Wed, 08 Apr 2026 06:54:03 -0400 X-MC-Unique: EzblanOwN2yQztDPQf64fg-1 X-Mimecast-MFC-AGG-ID: EzblanOwN2yQztDPQf64fg_1775645639 Received: from mx-prod-int-01.mail-002.prod.us-west-2.aws.redhat.com (mx-prod-int-01.mail-002.prod.us-west-2.aws.redhat.com [10.30.177.4]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by mx-prod-mc-05.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTPS id B9D89195608E; Wed, 8 Apr 2026 10:53:58 +0000 (UTC) Received: from warthog.procyon.org.uk (unknown [10.44.32.94]) by mx-prod-int-01.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTP id 15ECC300019F; Wed, 8 Apr 2026 10:53:52 +0000 (UTC) Organization: Red Hat UK Ltd. Registered Address: Red Hat UK Ltd, Amberley Place, 107-111 Peascod Street, Windsor, Berkshire, SI4 1TE, United Kingdom. Registered in England and Wales under Company Registration No. 3798903 From: David Howells In-Reply-To: <2234233.1775645449@warthog.procyon.org.uk> References: <2234233.1775645449@warthog.procyon.org.uk> <20260401105614.1696001-1-dhowells@redhat.com> <20260401105614.1696001-16-dhowells@redhat.com> To: Anderson Nascimento Cc: dhowells@redhat.com, netdev@vger.kernel.org, Marc Dionne , Jakub Kicinski , "David S. Miller" , Eric Dumazet , Paolo Abeni , linux-afs@lists.infradead.org, linux-kernel@vger.kernel.org, Luxiao Xu , Yifan Wu , Juefei Pu , Yuan Tan , Xin Liu , Ren Wei , Ren Wei , Simon Horman , stable@kernel.org Subject: Re: [PATCH net v4 15/15] rxrpc: fix reference count leak in rxrpc_server_keyring() Precedence: bulk X-Mailing-List: netdev@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-ID: <2234583.1775645631.1@warthog.procyon.org.uk> Date: Wed, 08 Apr 2026 11:53:51 +0100 Message-ID: <2234584.1775645631@warthog.procyon.org.uk> X-Scanned-By: MIMEDefang 3.4.1 on 10.30.177.4 David Howells wrote: > Anderson Nascimento wrote: > > > Isn't this the same issue addressed by my patch "[PATCH net v4 08/15] > > rxrpc: Fix keyring reference count leak in rxrpc_setsockopt()"? Just > > asking to make sure this is intended. > > Actually, I think it's probably better to use Luxiao Xu's patch rather than > yours as it puts the check down into the function that actually makes the > change. I also then need to remove the rx->key check. David