From: John Crispin <john@phrozen.org>
To: Florian Fainelli <f.fainelli@gmail.com>, Andrew Lunn <andrew@lunn.ch>
Cc: Vivien Didelot <vivien.didelot@savoirfairelinux.com>,
"David S . Miller" <davem@davemloft.net>,
Sean Wang <sean.wang@mediatek.com>,
netdev@vger.kernel.org
Subject: Re: [RFC 1/2] net-next: fix DSA flow_disection
Date: Tue, 20 Jun 2017 19:38:53 +0200 [thread overview]
Message-ID: <229f981f-8e01-8ca9-e90e-573f2761ba8e@phrozen.org> (raw)
In-Reply-To: <ec46025d-4618-499c-72fe-693da9abc050@gmail.com>
On 20/06/17 19:30, Florian Fainelli wrote:
> On 06/20/2017 07:01 AM, Andrew Lunn wrote:
>> On Tue, Jun 20, 2017 at 10:06:54AM +0200, John Crispin wrote:
>>> RPS and probably other kernel features are currently broken on some if not
>>> all DSA devices. The root cause of this that skb_hash will call the
>>> flow_disector.
>> Hi John
>>
>> What is the call path when the flow_disector is called? I'm wondering
>> if we can defer this, and call it later, after the tag code has
>> removed the header.
> Would not you usually want to configure RPS at the DSA network device
> level where the switch tag has already been popped and you are
> processing a regular Ethernet frame at that point?
Hi Florian,
is explained in my mail to Andrew, you really want to be able to setup
RPS for all devices in the chain to free up the core handling IRQs
John
next prev parent reply other threads:[~2017-06-20 17:39 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-06-20 8:06 [RFC 1/2] net-next: fix DSA flow_disection John Crispin
2017-06-20 8:06 ` [RFC 2/2] net-next: mt7530: add nh and proto offsets to the ops struct John Crispin
2017-06-20 13:54 ` Andrew Lunn
2017-06-20 17:27 ` John Crispin
2017-06-20 18:02 ` Andrew Lunn
2017-06-20 10:17 ` [RFC 1/2] net-next: fix DSA flow_disection Sergei Shtylyov
2017-06-20 14:01 ` Andrew Lunn
2017-06-20 17:30 ` Florian Fainelli
2017-06-20 17:38 ` John Crispin [this message]
2017-06-20 17:37 ` John Crispin
2017-06-20 21:52 ` Andrew Lunn
2017-06-21 4:33 ` John Crispin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=229f981f-8e01-8ca9-e90e-573f2761ba8e@phrozen.org \
--to=john@phrozen.org \
--cc=andrew@lunn.ch \
--cc=davem@davemloft.net \
--cc=f.fainelli@gmail.com \
--cc=netdev@vger.kernel.org \
--cc=sean.wang@mediatek.com \
--cc=vivien.didelot@savoirfairelinux.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).