From: srinivas pandruvada <srinivas.pandruvada@linux.intel.com>
To: Jakub Kicinski <kuba@kernel.org>,
Stanislaw Gruszka <stanislaw.gruszka@linux.intel.com>
Cc: linux-pm@vger.kernel.org, "Rafael J. Wysocki" <rafael@kernel.org>,
Ricardo Neri <ricardo.neri-calderon@linux.intel.com>,
Daniel Lezcano <daniel.lezcano@linaro.org>,
"David S. Miller" <davem@davemloft.net>,
Eric Dumazet <edumazet@google.com>,
Paolo Abeni <pabeni@redhat.com>, Jiri Pirko <jiri@resnulli.us>,
Johannes Berg <johannes@sipsolutions.net>,
Florian Westphal <fw@strlen.de>,
netdev@vger.kernel.org
Subject: Re: [PATCH v4 1/3] genetlink: Add per family bind/unbind callbacks
Date: Mon, 12 Feb 2024 17:52:53 -0800 [thread overview]
Message-ID: <22a264118ebe7194cf43a5d7e1d61417feff8534.camel@linux.intel.com> (raw)
In-Reply-To: <20240212170700.4eda9c03@kernel.org>
On Mon, 2024-02-12 at 17:07 -0800, Jakub Kicinski wrote:
> On Mon, 12 Feb 2024 17:16:13 +0100 Stanislaw Gruszka wrote:
> > Add genetlink family bind()/unbind() callbacks when adding/removing
> > multicast group to/from netlink client socket via setsockopt() or
> > bind() syscall.
> >
> > They can be used to track if consumers of netlink multicast
> > messages
> > emerge or disappear. Thus, a client implementing callbacks, can now
> > send events only when there are active consumers, preventing
> > unnecessary
> > work when none exist.
> >
> > Suggested-by: Jakub Kicinski <kuba@kernel.org>
> > Signed-off-by: Stanislaw Gruszka
> > <stanislaw.gruszka@linux.intel.com>
>
> LGTM! genetlink code is a bit hot lately, to avoid any conflicts can
> I put the first patch (or all of them) on a shared branch for both
> netdev and PM to pull in? Once the other two patches are reviewed,
> obviously.
>
If netlink maintainers are happy with the 1/3, you can take 1/3. Once
merged, the PM patches can go separately as they need 1/3.
Hi Daniel,
Please look at 2/3 and also 3/3 if you can.
Thanks,
Srinivas
next prev parent reply other threads:[~2024-02-13 1:52 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-02-12 16:16 [PATCH v4 0/3] thermal/netlink/intel_hfi: Enable HFI feature only when required Stanislaw Gruszka
2024-02-12 16:16 ` [PATCH v4 1/3] genetlink: Add per family bind/unbind callbacks Stanislaw Gruszka
2024-02-13 1:07 ` Jakub Kicinski
2024-02-13 1:52 ` srinivas pandruvada [this message]
2024-02-13 9:11 ` Jiri Pirko
2024-02-12 16:16 ` [PATCH v4 2/3] thermal: netlink: Add genetlink bind/unbind notifications Stanislaw Gruszka
2024-02-13 13:24 ` Rafael J. Wysocki
2024-02-22 15:47 ` Stanislaw Gruszka
2024-02-22 15:55 ` Rafael J. Wysocki
2024-02-12 16:16 ` [PATCH v4 3/3] thermal: intel: hfi: Enable interface only when required Stanislaw Gruszka
2024-02-13 13:59 ` Rafael J. Wysocki
2024-02-22 16:53 ` Stanislaw Gruszka
2024-02-16 5:29 ` [PATCH v4 0/3] thermal/netlink/intel_hfi: Enable HFI feature " Jakub Kicinski
2024-02-23 15:44 ` Stanislaw Gruszka
2024-02-16 5:30 ` patchwork-bot+netdevbpf
2024-02-29 15:18 ` Rafael J. Wysocki
2024-02-29 16:13 ` Stanislaw Gruszka
2024-02-29 16:24 ` Rafael J. Wysocki
2024-03-27 13:53 ` Rafael J. Wysocki
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=22a264118ebe7194cf43a5d7e1d61417feff8534.camel@linux.intel.com \
--to=srinivas.pandruvada@linux.intel.com \
--cc=daniel.lezcano@linaro.org \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=fw@strlen.de \
--cc=jiri@resnulli.us \
--cc=johannes@sipsolutions.net \
--cc=kuba@kernel.org \
--cc=linux-pm@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=rafael@kernel.org \
--cc=ricardo.neri-calderon@linux.intel.com \
--cc=stanislaw.gruszka@linux.intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).