From: "Greenwalt, Paul" <paul.greenwalt@intel.com>
To: Andrew Lunn <andrew@lunn.ch>
Cc: <intel-wired-lan@lists.osuosl.org>, <netdev@vger.kernel.org>,
"Pawel Chmielewski" <pawel.chmielewski@intel.com>,
Jesse Brandeburg <jesse.brandeburg@intel.com>
Subject: Re: [PATCH iwl-next 2/7] ice: Refactor finding advertised link speed
Date: Fri, 18 Aug 2023 09:29:08 -0700 [thread overview]
Message-ID: <22cd24d2-6f15-560f-1a5f-f78054d05f40@intel.com> (raw)
In-Reply-To: <240678ed-221f-4893-a410-140c9f4f4674@lunn.ch>
Thanks for the good idea Andrew, and I'm working on a solution.
On 8/16/2023 6:00 PM, Andrew Lunn wrote:
> On Wed, Aug 16, 2023 at 04:57:14PM -0700, Paul Greenwalt wrote:
>> From: Pawel Chmielewski <pawel.chmielewski@intel.com>
>>
>> Refactor ice_get_link_ksettings by using lightweight static link mode
>> maps, populated at module init. This is an efficient solution introduced
>> in commit 1d4e4ecccb11 ("qede: populate supported link modes maps on
>> module init") for qede driver
>
> Could this actually be partially shared with that driver? Some are
> identical. Maybe a generic implementation in net/ethtool/ ?
>
> Andrew
next prev parent reply other threads:[~2023-08-18 16:29 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-08-16 23:57 [PATCH iwl-next 0/7] ice: Add basic E830 support Paul Greenwalt
2023-08-16 23:57 ` [PATCH iwl-next 1/7] ice: Add E830 device IDs, MAC type and registers Paul Greenwalt
2023-08-16 23:57 ` [PATCH iwl-next 2/7] ice: Refactor finding advertised link speed Paul Greenwalt
2023-08-17 1:00 ` Andrew Lunn
2023-08-18 16:29 ` Greenwalt, Paul [this message]
2023-08-19 5:11 ` [Intel-wired-lan] " Paul Menzel
2023-08-16 23:57 ` [PATCH iwl-next 3/7] ice: Add 200G speed/phy type use Paul Greenwalt
2023-08-16 23:57 ` [PATCH iwl-next 4/7] ice: Add ice_get_link_status_datalen Paul Greenwalt
2023-08-16 23:57 ` [PATCH iwl-next 5/7] ice: Add support for E830 DDP package segment Paul Greenwalt
2023-08-16 23:57 ` [PATCH iwl-next 6/7] ice: Remove redundant zeroing of the fields Paul Greenwalt
2023-08-16 23:57 ` [PATCH iwl-next 7/7] ice: Enable support for E830 device IDs Paul Greenwalt
2023-08-19 5:03 ` [Intel-wired-lan] " Paul Menzel
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=22cd24d2-6f15-560f-1a5f-f78054d05f40@intel.com \
--to=paul.greenwalt@intel.com \
--cc=andrew@lunn.ch \
--cc=intel-wired-lan@lists.osuosl.org \
--cc=jesse.brandeburg@intel.com \
--cc=netdev@vger.kernel.org \
--cc=pawel.chmielewski@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).