From: Florian Fainelli <f.fainelli@gmail.com>
To: Jonas Gorski <jonas.gorski@gmail.com>,
Florian Fainelli <florian.fainelli@broadcom.com>,
Andrew Lunn <andrew@lunn.ch>, Vladimir Oltean <olteanv@gmail.com>,
"David S. Miller" <davem@davemloft.net>,
Eric Dumazet <edumazet@google.com>,
Jakub Kicinski <kuba@kernel.org>, Paolo Abeni <pabeni@redhat.com>,
Murali Krishna Policharla <murali.policharla@broadcom.com>,
Russell King <linux@armlinux.org.uk>
Cc: Vladimir Oltean <vladimir.oltean@nxp.com>,
netdev@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 5/5] net: dsa: b53: fix jumbo frames on 10/100 ports
Date: Fri, 4 Oct 2024 20:40:01 -0700 [thread overview]
Message-ID: <22d78c1d-8490-461d-b1e7-dbfa02a1218d@gmail.com> (raw)
In-Reply-To: <20241004-b53_jumbo_fixes-v1-5-ce1e54aa7b3c@gmail.com>
On 10/4/2024 1:47 AM, Jonas Gorski wrote:
> All modern chips support and need the 10_100 bit set for supporting jumbo
> frames on 10/100 ports, so instead of enabling it only for 583XX enable
> it for everything except bcm63xx, where the bit is writeable, but does
> nothing.
>
> Tested on BCM53115, where jumbo frames were dropped at 10/100 speeds
> without the bit set.
>
> Fixes: 6ae5834b983a ("net: dsa: b53: add MTU configuration support")
> Signed-off-by: Jonas Gorski <jonas.gorski@gmail.com>
Reviewed-by: Florian Fainelli <florian.fainelli@broadcom.com>
--
Florian
next prev parent reply other threads:[~2024-10-05 3:40 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-10-04 8:47 [PATCH 0/5] net: dsa: b53: assorted jumbo frame fixes Jonas Gorski
2024-10-04 8:47 ` [PATCH 1/5] net: dsa: b53: fix jumbo frame mtu check Jonas Gorski
2024-10-05 3:38 ` Florian Fainelli
2024-10-04 8:47 ` [PATCH 2/5] net: dsa: b53: fix max MTU for 1g switches Jonas Gorski
2024-10-05 3:38 ` Florian Fainelli
2024-10-04 8:47 ` [PATCH 3/5] net: dsa: b53: fix max MTU for BCM5325/BCM5365 Jonas Gorski
2024-10-05 3:39 ` Florian Fainelli
2024-10-04 8:47 ` [PATCH 4/5] net: dsa: b53: allow lower MTUs on BCM5325/5365 Jonas Gorski
2024-10-05 3:39 ` Florian Fainelli
2024-10-04 8:47 ` [PATCH 5/5] net: dsa: b53: fix jumbo frames on 10/100 ports Jonas Gorski
2024-10-05 3:40 ` Florian Fainelli [this message]
2024-10-08 8:50 ` [PATCH 0/5] net: dsa: b53: assorted jumbo frame fixes patchwork-bot+netdevbpf
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=22d78c1d-8490-461d-b1e7-dbfa02a1218d@gmail.com \
--to=f.fainelli@gmail.com \
--cc=andrew@lunn.ch \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=florian.fainelli@broadcom.com \
--cc=jonas.gorski@gmail.com \
--cc=kuba@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux@armlinux.org.uk \
--cc=murali.policharla@broadcom.com \
--cc=netdev@vger.kernel.org \
--cc=olteanv@gmail.com \
--cc=pabeni@redhat.com \
--cc=vladimir.oltean@nxp.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).