From: Jacob Keller <jacob.e.keller@intel.com>
To: Jiri Pirko <jiri@resnulli.us>, <netdev@vger.kernel.org>
Cc: <davem@davemloft.net>, <kuba@kernel.org>, <pabeni@redhat.com>,
<edumazet@google.com>, <michael.chan@broadcom.com>,
<jesse.brandeburg@intel.com>, <anthony.l.nguyen@intel.com>,
<tariqt@nvidia.com>, <saeedm@nvidia.com>, <leon@kernel.org>,
<idosch@nvidia.com>, <petrm@nvidia.com>,
<simon.horman@corigine.com>, <aelior@marvell.com>,
<manishc@marvell.com>, <gal@nvidia.com>,
<yinjun.zhang@corigine.com>, <fei.qin@corigine.com>,
<Niklas.Cassel@wdc.com>
Subject: Re: [patch net-next 00/12] devlink: Cleanup params usage
Date: Wed, 25 Jan 2023 10:13:51 -0800 [thread overview]
Message-ID: <22ddf616-4df0-c558-2b38-43da1919040b@intel.com> (raw)
In-Reply-To: <20230125141412.1592256-1-jiri@resnulli.us>
On 1/25/2023 6:14 AM, Jiri Pirko wrote:
> From: Jiri Pirko <jiri@nvidia.com>
>
> This patchset takes care of small cleanup of devlink params usage.
> Some of the patches (first 2/3) are cosmetic, but I would like to
> point couple of interesting ones:
>
The cleanups are good!
> Patch 9 is the main one of this set and introduces devlink instance
> locking for params, similar to other devlink objects. That allows params
> to be registered/unregistered when devlink instance is registered.
>
Makes sense.
> Patches 10-12 change mlx5 code to register non-driverinit params in the
> code they are related to, and thanks to patch 8 this might be when
> devlink instance is registered - for example during devlink reload.
>
I like the cleanup/organization this allows by moving the parameter
registration closer to the code that parameter integrates with.
I read through the series and everything looks ok to me. Thanks for
cleaning up the ice driver!
The whole series is:
Reviewed-by: Jacob Keller <jacob.e.keller@intel.com>
> Jiri Pirko (12):
> net/mlx5: Change devlink param register/unregister function names
> net/mlx5: Covert devlink params registration to use
> devlink_params_register/unregister()
> devlink: make devlink_param_register/unregister static
> devlink: don't work with possible NULL pointer in
> devlink_param_unregister()
> ice: remove pointless calls to devlink_param_driverinit_value_set()
> qed: remove pointless call to devlink_param_driverinit_value_set()
> devlink: make devlink_param_driverinit_value_set() return void
> devlink: put couple of WARN_ONs in
> devlink_param_driverinit_value_get()
> devlink: protect devlink param list by instance lock
> net/mlx5: Move fw reset devlink param to fw reset code
> net/mlx5: Move flow steering devlink param to flow steering code
> net/mlx5: Move eswitch port metadata devlink param to flow eswitch
> code
>
> drivers/net/ethernet/intel/ice/ice_devlink.c | 20 +-
> drivers/net/ethernet/mellanox/mlx4/main.c | 80 ++---
> drivers/net/ethernet/mellanox/mlx5/core/dev.c | 18 +-
> .../net/ethernet/mellanox/mlx5/core/devlink.c | 283 +++++-------------
> .../net/ethernet/mellanox/mlx5/core/devlink.h | 4 +-
> drivers/net/ethernet/mellanox/mlx5/core/eq.c | 12 +-
> .../net/ethernet/mellanox/mlx5/core/eswitch.c | 10 +-
> .../net/ethernet/mellanox/mlx5/core/eswitch.h | 4 +-
> .../mellanox/mlx5/core/eswitch_offloads.c | 92 +++++-
> .../net/ethernet/mellanox/mlx5/core/fs_core.c | 84 +++++-
> .../ethernet/mellanox/mlx5/core/fw_reset.c | 44 ++-
> .../ethernet/mellanox/mlx5/core/fw_reset.h | 2 -
> .../net/ethernet/mellanox/mlx5/core/main.c | 22 +-
> drivers/net/ethernet/mellanox/mlxsw/core.c | 18 +-
> .../net/ethernet/mellanox/mlxsw/spectrum.c | 16 +-
> .../ethernet/netronome/nfp/devlink_param.c | 8 +-
> .../net/ethernet/netronome/nfp/nfp_net_main.c | 7 +-
> drivers/net/ethernet/qlogic/qed/qed_devlink.c | 6 -
> drivers/net/netdevsim/dev.c | 36 +--
> include/net/devlink.h | 20 +-
> net/devlink/leftover.c | 185 ++++++------
> 21 files changed, 521 insertions(+), 450 deletions(-)
>
prev parent reply other threads:[~2023-01-25 18:14 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-01-25 14:14 [patch net-next 00/12] devlink: Cleanup params usage Jiri Pirko
2023-01-25 14:14 ` [patch net-next 01/12] net/mlx5: Change devlink param register/unregister function names Jiri Pirko
2023-01-25 14:14 ` [patch net-next 02/12] net/mlx5: Covert devlink params registration to use devlink_params_register/unregister() Jiri Pirko
2023-01-25 14:14 ` [patch net-next 03/12] devlink: make devlink_param_register/unregister static Jiri Pirko
2023-01-25 14:14 ` [patch net-next 04/12] devlink: don't work with possible NULL pointer in devlink_param_unregister() Jiri Pirko
2023-01-25 14:14 ` [patch net-next 05/12] ice: remove pointless calls to devlink_param_driverinit_value_set() Jiri Pirko
2023-01-25 14:14 ` [patch net-next 06/12] qed: remove pointless call " Jiri Pirko
2023-01-25 14:14 ` [patch net-next 07/12] devlink: make devlink_param_driverinit_value_set() return void Jiri Pirko
2023-01-25 14:14 ` [patch net-next 08/12] devlink: put couple of WARN_ONs in devlink_param_driverinit_value_get() Jiri Pirko
2023-01-25 14:14 ` [patch net-next 09/12] devlink: protect devlink param list by instance lock Jiri Pirko
2023-01-26 7:50 ` Ido Schimmel
2023-01-25 14:14 ` [patch net-next 10/12] net/mlx5: Move fw reset devlink param to fw reset code Jiri Pirko
2023-01-25 14:14 ` [patch net-next 11/12] net/mlx5: Move flow steering devlink param to flow steering code Jiri Pirko
2023-01-25 14:14 ` [patch net-next 12/12] net/mlx5: Move eswitch port metadata devlink param to flow eswitch code Jiri Pirko
2023-01-25 17:40 ` Jiri Pirko
2023-01-25 17:49 ` [patch net-next 00/12] devlink: Cleanup params usage Jakub Kicinski
2023-01-25 18:13 ` Jacob Keller [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=22ddf616-4df0-c558-2b38-43da1919040b@intel.com \
--to=jacob.e.keller@intel.com \
--cc=Niklas.Cassel@wdc.com \
--cc=aelior@marvell.com \
--cc=anthony.l.nguyen@intel.com \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=fei.qin@corigine.com \
--cc=gal@nvidia.com \
--cc=idosch@nvidia.com \
--cc=jesse.brandeburg@intel.com \
--cc=jiri@resnulli.us \
--cc=kuba@kernel.org \
--cc=leon@kernel.org \
--cc=manishc@marvell.com \
--cc=michael.chan@broadcom.com \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=petrm@nvidia.com \
--cc=saeedm@nvidia.com \
--cc=simon.horman@corigine.com \
--cc=tariqt@nvidia.com \
--cc=yinjun.zhang@corigine.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).