From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-ed1-f47.google.com (mail-ed1-f47.google.com [209.85.208.47]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 3D06423D2A4 for ; Tue, 15 Jul 2025 11:49:09 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.208.47 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1752580151; cv=none; b=VGUUNhJDb1CRhHPA2XzJ81ZCRYTdHAt2PckfxkzpgYLx07UCwr6DNnYW6o8UHOmheHB29raLa0vv7bPTmPJJ5uMbmymQGxor9KsYGA5IpWUitnpbKlyDlV5RlK9xWsGSKUM53WMhRAW9mQ6CXLJ6X/pkqk+ghClL2f2RP5OOtKQ= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1752580151; c=relaxed/simple; bh=H65xc5R0MlyO0nD0fYmQfSB1vnTb//tbsmGqm0vbgPk=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=cQVBa0S2UyAWvXlAkZdxMxeZZtJgU6WpuR8hoA9VmPf34gSuGnW0K4Md+97bVffteo1ReaMbSK+NOWdz9L1nWkld0Hr/izAKOu6NfMnmTrNDK1WPX0K4KU4zUSnUSUVJS+CThKA4Cwzh5AE02bdplqmkxOuZiRB6hqwC/DlLjrY= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=suse.com; spf=pass smtp.mailfrom=suse.com; dkim=pass (2048-bit key) header.d=suse.com header.i=@suse.com header.b=CPN0oTWo; arc=none smtp.client-ip=209.85.208.47 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=suse.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=suse.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=suse.com header.i=@suse.com header.b="CPN0oTWo" Received: by mail-ed1-f47.google.com with SMTP id 4fb4d7f45d1cf-60780d74c85so7771197a12.2 for ; Tue, 15 Jul 2025 04:49:09 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=google; t=1752580148; x=1753184948; darn=vger.kernel.org; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=oYFAX28B73ZWV81uVTn+uVGouCQNziKk/Cb++ZONJv0=; b=CPN0oTWok489uuh/Ul0GxV71e8yodVgNEnbtawWwqo+8q4/TmYy/LEtF0wKOv+2kIz 40VdXQLTJBnJ0ipt8SXlIk2bkkSFvutUMq0iI1ZN2bO2PX94O66qcWHHsjzIxjKrAOCx JcBJxDKjNWtPMzwq2m7utfVrrM3CW1zWHx4pf1A9bcAh+XkFJQ6CyUL3dU4NqfZxHOeB e7XCDagxk2k2hQ9akBZvvhZoUEq0Vt3fi8EjW6iBfYm+mJ4QRi+S6reMy+D4KDg/5uJx JKe2ywOCQQqyiysPap4IT0zMeACSUj+GVNWezEi6chw8q6ce06JFcRLw/fPSXkm6FOWY G7Ow== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1752580148; x=1753184948; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=oYFAX28B73ZWV81uVTn+uVGouCQNziKk/Cb++ZONJv0=; b=udmTvCnvXA1+5coVGLSIhQRlIMhCYFhBQEtX6Mz+Vko6gYV3oQfn1N1zbrZO/tkZTe Okmc7Cy9sepHZx6qMM9A6/co6cZ7rpTSYEvm7p7Cd40XrNNcy+zNNcG6Mu3W+cwXCylB BcYkEEA7RNnR3NK1RWMjTEgiEckICqBeDMP+1aHvDeLMeXauiaUJGBm90evyAWfv179S C4kX/dhHIyv0yzuHOwT0TUBJLbmF7tbNKHvlQwG50W97Q/g9WZXJsd7FpI777ZVXAgTO vfRueVuj2PBpuBi5UEiHulQN5wRLiOATFWTfnsjUJbTBrlVzRbTmMUgjm14q/RbtWYCE d55w== X-Forwarded-Encrypted: i=1; AJvYcCVOtogBqv57zk8vU5eL96ldlYAH4PMQQE1ZGwoQP3mO0YdNZdikykrWxUjMc+oNFG+FdpL6Jno=@vger.kernel.org X-Gm-Message-State: AOJu0Yx4JC6T4pfEZW1+AXDjVhYpRlwHW6gllmWZ7zr/JCx/SbiYMpg/ ckSHGe0PvGsWL0Ls5nf4JIwvn0x9b1vBwT4WnHKIWzVtNKvvubVzO3OF9hokOUVpFLA= X-Gm-Gg: ASbGncuN3lgmGbL13uEK+ziDAxL5+L5wfo5sA4WXXXNcaQUBOugKGCs0Ys+3/zWb/1B K3U0ckn6KjIPIiGohwlhfUj0Yyvk1WG2wUgL4GF6J1Bk4Jf9IZJ22yNabxe7TAIUaKdGqeRFsKz p/RqWuOETqESOmTQNujM9TtbRm1kETXrFBVXVT6vRUjJJ2wqY0OZOocZMizCL6MUJCDKT4sOAEW NRy0kX3H3lPAwUK6wkbNC68ko1ayR4Wgck+0tDDBYWMFEjrXZzhLYXhuRdZ7cAPJMmjJgSglflG Wy6wpzhm8afkrtxd8kFdX8KW4NZiPlJrWxAGnUrbejrluJeaYfSIWvqIbyRJJkAR0WYDMGREEDe YHWoPdmYgSxZlgUTAYdL97mQVEvzPvH0L7Haz9vTm72ma/sWQwmTAaU2LZ76NCbJoDA== X-Google-Smtp-Source: AGHT+IGpZJAcfXHpIV6qXP8Zk9PSOKUee3mFWI6sjN8MP30hMErhwYj770Upg2/rLyzH0ZZRMVTPig== X-Received: by 2002:a17:906:f5aa:b0:ae3:5e70:32fb with SMTP id a640c23a62f3a-ae9b9488e4cmr232066866b.4.1752580147476; Tue, 15 Jul 2025 04:49:07 -0700 (PDT) Received: from ?IPV6:2001:a61:1337:8001:1c60:c024:2a6e:24da? ([2001:a61:1337:8001:1c60:c024:2a6e:24da]) by smtp.gmail.com with ESMTPSA id a640c23a62f3a-ae6e7e91d05sm984882066b.3.2025.07.15.04.49.06 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 15 Jul 2025 04:49:07 -0700 (PDT) Message-ID: <22e2c652-7861-48d2-b769-79b2ef4ea878@suse.com> Date: Tue, 15 Jul 2025 13:49:06 +0200 Precedence: bulk X-Mailing-List: netdev@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH] net: usbnet: Avoid potential RCU stall on LINK_CHANGE event To: John Ernberg , Oliver Neukum , Andrew Lunn , "David S . Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni Cc: Ming Lei , "netdev@vger.kernel.org" , "linux-usb@vger.kernel.org" , "linux-kernel@vger.kernel.org" , "stable@vger.kernel.org" References: <20250710085028.1070922-1-john.ernberg@actia.se> Content-Language: en-US From: Oliver Neukum In-Reply-To: <20250710085028.1070922-1-john.ernberg@actia.se> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit On 10.07.25 10:50, John Ernberg wrote: > Having a Gemalto Cinterion PLS83-W modem attached to USB and activating the > cellular data link would sometimes yield the following RCU stall, leading > to a system freeze: [..] > if (!netif_carrier_ok(dev->net)) { > /* kill URBs for reading packets to save bus bandwidth */ > + usbnet_pause_rx(dev); > unlink_urbs(dev, &dev->rxq); > + usbnet_resume_rx(dev); This will schedule work. Do you really want that? Regards Oliver