Netdev List
 help / color / mirror / Atom feed
From: Somnath Kotur <somnath.kotur@emulex.com>
To: <netdev@vger.kernel.org>
Cc: Somnath Kotur <somnath.kotur@emulex.com>
Subject: [PATCH net-next 1/5] be2net: Fix to not set link speed for disabled functions of a UMC card
Date: Wed, 2 May 2012 19:10:16 +0530	[thread overview]
Message-ID: <22f64dbf-b01b-4e79-9d50-86138b289b2a@exht1.ad.emulex.com> (raw)

This renders the interface view somewhat inconsistent from the Host OS POV
considering the rest of the interfaces are showing their respective speeds
based on the bandwidth assigned to them.

Signed-off-by: Somnath Kotur <somnath.kotur@emulex.com>
---
 drivers/net/ethernet/emulex/benet/be_ethtool.c |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)

diff --git a/drivers/net/ethernet/emulex/benet/be_ethtool.c b/drivers/net/ethernet/emulex/benet/be_ethtool.c
index 7b06f35..c9ba2cb 100644
--- a/drivers/net/ethernet/emulex/benet/be_ethtool.c
+++ b/drivers/net/ethernet/emulex/benet/be_ethtool.c
@@ -558,7 +558,7 @@ static int be_get_settings(struct net_device *netdev, struct ethtool_cmd *ecmd)
 				be_link_status_update(adapter, link_status);
 			if (link_speed)
 				et_speed = link_speed * 10;
-			else
+			else if (link_status)
 				et_speed = convert_to_et_speed(port_speed);
 		} else {
 			et_speed = adapter->phy.forced_port_speed;
-- 
1.5.6.1

             reply	other threads:[~2012-05-02 13:41 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-05-02 13:40 Somnath Kotur [this message]
  -- strict thread matches above, loose matches on Subject: below --
2012-04-30  6:04 [PATCH net-next 1/5] be2net: Fix to not set link speed for disabled functions of a UMC card Somnath Kotur
2012-04-26 14:30 Somnath Kotur
2012-04-26 14:27 Somnath Kotur

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=22f64dbf-b01b-4e79-9d50-86138b289b2a@exht1.ad.emulex.com \
    --to=somnath.kotur@emulex.com \
    --cc=netdev@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox