From: Gerhard Engleder <gerhard@engleder-embedded.com>
To: Dan Carpenter <dan.carpenter@linaro.org>,
Sasha Neftin <sasha.neftin@intel.com>
Cc: Tony Nguyen <anthony.l.nguyen@intel.com>,
Przemek Kitszel <przemyslaw.kitszel@intel.com>,
"David S. Miller" <davem@davemloft.net>,
Eric Dumazet <edumazet@google.com>,
Jakub Kicinski <kuba@kernel.org>, Paolo Abeni <pabeni@redhat.com>,
intel-wired-lan@lists.osuosl.org, netdev@vger.kernel.org,
linux-kernel@vger.kernel.org, kernel-janitors@vger.kernel.org
Subject: Re: [PATCH net] igc: Unlock on error in igc_io_resume()
Date: Thu, 29 Aug 2024 21:26:58 +0200 [thread overview]
Message-ID: <23021c75-3dcb-404c-bf79-cef583f4600a@engleder-embedded.com> (raw)
In-Reply-To: <64a982d3-a2f5-4ef7-ad75-61f6bb1fae24@stanley.mountain>
On 29.08.24 21:22, Dan Carpenter wrote:
> Call rtnl_unlock() on this error path, before returning.
>
> Fixes: bc23aa949aeb ("igc: Add pcie error handler support")
> Signed-off-by: Dan Carpenter <dan.carpenter@linaro.org>
> ---
> drivers/net/ethernet/intel/igc/igc_main.c | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/drivers/net/ethernet/intel/igc/igc_main.c b/drivers/net/ethernet/intel/igc/igc_main.c
> index dfd6c00b4205..0a095cdea4fb 100644
> --- a/drivers/net/ethernet/intel/igc/igc_main.c
> +++ b/drivers/net/ethernet/intel/igc/igc_main.c
> @@ -7413,6 +7413,7 @@ static void igc_io_resume(struct pci_dev *pdev)
> rtnl_lock();
> if (netif_running(netdev)) {
> if (igc_open(netdev)) {
> + rtnl_unlock();
> netdev_err(netdev, "igc_open failed after reset\n");
> return;
> }
Reviewed-by: Gerhard Engleder <gerhard@engleder-embedded.com>
next prev parent reply other threads:[~2024-08-29 19:27 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-08-29 19:22 [PATCH net] igc: Unlock on error in igc_io_resume() Dan Carpenter
2024-08-29 19:26 ` Gerhard Engleder [this message]
2024-09-02 12:50 ` patchwork-bot+netdevbpf
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=23021c75-3dcb-404c-bf79-cef583f4600a@engleder-embedded.com \
--to=gerhard@engleder-embedded.com \
--cc=anthony.l.nguyen@intel.com \
--cc=dan.carpenter@linaro.org \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=intel-wired-lan@lists.osuosl.org \
--cc=kernel-janitors@vger.kernel.org \
--cc=kuba@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=przemyslaw.kitszel@intel.com \
--cc=sasha.neftin@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).