netdev.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: David Ahern <dsahern@gmail.com>
To: "lizhijian@fujitsu.com" <lizhijian@fujitsu.com>,
	"davem@davemloft.net" <davem@davemloft.net>,
	"kuba@kernel.org" <kuba@kernel.org>,
	"shuah@kernel.org" <shuah@kernel.org>
Cc: "netdev@vger.kernel.org" <netdev@vger.kernel.org>,
	"linux-kselftest@vger.kernel.org"
	<linux-kselftest@vger.kernel.org>,
	"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
	Jie2x Zhou <jie2x.zhou@intel.com>,
	"Li Zhijian(intel)" <zhijianx.li@intel.com>
Subject: Re: [PATCH v2] selftests: net: Correct case name
Date: Tue, 7 Dec 2021 20:01:16 -0700	[thread overview]
Message-ID: <230a5b4f-2cbf-4911-5231-b05bf6a44571@gmail.com> (raw)
In-Reply-To: <bbb91e78-018f-c09c-47db-119010c810c2@fujitsu.com>

On 12/6/21 11:05 PM, lizhijian@fujitsu.com wrote:
>> #################################################################
>> With VRF
>>
>> TEST: Raw socket bind to local address - ns-A IP                              [ OK ]
>> TEST: Raw socket bind to local address after device bind - ns-A IP            [ OK ]
>> TEST: Raw socket bind to local address after VRF bind - ns-A IP               [ OK ]
>> TEST: Raw socket bind to local address - VRF IP                               [FAIL]
>>
> 
> i found that above case failed with "server: error binding socket: 99: Cannot assign requested address"
> i have manually check it with below command after setup(), same errors:
> 
> # ip netns exec ns-A nettest -s -R -P icmp -l 172.16.3.1 -b
> 05:55:11 server: error binding socket: 99: Cannot assign requested address
> 
> But when i specified specific network interface, it works
> # ip netns exec ns-A nettest -s -R -P icmp -l 172.16.3.1 -b -I red
> # echo $?
> 0
> # ip netns exec ns-A nettest -s -R -P icmp -l 172.16.3.1 -b
> 06:01:55 server: error binding socket: 99: Cannot assign requested address
> # echo $?
> 1
> 
> 
> So i wonder if i missed something ?
> 

That test should be a negative test as is the first one in that group -
in both cases the address bind should fail since the socket is not in
the VRF but the address is. The first on currently shows "OK" but that
is because of 5cad8bce26e01 that made changes to the config to validate
MD5 changes. Will send a patch to fix.


  reply	other threads:[~2021-12-08  3:01 UTC|newest]

Thread overview: 13+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-12-02  2:28 [PATCH v2] selftests: net: Correct case name Li Zhijian
2021-12-02 12:20 ` patchwork-bot+netdevbpf
2021-12-07  6:05 ` lizhijian
2021-12-08  3:01   ` David Ahern [this message]
2021-12-08  3:28     ` lizhijian
2021-12-08  3:14   ` David Ahern
2021-12-08  3:38     ` lizhijian
2021-12-08  4:07       ` David Ahern
2021-12-13  3:08         ` Zhou, Jie2X
2021-12-13  4:09           ` David Ahern
2021-12-13  9:44             ` Zhou, Jie2X
2021-12-13 15:58               ` David Ahern
2021-12-15  1:36                 ` Zhou, Jie2X

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=230a5b4f-2cbf-4911-5231-b05bf6a44571@gmail.com \
    --to=dsahern@gmail.com \
    --cc=davem@davemloft.net \
    --cc=jie2x.zhou@intel.com \
    --cc=kuba@kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-kselftest@vger.kernel.org \
    --cc=lizhijian@fujitsu.com \
    --cc=netdev@vger.kernel.org \
    --cc=shuah@kernel.org \
    --cc=zhijianx.li@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).