From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-7.0 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_PASS autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 588B7C43381 for ; Mon, 1 Apr 2019 19:07:07 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 2E03520830 for ; Mon, 1 Apr 2019 19:07:07 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728873AbfDATHC (ORCPT ); Mon, 1 Apr 2019 15:07:02 -0400 Received: from gloria.sntech.de ([185.11.138.130]:34048 "EHLO gloria.sntech.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1728716AbfDATHC (ORCPT ); Mon, 1 Apr 2019 15:07:02 -0400 Received: from ip5f5a6320.dynamic.kabel-deutschland.de ([95.90.99.32] helo=diego.localnet) by gloria.sntech.de with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.89) (envelope-from ) id 1hB2Gj-0007GT-N5; Mon, 01 Apr 2019 21:06:53 +0200 From: Heiko =?ISO-8859-1?Q?St=FCbner?= To: Robin Murphy Cc: "Leonidas P. Papadakos" , Maxime Coquelin , Alexandre Torgue , netdev@vger.kernel.org, Jose Abreu , linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, klaus.goger@theobroma-systems.com, philipp.tomsich@theobroma-systems.com Subject: Re: [PATCH 1/2] stmmac: introduce flag to dynamically disable TX offload for rockchip devices Date: Mon, 01 Apr 2019 21:06:53 +0200 Message-ID: <2312344.mOsv7YkeBG@diego> In-Reply-To: <9d65a22a-2288-dc53-0059-ec4a31424dd8@arm.com> References: <20190401181840.31255-1-papadakospan@gmail.com> <9d65a22a-2288-dc53-0059-ec4a31424dd8@arm.com> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org Am Montag, 1. April 2019, 20:54:45 CEST schrieb Robin Murphy: > On 01/04/2019 19:18, Leonidas P. Papadakos wrote: > > From: =?UTF-8?q?Kamil=20Trzci=C5=84ski?= > > > > Some rockchip boards exhibit an issue where tx checksumming does not work with > > packets larger than 1498. > > Is it really a board-level problem? I'm no networking expert, but the > nature of the workaround suggests this is more likely to be some > inherent limitation of the IP block in the SoC, rather than something to > do with how the external pins get wired up. Does anyone have an RK3328 > or RK3399 board that provably *does* checksum large packets correctly? I don't have that many rk3399-boards with actual ethernet and even only the rock64 from rk3328-land, but at least my rk3399-firefly also seems affected by this. But so far the rk3399-puma board from Theobroma did not show that ethernet issue for me, so I've added two Theobroma people who may or may not tell if they've also seen that issue. > > > This is bad for network stability. > > > > The previous approach was using force_thresh_dma_mode in the board dts, which > > does more than we need. > > If indeed it is a SoC-level thing (or at least we want to treat it as > such), then couldn't we just hang it off the existing SoC-specific > compatibles in dwmac-rk.c and avoid the need for a new DT property at > all? After all, that's precisely why SoC-specific compatibles are a > thing in the first place. > > Robin. > > > Signed-off-by: Leonidas P. Papadakos > > --- > > drivers/net/ethernet/stmicro/stmmac/stmmac_main.c | 4 ++++ > > drivers/net/ethernet/stmicro/stmmac/stmmac_platform.c | 2 ++ > > include/linux/stmmac.h | 1 + > > 3 files changed, 7 insertions(+) > > > > diff --git a/drivers/net/ethernet/stmicro/stmmac/stmmac_main.c b/drivers/net/ethernet/stmicro/stmmac/stmmac_main.c > > index 6a2e1031a..4552147e9 100644 > > --- a/drivers/net/ethernet/stmicro/stmmac/stmmac_main.c > > +++ b/drivers/net/ethernet/stmicro/stmmac/stmmac_main.c > > @@ -3660,6 +3660,10 @@ static netdev_features_t stmmac_fix_features(struct net_device *dev, > > if (priv->plat->bugged_jumbo && (dev->mtu > ETH_DATA_LEN)) > > features &= ~NETIF_F_CSUM_MASK; > > > > + /* Including very small MTUs of 1498 for Rockchip devices */ > > + if (priv->plat->bugged_tx_coe && (dev->mtu > ETH_DATA_LEN - 2)) > > + features &= ~NETIF_F_CSUM_MASK; > > + > > /* Disable tso if asked by ethtool */ > > if ((priv->plat->tso_en) && (priv->dma_cap.tsoen)) { > > if (features & NETIF_F_TSO) > > diff --git a/drivers/net/ethernet/stmicro/stmmac/stmmac_platform.c b/drivers/net/ethernet/stmicro/stmmac/stmmac_platform.c > > index 3031f2bf1..807cf5826 100644 > > --- a/drivers/net/ethernet/stmicro/stmmac/stmmac_platform.c > > +++ b/drivers/net/ethernet/stmicro/stmmac/stmmac_platform.c > > @@ -519,6 +519,8 @@ stmmac_probe_config_dt(struct platform_device *pdev, const char **mac) > > pr_warn("force_sf_dma_mode is ignored if force_thresh_dma_mode is set."); > > } > > > > + plat->bugged_tx_coe = of_property_read_bool(np, "rockchip,bugged_tx_coe"); > > + > > of_property_read_u32(np, "snps,ps-speed", &plat->mac_port_sel_speed); > > > > plat->axi = stmmac_axi_setup(pdev); > > diff --git a/include/linux/stmmac.h b/include/linux/stmmac.h > > index 4335bd771..60c411f43 100644 > > --- a/include/linux/stmmac.h > > +++ b/include/linux/stmmac.h > > @@ -162,6 +162,7 @@ struct plat_stmmacenet_data { > > int pmt; > > int force_sf_dma_mode; > > int force_thresh_dma_mode; > > + int bugged_tx_coe; > > int riwt_off; > > int max_speed; > > int maxmtu; > > >