From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-7.0 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id A5060C43381 for ; Wed, 6 Mar 2019 09:13:41 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 7F81820840 for ; Wed, 6 Mar 2019 09:13:41 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1729610AbfCFJNk (ORCPT ); Wed, 6 Mar 2019 04:13:40 -0500 Received: from szxga07-in.huawei.com ([45.249.212.35]:37314 "EHLO huawei.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1729595AbfCFJNk (ORCPT ); Wed, 6 Mar 2019 04:13:40 -0500 Received: from DGGEMS401-HUB.china.huawei.com (unknown [172.30.72.60]) by Forcepoint Email with ESMTP id 5858768F7DE18E8D8E1; Wed, 6 Mar 2019 17:13:38 +0800 (CST) Received: from [127.0.0.1] (10.74.191.121) by DGGEMS401-HUB.china.huawei.com (10.3.19.201) with Microsoft SMTP Server id 14.3.408.0; Wed, 6 Mar 2019 17:13:29 +0800 Subject: Re: [PATCH net] net: hns3: Fix a logical vs bitwise typo To: Dan Carpenter , Yisen Zhuang CC: Salil Mehta , "David S. Miller" , , References: <20190306081234.GC2625@kadam> From: Yunsheng Lin Message-ID: <23182405-874e-0ede-a13b-c67dfdb041b6@huawei.com> Date: Wed, 6 Mar 2019 17:13:29 +0800 User-Agent: Mozilla/5.0 (Windows NT 6.1; WOW64; rv:52.0) Gecko/20100101 Thunderbird/52.2.0 MIME-Version: 1.0 In-Reply-To: <20190306081234.GC2625@kadam> Content-Type: text/plain; charset="utf-8" Content-Language: en-US Content-Transfer-Encoding: 7bit X-Originating-IP: [10.74.191.121] X-CFilter-Loop: Reflected Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org On 2019/3/6 16:12, Dan Carpenter wrote: > There were a couple logical ORs accidentally mixed in with the bitwise > ORs. Thanks for the fix. Reviewed-by: Yunsheng Lin > > Fixes: e8149933b1fa ("net: hns3: remove hnae3_get_bit in data path") > Signed-off-by: Dan Carpenter > --- > Very recent bug. > > drivers/net/ethernet/hisilicon/hns3/hns3_enet.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/drivers/net/ethernet/hisilicon/hns3/hns3_enet.c b/drivers/net/ethernet/hisilicon/hns3/hns3_enet.c > index 3cb43b1f1c2e..1e4efc47c7a5 100644 > --- a/drivers/net/ethernet/hisilicon/hns3/hns3_enet.c > +++ b/drivers/net/ethernet/hisilicon/hns3/hns3_enet.c > @@ -2321,8 +2321,8 @@ static void hns3_rx_checksum(struct hns3_enet_ring *ring, struct sk_buff *skb, > if (!(bd_base_info & BIT(HNS3_RXD_L3L4P_B))) > return; > > - if (unlikely(l234info & (BIT(HNS3_RXD_L3E_B) | BIT(HNS3_RXD_L4E_B) || > - BIT(HNS3_RXD_OL3E_B) || > + if (unlikely(l234info & (BIT(HNS3_RXD_L3E_B) | BIT(HNS3_RXD_L4E_B) | > + BIT(HNS3_RXD_OL3E_B) | > BIT(HNS3_RXD_OL4E_B)))) { > u64_stats_update_begin(&ring->syncp); > ring->stats.l3l4_csum_err++; >