From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id A1546C77B75 for ; Tue, 18 Apr 2023 11:31:27 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230317AbjDRLb0 (ORCPT ); Tue, 18 Apr 2023 07:31:26 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:41902 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229456AbjDRLbX (ORCPT ); Tue, 18 Apr 2023 07:31:23 -0400 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 79EBE6EAF for ; Tue, 18 Apr 2023 04:30:39 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1681817433; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=2NZNcaQomO+NKqJjtar1Xw2NrVLmqvUkGrhPIreowuY=; b=iXVVYpFbERhSIPX0GBQyIIoLw7rspQN+C5RwCdhm6LuD0G7r+ndmSwHYC1Ec27x1ENvJ6T gHKQeGtzhhcYfK5Gd+FxhWwCyM54q0PB5toZCKMlTnH70HZWt7U6CY8ZM01nLDnSmyMrM6 PKSwgzXqk8HvUbFGgObSkcY0BY+P+lQ= Received: from mail-ej1-f72.google.com (mail-ej1-f72.google.com [209.85.218.72]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-622-D83mXsNHM52Iul-PxOCw4A-1; Tue, 18 Apr 2023 07:30:32 -0400 X-MC-Unique: D83mXsNHM52Iul-PxOCw4A-1 Received: by mail-ej1-f72.google.com with SMTP id jj28-20020a170907985c00b0094f5d1baecbso2466725ejc.4 for ; Tue, 18 Apr 2023 04:30:31 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1681817431; x=1684409431; h=content-transfer-encoding:in-reply-to:references:to :content-language:subject:cc:user-agent:mime-version:date:message-id :from:x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=2NZNcaQomO+NKqJjtar1Xw2NrVLmqvUkGrhPIreowuY=; b=e7GpGU1fEAUjS4VBFjJFxnLjiZww8UJYFxYd+6bEuxO7yeQiK2zp57cvBMyRpSK7F/ n9bEsS5QXEQ5kReKlooP+liEAP1ad3n9VZrK6fvd2A7goBQkBqjvh02+5xKOFmdXpEeA EyA57lCn2GIuqfnWaS7c7ud5Lst8rZqtPN7aXn7D5EjNObWQhZsAYcZ3Lkveeue5wbFe WZIbThDVQEWpoyWtcC+6tQarx4ynCo10wwyZKcmgBm6dxtYAx4wF3iUw94u/49hRL2+r roxxMLxsKBoGbyTY31fW4E0i/nNiUYr+eF8exUD/EsbWmYret6n5wSfhD+E+qNc6Agsk 9L/Q== X-Gm-Message-State: AAQBX9cHRECN1TOm1kCdAUnK7poD7P62q5Vhc52C7aqG+Ldhi0ajgLzT WQHK1bJ+qMl6tFRKv85SNqrANgc32Gdgi2yrLBHSUbLEduK3MENkwnXy0H8oIANUSrOpw7Fnz55 ah9i8/5kal03x8czD X-Received: by 2002:a17:906:f843:b0:94e:aa8e:b56e with SMTP id ks3-20020a170906f84300b0094eaa8eb56emr9920075ejb.33.1681817431001; Tue, 18 Apr 2023 04:30:31 -0700 (PDT) X-Google-Smtp-Source: AKy350acIP+hvK0ByCevyOjLp2f/7rZYWRoDzXgAVCS6a3+YiQfrV/CAqZB6bAiO8cFkN23mV6I27Q== X-Received: by 2002:a17:906:f843:b0:94e:aa8e:b56e with SMTP id ks3-20020a170906f84300b0094eaa8eb56emr9920058ejb.33.1681817430677; Tue, 18 Apr 2023 04:30:30 -0700 (PDT) Received: from [192.168.42.222] (194-45-78-10.static.kviknet.net. [194.45.78.10]) by smtp.gmail.com with ESMTPSA id xd10-20020a170907078a00b0095328ce9c8bsm435698ejb.67.2023.04.18.04.30.29 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 18 Apr 2023 04:30:30 -0700 (PDT) From: Jesper Dangaard Brouer X-Google-Original-From: Jesper Dangaard Brouer Message-ID: <231f26bf-4dc7-81ed-fd2d-91badb3af6b9@redhat.com> Date: Tue, 18 Apr 2023 13:30:29 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.8.0 Cc: brouer@redhat.com, "netdev@vger.kernel.org" , "martin.lau@kernel.org" , "ast@kernel.org" , "daniel@iogearbox.net" , "Lobakin, Aleksander" , "Zaremba, Larysa" , "xdp-hints@xdp-project.net" , "intel-wired-lan@lists.osuosl.org" , "pabeni@redhat.com" , "Brandeburg, Jesse" , "kuba@kernel.org" , "edumazet@google.com" , "john.fastabend@gmail.com" , "hawk@kernel.org" , "davem@davemloft.net" Subject: Re: [xdp-hints] [PATCH bpf-next V1 3/5] igc: add XDP hints kfuncs for RX timestamp Content-Language: en-US To: "Song, Yoong Siang" , "bpf@vger.kernel.org" , Stanislav Fomichev , =?UTF-8?B?VG9rZSBIw7hpbGFuZC1Kw7hyZ2Vu?= =?UTF-8?Q?sen?= References: <168174338054.593471.8312147519616671551.stgit@firesoul> <168174343801.593471.10686331901576935015.stgit@firesoul> In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org On 18/04/2023 06.16, Song, Yoong Siang wrote: > On Monday, April 17, 2023 10:57 PM, Jesper Dangaard Brouer wrote: [...] >> diff --git a/drivers/net/ethernet/intel/igc/igc_main.c >> b/drivers/net/ethernet/intel/igc/igc_main.c >> index 3a844cf5be3f..862768d5d134 100644 >> --- a/drivers/net/ethernet/intel/igc/igc_main.c >> +++ b/drivers/net/ethernet/intel/igc/igc_main.c [...] >> >> +static int igc_xdp_rx_timestamp(const struct xdp_md *_ctx, u64 *timestamp) { >> + const struct igc_xdp_buff *ctx = (void *)_ctx; >> + >> + if (igc_test_staterr(ctx->rx_desc, IGC_RXDADV_STAT_TSIP)) { >> + *timestamp = ctx->rx_ts; >> + >> + return 0; >> + } >> + >> + return -ENODATA; >> +} >> + >> +const struct xdp_metadata_ops igc_xdp_metadata_ops = { > Since igc_xdp_metadata_ops is used in igc_main.c only, suggest to make it static. I agree, and I acknowledge that you have already pointed this our earier, but I forgot when I rebased the patches. Same for 4/5. --Jesper