From: "Gao Feng" <gfree.wind@vip.163.com>
To: "David Miller" <davem@davemloft.net>,
"Eric Dumazet" <eric.dumazet@gmail.com>
Cc: netdev@vger.kernel.org
Subject: Re:Re: [PATCH net-next] net: rps: Add the rfs_needed check when record flow hash
Date: Fri, 26 May 2017 08:32:53 +0800 (CST) [thread overview]
Message-ID: <232a9725.7cb5.15c422b9d3b.Coremail.gfree.wind@vip.163.com> (raw)
In-Reply-To: <20170525.131141.1106125565617394205.davem@davemloft.net>
Hi David & Eric,
At 2017-05-26 01:11:41, "David Miller" <davem@davemloft.net> wrote:
>From: gfree.wind@vip.163.com
>Date: Wed, 24 May 2017 15:35:59 +0800
>
>>
>> +static inline void sock_rps_record_flow_hash(__u32 hash)
>> +{
>> +#ifdef CONFIG_RPS
>> + if (static_key_false(&rfs_needed))
>> + _sock_rps_record_flow_hash(hash);
>> +#endif
>> +}
>> +
>
>This is no longer used.
>
>If you have some plans to use it in another context, you absolutely _MUST_
>post this change inside of a patch series that adds the new user as well.
>
>Otherwise it is impossible to determine the correctness and
>appropriateness of your changes.
>
>Thanks.
The sock_rps_record_flow_hash is still used now.
There is only one caller which is tun_flow_update in file tun.c.
Best Regards
Feng
prev parent reply other threads:[~2017-05-26 0:33 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-05-24 7:35 [PATCH net-next] net: rps: Add the rfs_needed check when record flow hash gfree.wind
2017-05-25 14:55 ` Eric Dumazet
2017-05-25 17:11 ` David Miller
2017-05-26 0:32 ` Gao Feng [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=232a9725.7cb5.15c422b9d3b.Coremail.gfree.wind@vip.163.com \
--to=gfree.wind@vip.163.com \
--cc=davem@davemloft.net \
--cc=eric.dumazet@gmail.com \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox