From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtpout-02.galae.net (smtpout-02.galae.net [185.246.84.56]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id C3CC137996D; Thu, 29 Jan 2026 08:58:47 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=185.246.84.56 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1769677129; cv=none; b=Jk66nA6cwcjMSrO0R5hQQVhd0hpTGBPJYhAU7KKUwuXdb/a2peu7eOYp8V3xeSonQEaqse7SA73Wn6y8eAyvJY41bwWqCcQ6f+qsMBtVwbkVcSXa1oMiKQsPmXUuAwfXCZQ3QzybxdvEH7YXu6SgQOoz4pMbCgcDbfoEQz1JjBA= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1769677129; c=relaxed/simple; bh=n8l5ZMrxRjMfbCzpA/tPyTP1qNe3V/9tguAGw6mAxLs=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version:Content-Type; b=TBX//Xp/mm2CHdE0JvLhnp1F4yvO5Z7gqbboKReUlFceEa+Pspt/tRJ5DIiqmj19VHJx9LHczy9eLU7pEBP6yPv1ejls7GQZrvDImY2/1tsqZjesaDAo9QzYK2rqqIMcTIMENHluL4mC7KuzWk8ZiSaPpJzL6fMUbAAG69HVXE0= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=bootlin.com; spf=pass smtp.mailfrom=bootlin.com; dkim=pass (2048-bit key) header.d=bootlin.com header.i=@bootlin.com header.b=2p89WbYY; arc=none smtp.client-ip=185.246.84.56 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=bootlin.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=bootlin.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=bootlin.com header.i=@bootlin.com header.b="2p89WbYY" Received: from smtpout-01.galae.net (smtpout-01.galae.net [212.83.139.233]) by smtpout-02.galae.net (Postfix) with ESMTPS id 0D9D11A2ADC; Thu, 29 Jan 2026 08:58:46 +0000 (UTC) Received: from mail.galae.net (mail.galae.net [212.83.136.155]) by smtpout-01.galae.net (Postfix) with ESMTPS id D12F1606B6; Thu, 29 Jan 2026 08:58:45 +0000 (UTC) Received: from [127.0.0.1] (localhost [127.0.0.1]) by localhost (Mailerdaemon) with ESMTPSA id 0CC29119A884E; Thu, 29 Jan 2026 09:58:42 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=bootlin.com; s=dkim; t=1769677124; h=from:subject:date:message-id:to:cc:mime-version:content-type: in-reply-to:references; bh=NwKLuSE3r9FFRNMthHrpD7xKUjwlQn1LO7jf3zWxFMk=; b=2p89WbYYYMSjsqxczIeYCPdH/yzIHoQ+aAVZaW7lWWaqNQ6kURtXcb2vY7Md1FBjykS/zN 0mo5IzuQUTT8nfnM/dGXAHXChBKYq0QrLRyYm1IXNccYLz3PTFrjZcqjam+tpq/f2QzkKJ lzLxtTtEEl7agPp+iE69lnhyBUWtTKzQn6HSEyBQGg8yuUfcI3foBn9IWlVvzqYSpEZbhu 1tXh43Y7ZAil0VNEqE5+b3wBsWNElzCR+sVOY/d8shsMBz1qhXHjcSnXzCzig2NezxxZZm /ALhCqr68Lo0ofFpVQfHarIFwbnfJeEK/X9Jt0+jdehABtjEy6I0NpgG7srOQA== From: Romain Gantois To: davem@davemloft.net, Andrew Lunn , Jakub Kicinski , Eric Dumazet , Paolo Abeni , Russell King , Heiner Kallweit , Maxime Chevallier Cc: Maxime Chevallier , netdev@vger.kernel.org, linux-kernel@vger.kernel.org, thomas.petazzoni@bootlin.com, Christophe Leroy , Herve Codina , Florian Fainelli , Vladimir Oltean , =?UTF-8?B?S8O2cnk=?= Maincent , Marek =?UTF-8?B?QmVow7pu?= , Oleksij Rempel , =?UTF-8?B?Tmljb2zDsg==?= Veronese , Simon Horman , mwojtas@chromium.org, Daniel Golle , Dimitri Fedrau Subject: Re: [PATCH net-next 09/13] net: phy: phy_port: Store information about a MII port's occupancy Date: Wed, 28 Jan 2026 17:08:40 +0100 Message-ID: <2338720.iZASKD2KPV@fw-rgant> In-Reply-To: <20260127134202.8208-10-maxime.chevallier@bootlin.com> References: <20260127134202.8208-1-maxime.chevallier@bootlin.com> <20260127134202.8208-10-maxime.chevallier@bootlin.com> Precedence: bulk X-Mailing-List: netdev@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: multipart/signed; boundary="nextPart2028866.PYKUYFuaPT"; micalg="pgp-sha512"; protocol="application/pgp-signature" X-Last-TLS-Session-Version: TLSv1.3 --nextPart2028866.PYKUYFuaPT Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="utf-8"; protected-headers="v1" From: Romain Gantois Date: Wed, 28 Jan 2026 17:08:40 +0100 Message-ID: <2338720.iZASKD2KPV@fw-rgant> In-Reply-To: <20260127134202.8208-10-maxime.chevallier@bootlin.com> MIME-Version: 1.0 On Tuesday, 27 January 2026 14:41:57 CET Maxime Chevallier wrote: > MII phy_ports are not meant to be connected directly to a link partner. > They are meant to feed into some media converter devices, so far we only > support SFP modules for that. > > We have information about what MII they can handle, however we don't > store anything about whether they are currently connected to an SFP > module or not. As phy_port aims at listing the front-facing ports, let's > store an "occupied" bit to know whether or not a MII port is currently > front-facing (i.e. there's no module in the SFP cage), or occupied (i.e. > there's an SFP module). To me, "front-facing" refers to things like user ports on a switch versus CPU- facing ports, I don't find it intuitive to use it to qualify a port's state of being connected to an empty SFP cage. Why not use something like "vacant" or "empty" instead? Thanks, -- Romain Gantois, Bootlin Embedded Linux and Kernel engineering https://bootlin.com --nextPart2028866.PYKUYFuaPT Content-Type: application/pgp-signature; name="signature.asc" Content-Description: This is a digitally signed message part. Content-Transfer-Encoding: 7Bit -----BEGIN PGP SIGNATURE----- iQIzBAABCgAdFiEEIcCsAScRrtr7W0x0KCYAIARzeA4FAml6NIgACgkQKCYAIARz eA6Arw//Yp1G4Zn+BAmiRsh/biEO7ZoLQM7RWf1XXDAq6ifO0U+VDfPKaG486NWY wxLG5XdgOFpdMYYmGUNVwQrekh+tweqj9koWk0GTv3DLCPEcjHYytyD5Zr34AxVv Kf0/fHASfl++5X61zZCZkeY6L4M4uJPbn4WjhkkrYuST0E5KOXbrd4jJt+6Ifiyk Sm8CNy8GJCINyF0wL3n/GBFJ+S2arE/tXcM36YrU8FcG425M6Sj7/DudozKH2zrS F2on+PCydaOm2kHjqmhbIbf96xXMnK0i7OQ1fGsmy3U9mQXW8jXl/NDoruF/oHRv GMjrCVZ7lNb+P+8Klrdj691y0aVP7Wqj/fPFqMRpwGjX49nB1vsLXe2NaDZMPI9c L8vM7FOyV73Lcc2u+i8BBa7EiLTG/tcwqVRCLMYvx8Fqv3HxDMpr82CXjQ66rmb6 t1AazMvYw3KWedwu+SEy88UHEoA/gMP06IJBMXI9W405kOqHsL7aTDJW2nyM6712 O2CQOzGB61MpFjg9/ey1ngvHDJfn9p9dv/Ov+ZTQLaCizZ8vfKIs9wsHXc8TD1/y qQ18TRIQPgjh21knQfzhfAzrT13f79hHDfMwVga/SruMCju6c5I0Z9W9GJQkEbpE m/nxYL38233YM7/Q1bifqMyDv+/cSvVQi3mRCZJEeJQQYtgcrXU= =IEDB -----END PGP SIGNATURE----- --nextPart2028866.PYKUYFuaPT--