Netdev List
 help / color / mirror / Atom feed
From: Andrew Lunn <andrew@lunn.ch>
To: Nicolai Buchwitz <nb@tipi-net.de>
Cc: "James Clark" <jjc@jclark.com>,
	"David S. Miller" <davem@davemloft.net>,
	"Eric Dumazet" <edumazet@kernel.org>,
	"Jakub Kicinski" <kuba@kernel.org>,
	"Paolo Abeni" <pabeni@redhat.com>,
	"Andrew Lunn" <andrew+netdev@lunn.ch>,
	"Heiner Kallweit" <hkallweit1@gmail.com>,
	"Richard Cochran" <richardcochran@gmail.com>,
	"Florian Fainelli" <florian.fainelli@broadcom.com>,
	"Doug Berger" <opendmb@gmail.com>,
	"Théo Lebrun" <theo.lebrun@bootlin.com>,
	"Russell King" <linux@armlinux.org.uk>,
	"Conor Dooley" <conor.dooley@microchip.com>,
	"Broadcom internal kernel review list"
	<bcm-kernel-feedback-list@broadcom.com>,
	"Thomas Gleixner" <tglx@kernel.org>,
	"Miroslav Lichvar" <mlichvar@redhat.com>,
	netdev@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH net-next 0/5] net: mdio: add timestamped MDIO writes for PHY gettimex64
Date: Mon, 12 Oct 2026 15:18:12 +0200	[thread overview]
Message-ID: <23454c46-95cf-4e46-9621-149bf9350199@lunn.ch> (raw)
In-Reply-To: <db3a0f73c1883645f51294ca46cffe05@tipi-net.de>

On Sun, Oct 11, 2026 at 08:07:13PM +0200, Nicolai Buchwitz wrote:
> Hi Andrew
> 
> On 11.10.2026 15:50, Andrew Lunn wrote:
> > > For example, using PTP_SYS_OFFSET_EXTENDED on the Raspberry Pi CM5 to
> > > synchronize the system clock from the BCM54210PE PHY PHC leads to the
> > > system clock being 32 µs ahead of the PHC. On the CM4, it is about 7
> > > µs.
> > > (The difference is because the MDIO clock frequency is higher on the
> > > CM4: 10 MHz as opposed to 2.08 MHz on the CM5.)
> > 
> > IEEE 802.3 says the clock should be 2.5Mhz. Does the CM4 use a
> > clock-frequency DT property to enable this faster clock?
> > 
> > 	Andrew
> 
> The Pi 400 is the only BCM2711 board with clock-frequency in DT
> (1950000, from a downstream "Limit MDIO clock speed" commit with no
> further explanation). There the driver's assumed 250 MHz reference
> gives divider 63, which with the real 200 MHz (see my comments on
> patch 5) is about 1.56 MHz.
> 
> Pi 4 and CM4 (the one with the PTP PHY) have no clock-frequency, so
> the driver keeps the firmware's divider 9, and 200 MHz / 20 is the
> 10 MHz James mentions.

For CM4, i think the PHY is on the board? Does the MDIO bus get
exported via a connector? If it is a closed system, then running the
bus faster by default is O.K, since it is impossible to connect a
device which is only standards compliant. But if the bus does get
connected to the carrier board, it would be better to stick to 2.5MHz.

	  Andrew

  reply	other threads:[~2026-10-12 13:18 UTC|newest]

Thread overview: 32+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-10-09 14:35 [PATCH net-next 0/5] net: mdio: add timestamped MDIO writes for PHY gettimex64 James Clark
2026-10-09 14:35 ` [PATCH net-next 1/5] net: mdio: add timestamped write operation James Clark
2026-10-10 15:10   ` netdev-bot+sashiko
2026-10-11 14:03   ` Andrew Lunn
2026-10-11 14:33     ` James Clark
2026-10-09 14:35 ` [PATCH net-next 2/5] net: phy: broadcom: use timestamped MDIO writes in gettimex64 James Clark
2026-10-10 15:10   ` netdev-bot+sashiko
2026-10-09 14:35 ` [PATCH net-next 3/5] ptp: add functions to adjust system timestamps James Clark
2026-10-10 15:10   ` netdev-bot+sashiko
2026-10-09 14:35 ` [PATCH net-next 4/5] net: macb: implement timestamped MDIO writes James Clark
2026-10-10 15:10   ` netdev-bot+sashiko
     [not found]   ` <DM1WEUIF8V8V.2OZWRB5G232T4@bootlin.com>
2026-10-11 10:02     ` Théo Lebrun
2026-10-11 13:01     ` James Clark
2026-10-11 21:10     ` Andrew Lunn
2026-10-09 14:35 ` [PATCH net-next 5/5] net: mdio: bcm-unimac: " James Clark
2026-10-09 16:04   ` Florian Fainelli
2026-10-10  1:25     ` James Clark
2026-10-10 15:18     ` Nicolai Buchwitz
2026-10-11  7:20       ` James Clark
2026-10-11 13:22         ` Nicolai Buchwitz
2026-10-12  0:54           ` James Clark
2026-10-12 13:18             ` Nicolai Buchwitz
2026-10-12 11:51           ` Andrew Lunn
2026-10-12 13:21             ` Nicolai Buchwitz
2026-10-10 15:11   ` netdev-bot+sashiko
2026-10-12 12:03   ` Andrew Lunn
2026-10-10  4:55 ` [PATCH net-next 0/5] net: mdio: add timestamped MDIO writes for PHY gettimex64 James Clark
2026-10-11 13:50 ` Andrew Lunn
2026-10-11 14:00   ` James Clark
2026-10-11 18:07   ` Nicolai Buchwitz
2026-10-12 13:18     ` Andrew Lunn [this message]
2026-10-12 13:20       ` Nicolai Buchwitz

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=23454c46-95cf-4e46-9621-149bf9350199@lunn.ch \
    --to=andrew@lunn.ch \
    --cc=andrew+netdev@lunn.ch \
    --cc=bcm-kernel-feedback-list@broadcom.com \
    --cc=conor.dooley@microchip.com \
    --cc=davem@davemloft.net \
    --cc=edumazet@kernel.org \
    --cc=florian.fainelli@broadcom.com \
    --cc=hkallweit1@gmail.com \
    --cc=jjc@jclark.com \
    --cc=kuba@kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux@armlinux.org.uk \
    --cc=mlichvar@redhat.com \
    --cc=nb@tipi-net.de \
    --cc=netdev@vger.kernel.org \
    --cc=opendmb@gmail.com \
    --cc=pabeni@redhat.com \
    --cc=richardcochran@gmail.com \
    --cc=tglx@kernel.org \
    --cc=theo.lebrun@bootlin.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox