From mboxrd@z Thu Jan 1 00:00:00 1970 From: John Fastabend Subject: Re: [PATCH RFC 0/5] Support asynchronous crypto for IPsec GSO. Date: Mon, 20 Nov 2017 10:20:40 -0800 Message-ID: <23468c18-0bdd-4bca-7abd-3cbe0ce48ca0@gmail.com> References: <20171120073752.29094-1-steffen.klassert@secunet.com> <20171120.220922.840932981327545918.davem@davemloft.net> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit Cc: netdev@vger.kernel.org To: David Miller , steffen.klassert@secunet.com Return-path: Received: from mail-pg0-f47.google.com ([74.125.83.47]:37058 "EHLO mail-pg0-f47.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751689AbdKTSUn (ORCPT ); Mon, 20 Nov 2017 13:20:43 -0500 Received: by mail-pg0-f47.google.com with SMTP id o7so8004989pgc.4 for ; Mon, 20 Nov 2017 10:20:43 -0800 (PST) In-Reply-To: <20171120.220922.840932981327545918.davem@davemloft.net> Content-Language: en-US Sender: netdev-owner@vger.kernel.org List-ID: On 11/20/2017 05:09 AM, David Miller wrote: > From: Steffen Klassert > Date: Mon, 20 Nov 2017 08:37:47 +0100 > >> This patchset implements asynchronous crypto handling >> in the layer 2 TX path. With this we can allow IPsec >> ESP GSO for software crypto. This also merges the IPsec >> GSO and non-GSO paths to both use validate_xmit_xfrm(). > ... > > Code looks generally fine to me. Only thing of note is that this > adds a new dev_requeue_skb() call site and that might intersect with > John Fastabend's RFC work to make qdiscs lockless. Right, fortunately it doesn't appear that the conflicts are too hard to resolve. It looks like sch_redirect_xmit() will need to be resolved with an additional check to test if the qdisc lock is needed. Then assuming my reading is correct validate_xmit_xfrm(), xfrm_dev_resume(), and xfrm_dev_backlog() can run without qdisc lock already. Thanks, John > > Also, please adhere to the reverse christmas tree rule for the > ordering of your function local variables. > > Thank you. >