From: Florian Fainelli <f.fainelli@gmail.com>
To: Jakub Kicinski <kuba@kernel.org>, Andrew Lunn <andrew@lunn.ch>,
Vivien Didelot <vivien.didelot@gmail.com>
Cc: netdev <netdev@vger.kernel.org>,
Vladimir Oltean <vladimir.oltean@nxp.com>,
tobias@waldekranz.com
Subject: Re: [PATCH] dsa: mv88e6xxx: Make global2 support mandatory
Date: Sat, 23 Jan 2021 19:24:34 -0800 [thread overview]
Message-ID: <234a7b27-da8b-b224-26f7-d8ff1c03b10a@gmail.com> (raw)
In-Reply-To: <20210123190637.42dad133@kicinski-fedora-pc1c0hjn.dhcp.thefacebook.com>
On 1/23/2021 7:06 PM, Jakub Kicinski wrote:
> On Sat, 23 Jan 2021 21:51:48 +0100 Andrew Lunn wrote:
>> Early generations of the mv88e6xxx did not have the global 2
>> registers. In order to keep the driver slim, it was decided to make
>> the code for these registers optional. Over time, more generations of
>> switches have been added, always supporting global 2 and adding more
>> and more registers. No effort has been made to keep these additional
>> registers also optional to slim the driver down when used for older
>> generations. Optional global 2 now just gives additional development
>> and maintenance burden for no real gain.
>>
>> Make global 2 support always compiled in.
>>
>> Signed-off-by: Andrew Lunn <andrew@lunn.ch>
>
> FWIW doesn't seem to apply to net-next.
Andrew, when you resubmit, can you make the subject be: net: dsa: ... to
be consistent with prior changes? Thanks!
--
Florian
prev parent reply other threads:[~2021-01-24 3:26 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-01-23 20:51 [PATCH] dsa: mv88e6xxx: Make global2 support mandatory Andrew Lunn
2021-01-23 23:50 ` Vladimir Oltean
2021-01-24 3:06 ` Jakub Kicinski
2021-01-24 3:24 ` Florian Fainelli [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=234a7b27-da8b-b224-26f7-d8ff1c03b10a@gmail.com \
--to=f.fainelli@gmail.com \
--cc=andrew@lunn.ch \
--cc=kuba@kernel.org \
--cc=netdev@vger.kernel.org \
--cc=tobias@waldekranz.com \
--cc=vivien.didelot@gmail.com \
--cc=vladimir.oltean@nxp.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox