netdev.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Jay Vosburgh <fubar@us.ibm.com>
To: Andy Gospodarek <andy@greyhouse.net>
Cc: netdev@vger.kernel.org, csnook@redhat.com
Subject: Re: [PATCH] bonding: fix race that causes invalid statistics
Date: Mon, 28 Jan 2008 15:59:03 -0800	[thread overview]
Message-ID: <23624.1201564743@death> (raw)
In-Reply-To: <20080128233825.GA21912@gospo.usersys.redhat.com>

Andy Gospodarek <andy@greyhouse.net> wrote:

>+	memcpy(stats,&local_stats,sizeof(net_device_stats));

	FYI, this generates a compiler error (missing the word "struct"
in here).  Other than not compiling, the patch seems reasonable.  I'll
fix it up and include it in the series I'll post tomorrow or so.

	-J

---
	-Jay Vosburgh, IBM Linux Technology Center, fubar@us.ibm.com

  reply	other threads:[~2008-01-28 23:59 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-01-28 23:38 [PATCH] bonding: fix race that causes invalid statistics Andy Gospodarek
2008-01-28 23:59 ` Jay Vosburgh [this message]
2008-01-29  0:13   ` Chris Snook
2008-01-29  0:38   ` Andy Gospodarek

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=23624.1201564743@death \
    --to=fubar@us.ibm.com \
    --cc=andy@greyhouse.net \
    --cc=csnook@redhat.com \
    --cc=netdev@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).