[PATCH] NET: Mark snmp4_icmp_list[] as being unused

[PATCH] NET: Mark snmp4_icmp_list[] as being unused

[David Howells]

Mark snmp4_icmp_list[] as being unused to avoid the warning it would otherwise
incur.

Signed-off-by: David Howells <dhowells@redhat.com>
---

 net/ipv4/proc.c |    3 ++-
 1 files changed, 2 insertions(+), 1 deletions(-)

diff --git a/net/ipv4/proc.c b/net/ipv4/proc.c
index fd16cb8..1c0854d 100644
--- a/net/ipv4/proc.c
+++ b/net/ipv4/proc.c
@@ -121,7 +121,8 @@ static const struct snmp_mib snmp4_ipextstats_list[] = {
 	SNMP_MIB_SENTINEL
 };
 
-static const struct snmp_mib snmp4_icmp_list[] = {
+static __attribute__((unused))
+const struct snmp_mib snmp4_icmp_list[] = {
 	SNMP_MIB_ITEM("InMsgs", ICMP_MIB_INMSGS),
 	SNMP_MIB_ITEM("InErrors", ICMP_MIB_INERRORS),
 	SNMP_MIB_ITEM("OutMsgs", ICMP_MIB_OUTMSGS),

Re: [PATCH] NET: Mark snmp4_icmp_list[] as being unused

[David Stevens]

What about just removing it, or do you think it's
useful for documentation of the order? Either way,

Acked-by: David L Stevens <dlstevens@us.ibm.com>

                                +-DLS

Re: [PATCH] NET: Mark snmp4_icmp_list[] as being unused

[David Howells]

David Stevens <dlstevens@us.ibm.com> wrote:

> What about just removing it, or do you think it's
> useful for documentation of the order? Either way,

I don't know whether it's intended to be used for something, perhaps a
debugging macro.  Perhaps it should be #if'd out instead.

David

Re: [PATCH] NET: Mark snmp4_icmp_list[] as being unused

[David Stevens]

dhowells@redhat.com wrote on 10/25/2007 04:05:13 PM:

> David Stevens <dlstevens@us.ibm.com> wrote:
> 
> > What about just removing it, or do you think it's
> > useful for documentation of the order? Either way,
> 
> I don't know whether it's intended to be used for something, perhaps a
> debugging macro.  Perhaps it should be #if'd out instead.

        It was used for /proc/net/snmp header printing, but
most of the items in it were moved to a different MIB (by me).
The new values are printed in a backward-compatible way, but
maintaining the old order means not using this header map.
        So, long-winded way of saying I believe it should be
removed, but I missed that when I made it obsolete. :-)

                                                        +-DLS

Re: [PATCH] NET: Mark snmp4_icmp_list[] as being unused

[David Miller]

From: David Stevens <dlstevens@us.ibm.com>
Date: Thu, 25 Oct 2007 18:27:22 -0700

> dhowells@redhat.com wrote on 10/25/2007 04:05:13 PM:
> 
> > David Stevens <dlstevens@us.ibm.com> wrote:
> > 
> > > What about just removing it, or do you think it's
> > > useful for documentation of the order? Either way,
> > 
> > I don't know whether it's intended to be used for something, perhaps a
> > debugging macro.  Perhaps it should be #if'd out instead.
> 
>         It was used for /proc/net/snmp header printing, but
> most of the items in it were moved to a different MIB (by me).
> The new values are printed in a backward-compatible way, but
> maintaining the old order means not using this header map.
>         So, long-winded way of saying I believe it should be
> removed, but I missed that when I made it obsolete. :-)

I've checked just such a change into my tree.

Thanks!