public inbox for netdev@vger.kernel.org
 help / color / mirror / Atom feed
From: Michael Gur <michaelgur@nvidia.com>
To: David Ahern <dsahern@gmail.com>,
	Chiara Meiohas <cmeiohas@nvidia.com>,
	leon@kernel.org, stephen@networkplumber.org
Cc: jgg@nvidia.com, linux-rdma@vger.kernel.org, netdev@vger.kernel.org
Subject: Re: [PATCH iproute2-next 0/4] Introduce FRMR pools
Date: Mon, 16 Mar 2026 23:37:51 +0200	[thread overview]
Message-ID: <237390f5-0164-47d1-bf07-8dfd6da50fdc@nvidia.com> (raw)
In-Reply-To: <2a638f50-6d22-4abe-9f20-74367a0f3295@gmail.com>


On 3/7/2026 3:45 AM, David Ahern wrote:
> External email: Use caution opening links or attachments
>
>
> On 3/2/26 8:51 AM, Chiara Meiohas wrote:
>>  From Michael:
>>
>> This series adds support for managing Fast Registration Memory Region
>> (FRMR) pools in rdma tool, enabling users to monitor and configure FRMR
>> pool behavior.
>>
> Claude has some quibbles with the patches:
>
>
> 1. Type mismatch: RDMA_NLDEV_ATTR_RES_FRMR_POOL_AGING_PERIOD
>
>
> 2. Type mismatch: RDMA_NLDEV_ATTR_RES_FRMR_POOL_PINNED
>
Ack, wrong types in the header comments.
> 3. Declared but unimplemented: res_frmr_pools_idx_parse_cb

Ack, this could use a stub definition. Similar to res_no_args.

Thanks


      reply	other threads:[~2026-03-16 21:37 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-03-02 15:51 [PATCH iproute2-next 0/4] Introduce FRMR pools Chiara Meiohas
2026-03-02 15:51 ` [PATCH iproute2-next 1/4] rdma: Update headers Chiara Meiohas
2026-03-02 15:51 ` [PATCH iproute2-next 2/4] rdma: Add resource FRMR pools show command Chiara Meiohas
2026-03-07  1:45   ` David Ahern
2026-03-16 17:17     ` Michael Gur
2026-03-02 15:51 ` [PATCH iproute2-next 3/4] rdma: Add FRMR pools set aging command Chiara Meiohas
2026-03-02 15:52 ` [PATCH iproute2-next 4/4] rdma: Add FRMR pools set pinned command Chiara Meiohas
2026-03-07  0:16 ` [PATCH iproute2-next 0/4] Introduce FRMR pools David Ahern
2026-03-09 15:48   ` Chiara Meiohas
2026-03-07  1:45 ` David Ahern
2026-03-16 21:37   ` Michael Gur [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=237390f5-0164-47d1-bf07-8dfd6da50fdc@nvidia.com \
    --to=michaelgur@nvidia.com \
    --cc=cmeiohas@nvidia.com \
    --cc=dsahern@gmail.com \
    --cc=jgg@nvidia.com \
    --cc=leon@kernel.org \
    --cc=linux-rdma@vger.kernel.org \
    --cc=netdev@vger.kernel.org \
    --cc=stephen@networkplumber.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox