From: Jay Vosburgh <fubar@us.ibm.com>
To: Herbert Xu <herbert@gondor.apana.org.au>
Cc: Andy Gospodarek <andy@greyhouse.net>,
Krzysztof Oledzki <olel@ans.pl>,
netdev@vger.kernel.org, Jeff Garzik <jgarzik@pobox.com>,
David Miller <davem@davemloft.net>
Subject: Re: [PATCH 0/3] bonding: 3 fixes for 2.6.24
Date: Thu, 10 Jan 2008 17:06:53 -0800 [thread overview]
Message-ID: <23761.1200013613@death> (raw)
In-Reply-To: <20080110210507.GA17344@gondor.apana.org.au>
Herbert Xu <herbert@gondor.apana.org.au> wrote:
>On Thu, Jan 10, 2008 at 04:03:53PM -0500, Andy Gospodarek wrote:
>>
>> > >Sure, but where do you call that function while holding the bond lock?
>> >
>> > If I recall correctly, the problem was that tg3, et al, did
>> > things that might sleep, and bonding was calling from a timer context,
>> > which couldn't sleep. It wasn't about the lock.
>>
>> Exactly, I was just about to post the same.
>
>In other words, changing read_lock on bond->lock to read_lock_bh doesn't
>affect this one bit.
For the case of the bond_set_multicast_list function, changing
the existing write_lock to a read_lock_bh doesn't affect any calls to
dev_set_mac_address (since it isn't called from there) and, apparently,
also resolves the lockdep warning. I'm still trying to get lockdep to
generate the warning for me locally; I'm not sure which magic thing I'm
missing.
-J
---
-Jay Vosburgh, IBM Linux Technology Center, fubar@us.ibm.com
next prev parent reply other threads:[~2008-01-11 1:07 UTC|newest]
Thread overview: 30+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-01-08 1:56 [PATCH 0/3] bonding: 3 fixes for 2.6.24 Jay Vosburgh
2008-01-08 1:56 ` [PATCH 1/3] bonding: fix locking in sysfs primary/active selection Jay Vosburgh
2008-01-08 1:56 ` [PATCH 2/3] bonding: fix ASSERT_RTNL that produces spurious warnings Jay Vosburgh
2008-01-08 1:57 ` [PATCH 3/3] bonding: fix locking during alb failover and slave removal Jay Vosburgh
2008-01-08 18:50 ` [PATCH 0/3] bonding: 3 fixes for 2.6.24 Krzysztof Oledzki
2008-01-08 19:17 ` Andy Gospodarek
2008-01-08 20:28 ` Jay Vosburgh
2008-01-09 6:08 ` Herbert Xu
2008-01-08 19:30 ` Jay Vosburgh
2008-01-09 6:35 ` Krzysztof Oledzki
2008-01-09 7:58 ` Jay Vosburgh
2008-01-09 9:36 ` Krzysztof Oledzki
2008-01-09 15:27 ` Andy Gospodarek
2008-01-09 17:54 ` Jay Vosburgh
2008-01-09 20:17 ` Andy Gospodarek
2008-01-09 22:05 ` Herbert Xu
2008-01-09 23:19 ` Jay Vosburgh
2008-01-10 0:58 ` Herbert Xu
2008-01-10 14:51 ` Andy Gospodarek
2008-01-10 20:36 ` Herbert Xu
2008-01-10 20:50 ` Jay Vosburgh
2008-01-10 21:03 ` Andy Gospodarek
2008-01-10 21:05 ` Herbert Xu
2008-01-11 1:06 ` Jay Vosburgh [this message]
2008-01-11 4:55 ` Herbert Xu
2008-01-10 20:45 ` Jay Vosburgh
2008-01-12 10:53 ` Krzysztof Oledzki
2008-01-12 17:56 ` Jay Vosburgh
2008-01-13 0:19 ` Herbert Xu
2008-01-14 22:15 ` Krzysztof Oledzki
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=23761.1200013613@death \
--to=fubar@us.ibm.com \
--cc=andy@greyhouse.net \
--cc=davem@davemloft.net \
--cc=herbert@gondor.apana.org.au \
--cc=jgarzik@pobox.com \
--cc=netdev@vger.kernel.org \
--cc=olel@ans.pl \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).