From mboxrd@z Thu Jan 1 00:00:00 1970 Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.remote-ip=205.220.180.131 ARC-Seal: i=1; d=subspace.kernel.org; s=arc20261015; a=rsa-sha256; cv=none; t=1793019367; b=fT4DUoDv0cma76LAiPZ7dV2l4JP8qhKD0+R7s4vbZylkhMie0/6aCACn5UoDNM3OjZuL hGjvEITbhU/p1CgTQEJYgPHYgrXBKZGp4slUzqa2eqHZ/doYf1keo0MUzGJmCWp6Y0HdN p3S4kDEiFzXsOcbwLBAbDDN3tMFTFyAuhMzlmqVuC9Y5NUdSPtlgrkl6KY6B4PA1Yp9PQ ExFlJT5gJ4Y+CuoP5GGjafo06DQqeZ3AwldGYwSRUYXwGiOfECPMHLR4Gj430uASukkpk KS5ehRJNyLjlYwjdq/8h8qeX6IFamRsnDWDI0+429H2OHkjwxEK8hGsjN0eTqf7sK6Q== ARC-Message-Signature: i=1; d=subspace.kernel.org; s=arc20261015; a=rsa-sha256; c=relaxed/relaxed; t=1793019367; h=DMARC-Filter:Received:DKIM-Signature:Received:Received: DKIM-Signature:X-Google-DKIM-Signature:X-Forwarded-Encrypted: X-Gm-Message-State:X-Gm-Gg:X-Received:X-Received:Received:Message-ID: Date:MIME-Version:User-Agent:Subject:To:Cc:References: Content-Language:From:In-Reply-To:Content-Type: Content-Transfer-Encoding:X-Proofpoint-Spam-Details-Enc: X-Proofpoint-GUID:X-Proofpoint-Spam-Info:X-Proofpoint-ORIG-GUID: X-Authority-Analysis:X-Proofpoint-Virus-Version: X-Proofpoint-Spam-Details; bh=hNO7pC1kz63YSDMIEHWfeIC3Vw71SJAFnz98jQKeibQ=; b=ZDJFCYf5aB8TI7+KyXamljowzWKVyM018ohz1/QDIQ9wTbRv9BdMtM8YvuaA03tYOZZ5 fHLcRoyG7oPCg2gOebI8GgbqrYoNsrpQSvf97Bs7VQzWvP1VLtG2RzZsh+ccciPnMzc5B /3q+0R9xDdFk7rwuXf9HLiqcS56pNrr+tzoUGt+fDgS38T4WMviZcS9imqS8BKY9BjIyH tLgv84yWqRSA4t7CH4/ucpqWu6yaxCVztdgFFIgY68ODD3DLsVgbaC+6bZhK/PD+ec2ve Hphxf9LLNsJArbbWTyU5c/SxgOOhvqxKD/5fv7QaluPGE3xbIsw6FPkiKYVW1Bt/ENA== ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=temperror header.d=qualcomm.com header.i=@qualcomm.com header.a=rsa-sha256 header.s=qcppdkim1 header.b=S7dphAUN; dkim=pass header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.a=rsa-sha256 header.s=google header.b="e/Jhbmpu"; arc=none smtp.remote-ip=205.220.180.131 Received: from mx0b-0031df01.pphosted.com (mx0b-0031df01.pphosted.com [205.220.180.131]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (prime256v1) server-digest SHA256) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 39075606A31B for ; Mon, 26 Oct 2026 12:56:02 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.2 smtp.subspace.kernel.org 39075606A31B Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=temperror header.d=qualcomm.com header.i=@qualcomm.com header.a=rsa-sha256 header.s=qcppdkim1 header.b=S7dphAUN; dkim=pass (2048-bit key, unprotected) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.a=rsa-sha256 header.s=google header.b=e/Jhbmpu Received: from pps.filterd (m0279868.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 69QAsukp2732724 for ; Mon, 26 Oct 2026 12:56:01 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=qcppdkim1; bh= hNO7pC1kz63YSDMIEHWfeIC3Vw71SJAFnz98jQKeibQ=; b=S7dphAUNgcPfraAP C0b5lgfQz5b7erEFF2J9VlbAHAgRnqdbDzx019x+jZOMGjhmQBorH+m9nLX6oHMo /Kv7fcGKb9aEUzlfbRRcBYUDRlqPd4k06AQ3RpUhtIowFj9V6sodpWPF9cIvz52E IVNi/QSu7G347o48RP6pR6helreuSq5PXXpjmwM6+GTeVnlgzdCbD8duBvEJONjf EHFCF42+7tvzC2a6nzpCc4yR4DsIuE/5qCeqTD7W0/oqws5SfqiOOiVk9+M9MTD6 6db5HZEEarz1QcTAKpM3KDN2uiM9dxFyAPo4N71HLjQKAOUh/HsfD1fcc3khbUHw ruTkgg== Received: from mail-yw1-f200.google.com (mail-yw1-f200.google.com [209.85.128.200]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4hj4cp8qvj-1 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT) for ; Mon, 26 Oct 2026 12:56:00 +0000 (GMT) Received: by mail-yw1-f200.google.com with SMTP id 00721157ae682-8b0bf2140b7so41539797b3.3 for ; Mon, 26 Oct 2026 05:56:00 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oss.qualcomm.com; s=google; t=1793019360; x=1793624160; darn=vger.kernel.org; h=content-transfer-encoding:content-type:in-reply-to:from :content-language:references:cc:to:subject:user-agent:mime-version :date:message-id:from:to:cc:subject:date:message-id:reply-to :content-type; bh=hNO7pC1kz63YSDMIEHWfeIC3Vw71SJAFnz98jQKeibQ=; b=e/JhbmpuXxH2JuxmFGW/FkGk9GGKXXagIvEIpjZ46yTh3+5mF8nQ4lH+pa4vRpNppU 7BsKYGiRo46TXmoi8sazDu3beuCuQQLHaBUQwTja4NU9E7u9TL6LFVCB3vRLJ/DlR3Wf 5eI3B0TMAAVmeaOx9jbi/VD8V3VHe0kYumjDtxQ6dQy+V1TGMLAb3KPqW+ma/J8Mp33K USRJxPE9mkuXYzUfex53pv5Piu2qqeWiNTQVi0rObizkR/QSyZswL6DS5nSg4j/l6DwF SCQcw2xR4UqKONzZaTJBnFme+KGtzSPNXTktWJoKdKfBtob3Nm4bkT8nOmnk3/2Fgd3k aSbQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20260707; t=1793019360; x=1793624160; h=content-transfer-encoding:content-type:in-reply-to:from :content-language:references:cc:to:subject:user-agent:mime-version :date:message-id:x-gm-gg:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to:content-type; bh=hNO7pC1kz63YSDMIEHWfeIC3Vw71SJAFnz98jQKeibQ=; b=NLNxcdKGMsoKZgZQvheVRNXV1LY9Q4+YcLchGJUfnGqL/Y5LEcQ7eHIx/X1Zj/74+q 2sa97kwZepQjEE0qjzQ230Suf08uZLbQhg8hPZapfeN2uENz/VvEEKdqLAatqEq66ex8 xCHjfATnOO8plvEiefUmUsDlqSFh9Tm24+emjkuhzV9oyGgDJWxewMouhQvrhp/QE4sQ 4AuPlt8MEy++sUSah9vK1YApBLeIwDZ6cMM0LBRdaVJeHUO1vqeFdNQCgCvBZRV5vfqz pnl/D+MBL0xQRQlIA25FDUZJoCv1k5eQ408VTFSsqtgqVfB74YA4dz9+xf4J/P3UMI7K Ibxg== X-Forwarded-Encrypted: i=1; AKwUvBylg+ZIxaI8ilukvZyzELfTJO6fvPG2r6q7mGhmNJMOtDjg1TBO3mBa53OsiqmBOEfA0My6yjo=@vger.kernel.org X-Gm-Message-State: AFq9FYLu+FwwT6ket0w2w0krtK44lTpMBtxsMyEAXyMG4mmFajDV5Nsk lz74eaQyAzf6GoV4VoZ+5Vi8PIfYwp3VcKd3HQfBmSExlPRn2+pWLwfCIv0PfEKh958a0pG386x euWBWeLzLZ4zwCP8jhtkn5Mm8Wq9Cf5DwF9uhiRLG22BoY2c2bf7Be+nfWu4= X-Gm-Gg: AYBFou256FW5I13VUNhOiUiWu0lTjgHEaxRglWvV8YCXTlapOJEPcNuF2Uq3W13js/b JM2ym5A9H26B32eTM+uR5VHOMh9qI/jemCODYqlX3GRKBXL4zQ7fqT2z4U17wuWAojFLu9PKl2w HGf/q36zKojiu9vo3PBuSxJTiNeJ17TJ+f942ESWh4OQ+98IK+i2u/Yphiv3GProuvG4HnX6QL9 4n2GEnV6zd2+IsqsG7HVPbzdR8e3jREPaWV8eVu7/6ksZ2DED+hKymYrG/fK2UPj4X6GslT3Ahz lKDp5LdB8oKa6Bm0q7M12JhIrEaQeR88o5r/h+MW7YyY04aHkcpHO7qyeQojZ/KTbH0Tyro2JuG y7ona614XHA/0dLBZSGwXs3pdjpQ= X-Received: by 2002:a05:690c:d8a:b0:8b0:ad62:198f with SMTP id 00721157ae682-8b166bea5f5mr53579887b3.20.1793019360430; Mon, 26 Oct 2026 05:56:00 -0700 (PDT) X-Received: by 2002:a05:690c:d8a:b0:8b0:ad62:198f with SMTP id 00721157ae682-8b166bea5f5mr53579767b3.20.1793019359974; Mon, 26 Oct 2026 05:55:59 -0700 (PDT) Received: from [10.217.216.70] ([202.46.22.19]) by smtp.gmail.com with ESMTPSA id 00721157ae682-8b166e28704sm31507357b3.23.2026.10.26.05.55.53 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 26 Oct 2026 05:55:59 -0700 (PDT) Message-ID: <237b2f74-4a9b-4df2-a0fe-a7b783ed5267@oss.qualcomm.com> Date: Mon, 26 Oct 2026 18:25:37 +0530 X-Mailing-List: netdev@vger.kernel.org List-Id: List-Post: List-Help: List-Subscribe: List-Unsubscribe: List-Owner: Precedence: list MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH 1/6] dt-bindings: ptp: Document the TSCSS on Qualcomm Lemans and Monaco SoCs To: Krzysztof Kozlowski , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Richard Cochran , Andrew Lunn , "David S. Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni , Bjorn Andersson , Konrad Dybcio Cc: Ajit Pandey , Taniya Das , Jagadeesh Kona , linux-arm-msm@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, netdev@vger.kernel.org References: <20260727-tscss-v1-0-beed14e72510@oss.qualcomm.com> <20260727-tscss-v1-1-beed14e72510@oss.qualcomm.com> <02792987-7ad8-4a6b-81ad-559c63174bb0@kernel.org> <640acacb-1704-4ee6-aa34-d6be3b30b44b@oss.qualcomm.com> <7f6839fb-59b0-4f6d-a3f8-7579f6d40857@oss.qualcomm.com> Content-Language: en-US From: Imran Shaik In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYxMDI2MDA1MSBTYWx0ZWRfXwsvLjrf4+79g hAmIP/U9sQGxZ7BVfNmPOE73l/1wkhx7Rsv3V0BbKBZGWsACIhorzFqXp1tPTZbGJSbUnSdPHNS 1/qxq+tQN4NzbIOSMWh69p6IwuNQJebdvE9lznHGOD1wtT194JDl2UygcoNrVaq/AIQeIVh8v2G RB7B393AQnLO4/JfktbLXFhMqll7y2wtbL6OcXzKXUy7kIPWv7eYsL9pKDOx3H13kD1lmeSqwUO GCC+Ia1JgsZTK3mz79II6otNSOH9W46WYWhb9j9HiPa1BHZ5N16EPeLuWW0gy/17iJ8VTBb17LL usB+vQhe6hRlKlXLSI62dKBsnIscLOil4xQ3BLSNeIstSMoWwVIEKYleymHGZj3XmXxya+eP/mJ 20QweQ0PgJvpH1HE1xWJOo9o5Uu3eJxYOrnJwwspQ2XjDR+effnu3LYnsBslAVT2eMDv62UNkfc Cuc/NhFxtkH49EQZ44Q== X-Proofpoint-GUID: ub2oAm69PKcXwT2I5f4AB97so-Cm1vWK X-Proofpoint-Spam-Info: AW1haW4tMjYxMDI2MDA1MSBTYWx0ZWRfX3FXGbJrjWoen X3yYMn02lnl1CVKwenMbQGuWcacWKiX7lKSQ8OdoL6DfHOKsairq9udNtTND+pmf7gxdnxw/Ebc XwWLj7/IkgOe8RYVyKHFWErvrSE+0Y8= X-Proofpoint-ORIG-GUID: ub2oAm69PKcXwT2I5f4AB97so-Cm1vWK X-Authority-Analysis: v=2.4 cv=TboDJhQh c=1 sm=1 tr=0 ts=6adf4de0 cx=c_pps a=NMvoxGxYzVyQPkMeJjVPKg==:117 a=fChuTYTh2wq5r3m49p7fHw==:17 a=IkcTkHD0fZMA:10 a=660iZSQnnn4A:10 a=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22 a=u7WPNUs3qKkmUXheDGA7:22 a=ZpdpYltYx_vBUK5n70dp:22 a=ebbTEIlB-icwTnaok3IA:9 a=QEXdDO2ut3YA:10 a=kLokIza1BN8a-hAJ3hfR:22 X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1176,Hydra:6.1.138,FMLib:17.12.100.49 definitions=2026-10-26_02,2026-10-21_02,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 phishscore=0 priorityscore=1501 impostorscore=0 lowpriorityscore=0 spamscore=0 clxscore=1011 adultscore=0 malwarescore=0 suspectscore=0 bulkscore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2610190000 definitions=main-2610260051 On 23-10-2026 03:09 pm, Krzysztof Kozlowski wrote: > On 13/10/2026 13:49, Imran Shaik wrote: >>>>>> + >>>>>> +patternProperties: >>>>>> + "^etu-slice@[0-9a-f]+$": >>>>>> + type: object >>>>>> + description: ETU slice configuration >>>>>> + properties: >>>>>> + reg: >>>>>> + maxItems: 1 >>>>>> + >>>>>> + pinctrl-0: true >>>>>> + >>>>>> + pinctrl-names: >>>>>> + items: >>>>>> + - const: default >>>>> >>>>> Heh? Which code do you copy? >>>>> >>>> >>>> Each ETU slice has its own external event pin config, so kept pinctrl-0 >>>> and pinctrl-names on the slice subnode. Please suggest if you prefer >>>> otherwise. > > Just drop both pinctrl properties, because you should not need them. You > define them only if they are different than default. > Thanks for the feedback, will drop this in next series. >>> >>> No, from where did you get this code? Why are you sending bindings which >>> are different then all other bindings? >>> >> >> I was referring to the example in [1] when adding the pinctrl properties >> under the etu-slice sub node. >> >> [1] - >> Documentation/devicetree/bindings/media/samsung,exynos4212-fimc-is.yaml > > That's like 13 years old device binding, so unfortunately likely > antipattern. > > > >> >> On checking further, I found that our etu-slice sub node deviates from >> that example, since we don't have a compatible string for the sub node. >> >> Please let me know if we should move the pinctrl properties under the >> tscss node with per-slice names, or instead keep them under the >> etu-slice sub node and add a compatible there. > > etu-slice does not feel like device at all unfortunately. I see only > address space, so one resource, which might be enough but lack of > description for the subnode is not helping. I have doubts that separate > subnodes should be there in the first place, but if they stay, describe > the child node fully - what sort of device it is. Just because there is > independent timestamping counter does not make it separate device, just > like independent interrupt in GIC is not itself an independent device. > The ETU is an independent hardware block within TSCSS that captures/ snapshots the TSC timestamp in response to an external hardware event trigger, for each slice individually. Hence the subnodes approach was followed and will capture these details in the description as well. If we drop the subnodes and add everything into the parent TSCSS node instead, then all the arrays here must stay index aligned as per slice mapping. Example DTS node looks like this (QDU1000, 3 slices): ptp@1da0000 { compatible = "qcom,qdu1000-tscss"; reg = <0x0 0x01da0000 0x0 0x2000>, <0x0 0x01db0000 0x0 0x10000>; reg-names = "tsc", "etu"; ... interrupts = , , ; interrupt-names = "slice1", "slice5", "slice6"; pinctrl-0 = <&tod_pps>; pinctrl-1 = <&gps_pps>; pinctrl-2 = <&hardsync_pps>; pinctrl-names = "slice1", "slice5", "slice6"; qcom,etu-slice = <1 5 6>; qcom,etu-event-sel = <1 3 2>; }; Please help suggest which approach to follow here. Accordingly, I will update the bindings in next series. Thanks, Imran