From: Florian Fainelli <f.fainelli@gmail.com>
To: Vladimir Oltean <olteanv@gmail.com>, davem@davemloft.net
Cc: netdev@vger.kernel.org, andrew@lunn.ch, vivien.didelot@gmail.com,
antoine.tenart@bootlin.com, alexandre.belloni@bootlin.com,
UNGLinuxDriver@microchip.com, alexandru.marginean@nxp.com,
claudiu.manoil@nxp.com, madalin.bucur@oss.nxp.com,
radu-andrei.bulie@nxp.com, fido_max@inbox.ru, broonie@kernel.org
Subject: Re: [PATCH v2 net-next 03/13] net: mscc: ocelot: convert port registers to regmap
Date: Sat, 30 May 2020 13:45:45 -0700 [thread overview]
Message-ID: <237eb0b4-993d-89d5-b389-7f95c56da938@gmail.com> (raw)
In-Reply-To: <20200530115142.707415-4-olteanv@gmail.com>
On 5/30/2020 4:51 AM, Vladimir Oltean wrote:
> From: Vladimir Oltean <vladimir.oltean@nxp.com>
>
> At the moment, there are some minimal register differences between
> VSC7514 Ocelot and VSC9959 Felix. To be precise, the PCS1G registers are
> missing from Felix because it was integrated with an NXP PCS.
>
> But with VSC9953 Seville (not yet introduced), the register differences
> are more pronounced. The MAC registers are located at different offsets
> within the DEV_GMII target. So we need to refactor the driver to keep a
> regmap even for per-port registers. The callers of the ocelot_port_readl
> and ocelot_port_writel were kept unchanged, only the implementation is
> now more generic.
>
> Signed-off-by: Vladimir Oltean <vladimir.oltean@nxp.com>
Reviewed-by: Florian Fainelli <f.fainelli@gmail.com>
--
Florian
next prev parent reply other threads:[~2020-05-30 20:45 UTC|newest]
Thread overview: 31+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-05-30 11:51 [PATCH v2 net-next 00/13] New DSA driver for VSC9953 Seville switch Vladimir Oltean
2020-05-30 11:51 ` [PATCH v2 net-next 01/13] regmap: add helper for per-port regfield initialization Vladimir Oltean
2020-05-30 11:51 ` [PATCH v2 net-next 02/13] net: dsa: felix: set proper link speed in felix_phylink_mac_config Vladimir Oltean
2020-05-30 20:43 ` Florian Fainelli
2020-05-30 11:51 ` [PATCH v2 net-next 03/13] net: mscc: ocelot: convert port registers to regmap Vladimir Oltean
2020-05-30 20:45 ` Florian Fainelli [this message]
2020-05-30 11:51 ` [PATCH v2 net-next 04/13] soc/mscc: ocelot: add MII registers description Vladimir Oltean
2020-05-30 20:46 ` Florian Fainelli
2020-05-30 11:51 ` [PATCH v2 net-next 05/13] net: mscc: ocelot: convert QSYS_SWITCH_PORT_MODE and SYS_PORT_MODE to regfields Vladimir Oltean
2020-05-30 21:18 ` Florian Fainelli
2020-05-30 21:25 ` Vladimir Oltean
2020-05-30 21:34 ` Florian Fainelli
2020-05-30 11:51 ` [PATCH v2 net-next 06/13] net: dsa: felix: create a template for the DSA tags on xmit Vladimir Oltean
2020-05-30 21:31 ` Florian Fainelli
2020-05-30 21:39 ` Vladimir Oltean
2020-05-30 11:51 ` [PATCH v2 net-next 07/13] net: mscc: ocelot: split writes to pause frame enable bit and to thresholds Vladimir Oltean
2020-05-30 20:59 ` Florian Fainelli
2020-05-30 11:51 ` [PATCH v2 net-next 08/13] net: mscc: ocelot: disable flow control on NPI interface Vladimir Oltean
2020-05-30 20:58 ` Florian Fainelli
2020-05-30 11:51 ` [PATCH v2 net-next 09/13] net: mscc: ocelot: convert SYS_PAUSE_CFG register access to regfield Vladimir Oltean
2020-05-30 20:57 ` Florian Fainelli
2020-05-30 11:51 ` [PATCH v2 net-next 10/13] net: mscc: ocelot: extend watermark encoding function Vladimir Oltean
2020-05-30 20:58 ` Florian Fainelli
2020-05-30 11:51 ` [PATCH v2 net-next 11/13] net: dsa: felix: support half-duplex link modes Vladimir Oltean
2020-05-30 20:50 ` Florian Fainelli
2020-05-30 11:51 ` [PATCH v2 net-next 12/13] net: dsa: felix: move probing to felix_vsc9959.c Vladimir Oltean
2020-05-30 21:34 ` Florian Fainelli
2020-05-30 11:51 ` [PATCH v2 net-next 13/13] net: dsa: felix: introduce support for Seville VSC9953 switch Vladimir Oltean
2020-05-30 20:55 ` Florian Fainelli
2020-05-31 1:03 ` [PATCH v2 net-next 00/13] New DSA driver for VSC9953 Seville switch David Miller
2020-05-31 1:08 ` David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=237eb0b4-993d-89d5-b389-7f95c56da938@gmail.com \
--to=f.fainelli@gmail.com \
--cc=UNGLinuxDriver@microchip.com \
--cc=alexandre.belloni@bootlin.com \
--cc=alexandru.marginean@nxp.com \
--cc=andrew@lunn.ch \
--cc=antoine.tenart@bootlin.com \
--cc=broonie@kernel.org \
--cc=claudiu.manoil@nxp.com \
--cc=davem@davemloft.net \
--cc=fido_max@inbox.ru \
--cc=madalin.bucur@oss.nxp.com \
--cc=netdev@vger.kernel.org \
--cc=olteanv@gmail.com \
--cc=radu-andrei.bulie@nxp.com \
--cc=vivien.didelot@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).