From mboxrd@z Thu Jan  1 00:00:00 1970
From: Heiner Kallweit <hkallweit1@gmail.com>
Subject: Re: [PATCH net-next 01/10] r8169: add basic phylib support
Date: Mon, 2 Jul 2018 23:15:57 +0200
Message-ID: <238e0c62-7e95-df62-3837-5e8d1b7248f0@gmail.com>
References: <096a5326-963c-9bef-6218-29fcde004111@gmail.com>
 <60049e7e-b86d-1968-cdfd-7e0f91a25b88@gmail.com>
 <20180702210239.GA12564@lunn.ch>
Mime-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 7bit
Cc: David Miller <davem@davemloft.net>,
        Florian Fainelli <f.fainelli@gmail.com>,
        Realtek linux nic maintainers <nic_swsd@realtek.com>,
        "netdev@vger.kernel.org" <netdev@vger.kernel.org>
To: Andrew Lunn <andrew@lunn.ch>
Return-path: <netdev-owner@vger.kernel.org>
Received: from mail-wr0-f195.google.com ([209.85.128.195]:33525 "EHLO
        mail-wr0-f195.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
        with ESMTP id S932134AbeGBVYk (ORCPT
        <rfc822;netdev@vger.kernel.org>); Mon, 2 Jul 2018 17:24:40 -0400
Received: by mail-wr0-f195.google.com with SMTP id k7-v6so13367538wrq.0
        for <netdev@vger.kernel.org>; Mon, 02 Jul 2018 14:24:40 -0700 (PDT)
In-Reply-To: <20180702210239.GA12564@lunn.ch>
Content-Language: en-US
Sender: netdev-owner@vger.kernel.org
List-ID: <netdev.vger.kernel.org>

On 02.07.2018 23:02, Andrew Lunn wrote:
>> +static int r8169_mdio_read_reg(struct mii_bus *mii_bus, int phyaddr, int phyreg)
>> +{
>> +	struct rtl8169_private *tp = mii_bus->priv;
>> +
>> +	return rtl_readphy(tp, phyreg);
> 
> So there is no support for phyaddr?
> 
Right, the chip can access only the one internal PHY, therefore it
doesn't support phyaddr.

> It would be better to trap the phyaddr which are not supported and
> return 0xffff.
> 
OK

>        Andrew
>