From: Jay Vosburgh <jay.vosburgh@canonical.com>
To: Hangbin Liu <liuhangbin@gmail.com>
Cc: netdev@vger.kernel.org, "David S . Miller" <davem@davemloft.net>,
Jakub Kicinski <kuba@kernel.org>, Paolo Abeni <pabeni@redhat.com>,
Eric Dumazet <edumazet@google.com>, Liang Li <liali@redhat.com>
Subject: Re: [PATCH net] selftests: bonding: do not test arp/ns target with mode balance-alb/tlb
Date: Tue, 23 Jan 2024 10:37:14 -0800 [thread overview]
Message-ID: <2394.1706035034@famine> (raw)
In-Reply-To: <20240123075917.1576360-1-liuhangbin@gmail.com>
Hangbin Liu <liuhangbin@gmail.com> wrote:
>The prio_arp/ns tests hard code the mode to active-backup. At the same
>time, The balance-alb/tlb modes do not support arp/ns target. So remove
>the prio_arp/ns tests from the loop and only test active-backup mode.
>
>Fixes: 481b56e0391e ("selftests: bonding: re-format bond option tests")
>Reported-by: Jay Vosburgh <jay.vosburgh@canonical.com>
>Closes: https://lore.kernel.org/netdev/17415.1705965957@famine/
>Signed-off-by: Hangbin Liu <liuhangbin@gmail.com>
Acked-by: Jay Vosburgh <jay.vosburgh@canonical.com>
>---
> .../testing/selftests/drivers/net/bonding/bond_options.sh | 8 ++++----
> 1 file changed, 4 insertions(+), 4 deletions(-)
>
>diff --git a/tools/testing/selftests/drivers/net/bonding/bond_options.sh b/tools/testing/selftests/drivers/net/bonding/bond_options.sh
>index c54d1697f439..d508486cc0bd 100755
>--- a/tools/testing/selftests/drivers/net/bonding/bond_options.sh
>+++ b/tools/testing/selftests/drivers/net/bonding/bond_options.sh
>@@ -162,7 +162,7 @@ prio_arp()
> local mode=$1
>
> for primary_reselect in 0 1 2; do
>- prio_test "mode active-backup arp_interval 100 arp_ip_target ${g_ip4} primary eth1 primary_reselect $primary_reselect"
>+ prio_test "mode $mode arp_interval 100 arp_ip_target ${g_ip4} primary eth1 primary_reselect $primary_reselect"
> log_test "prio" "$mode arp_ip_target primary_reselect $primary_reselect"
> done
> }
>@@ -178,7 +178,7 @@ prio_ns()
> fi
>
> for primary_reselect in 0 1 2; do
>- prio_test "mode active-backup arp_interval 100 ns_ip6_target ${g_ip6} primary eth1 primary_reselect $primary_reselect"
>+ prio_test "mode $mode arp_interval 100 ns_ip6_target ${g_ip6} primary eth1 primary_reselect $primary_reselect"
> log_test "prio" "$mode ns_ip6_target primary_reselect $primary_reselect"
> done
> }
>@@ -194,9 +194,9 @@ prio()
>
> for mode in $modes; do
> prio_miimon $mode
>- prio_arp $mode
>- prio_ns $mode
> done
>+ prio_arp "active-backup"
>+ prio_ns "active-backup"
> }
>
> arp_validate_test()
>--
>2.43.0
>
next prev parent reply other threads:[~2024-01-23 18:37 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-01-23 7:59 [PATCH net] selftests: bonding: do not test arp/ns target with mode balance-alb/tlb Hangbin Liu
2024-01-23 18:37 ` Jay Vosburgh [this message]
2024-01-25 9:10 ` patchwork-bot+netdevbpf
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=2394.1706035034@famine \
--to=jay.vosburgh@canonical.com \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=kuba@kernel.org \
--cc=liali@redhat.com \
--cc=liuhangbin@gmail.com \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox