From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.9 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 11007C10F11 for ; Wed, 10 Apr 2019 19:33:14 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id D3B1620830 for ; Wed, 10 Apr 2019 19:33:13 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="bhiL0/Ho" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726085AbfDJTdM (ORCPT ); Wed, 10 Apr 2019 15:33:12 -0400 Received: from mail-pl1-f194.google.com ([209.85.214.194]:44645 "EHLO mail-pl1-f194.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725982AbfDJTdM (ORCPT ); Wed, 10 Apr 2019 15:33:12 -0400 Received: by mail-pl1-f194.google.com with SMTP id g12so1996712pll.11 for ; Wed, 10 Apr 2019 12:33:11 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=subject:to:cc:references:from:openpgp:message-id:date:user-agent :mime-version:in-reply-to:content-language:content-transfer-encoding; bh=GT2gRA4MzYxWOrqzojBIst/vIQ8swDOOdNYKpAcpvHw=; b=bhiL0/Ho0mh+kC2gTN82K5AzZoH7cbyUTywjXC8hifCx3f9q88NtiSyoXqK/LXEVen BXFrXkAGF6qXm5GR3OI3Xq97LsscmB3qm2IHqJEfTTwqf6tydHYDDctwuk232oiEnjeL HabYcI7NtqTgmthadmOxw8NntFBjKIG3VBXnwiyJoUBX7hfCuJEnf2Ot4bnSzoQN1UpU ZTuQvM7JgZwr2MGfcNrfLlMxp+/tKV6pVw8Xt2IFf60ZjHda4o63KwBAt6FuF41O5MqS ciLO/B5KBImxA8f/0QofiY0RmtF2lAdG6jgTv/+t+yBsPp602h8E7qLopZZFIFQK7iIy atuQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:cc:references:from:openpgp:message-id :date:user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=GT2gRA4MzYxWOrqzojBIst/vIQ8swDOOdNYKpAcpvHw=; b=hx5wJlGTM14PKujX1u6qy0lwagb0K+7ix9hzM5oHnB/KlXV3LpLv8KLJGiJnHRAEe+ 2paSPEEMfDJGN+Fe/yZrTboXXPPqXTmeCeubKU4DUD8eIsgZZy24zzh0FJJkXbVi7/iI 9WeKz3m2de1LKXKEA0N1gjvgYex1Kdx5YdPFqSwAh3Y+pG9Aup0zAra40oE9IAZs9xHQ DLeH5uWaNnM39KA7V0Qz2VWKuOlzji7tjv48xhf7XXa4/pVtd+e6zB38Mhh9sT3A7w8g z+lBXdo6ydKdNFm1mkzraSjpyd8sEzJTjVcI8kASwFazYIVvPlrsxkSFxoKxoqUypq8s yBYQ== X-Gm-Message-State: APjAAAWIF3jIyHH7P59C3oI3GCr15xPTmQFLsa90xLkF5M08hGvJaoPu aXX9M+2ULXxJRt6LwYJFgZ0= X-Google-Smtp-Source: APXvYqw3WkkVESgWnkiy0uF3IAjZQwvZFqDetD3nzCz/3Wv6nDTUpRPRy027cfQw1e56cXXV0knOHg== X-Received: by 2002:a17:902:2ec1:: with SMTP id r59mr46093811plb.171.1554924791294; Wed, 10 Apr 2019 12:33:11 -0700 (PDT) Received: from [10.69.78.41] ([192.19.223.250]) by smtp.gmail.com with ESMTPSA id l2sm38646277pgl.2.2019.04.10.12.33.04 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Wed, 10 Apr 2019 12:33:10 -0700 (PDT) Subject: Re: [PATCH net-next] net: phy: switch drivers to use dynamic feature detection To: Heiner Kallweit , David Miller , f.fainelli@gmail.com Cc: andrew@lunn.ch, rjui@broadcom.com, sbranden@broadcom.com, richardcochran@gmail.com, khilman@baylibre.com, heiko@sntech.de, bcm-kernel-feedback-list@broadcom.com, netdev@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-amlogic@lists.infradead.org, linux-rockchip@lists.infradead.org References: <0cc96fab-e102-c0d1-ade0-90e3e06dc9f1@gmail.com> <20190409.135944.1516944884952068835.davem@davemloft.net> From: Florian Fainelli Openpgp: preference=signencrypt Message-ID: <239c0f2c-3be3-bcd4-9b76-7cbde75bc0ef@gmail.com> Date: Wed, 10 Apr 2019 12:33:01 -0700 User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:60.0) Gecko/20100101 Thunderbird/60.6.1 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org On 4/10/2019 12:31 PM, Heiner Kallweit wrote: > On 09.04.2019 22:59, David Miller wrote: >> From: Heiner Kallweit >> Date: Sun, 7 Apr 2019 11:57:13 +0200 >> >>> Recently genphy_read_abilities() has been added that dynamically detects >>> clause 22 PHY abilities. I *think* this detection should work with all >>> supported PHY's, at least for the ones with basic features sets, i.e. >>> PHY_BASIC_FEATURES and PHY_GBIT_FEATURES. So let's remove setting these >>> features explicitly and rely on phylib feature detection. >>> >>> I don't have access to most of these PHY's, therefore I'd appreciate >>> regression testing. >>> >>> Signed-off-by: Heiner Kallweit >> >> This appears to need to be done differently. >> >> A question was asked as to why fast ethernet PHY identification from the >> source is important, well I'd say it's important for someone working on >> the PHY code to see how "all fast ethernet PHY drivers do or handle X" >> > Then, what we could do: Change all occurrences of > .features = PHY_XXX_FEATURES > to > /* PHY_XXX_FEATURES */ > > Would this be an acceptable option? Yes absolutely, I was not thinking about anything more complicated than that, should have made it more obvious in my replies. Thanks! -- Florian