From: Sergei Shtylyov <sergei.shtylyov@cogentembedded.com>
To: "Niklas Söderlund" <niklas.soderlund@ragnatech.se>
Cc: netdev@vger.kernel.org, linux-renesas-soc@vger.kernel.org
Subject: Re: [PATCH v2] sh_eth: add support to change MTU
Date: Sat, 10 Jun 2017 22:26:13 +0300 [thread overview]
Message-ID: <239c39ff-cf0e-d332-7b52-098ba8029798@cogentembedded.com> (raw)
In-Reply-To: <20170609203658.GB17461@bigcity.dyn.berto.se>
Hello!
On 06/09/2017 11:36 PM, Niklas Söderlund wrote:
>> The hardware supports the MTU to be changed and the driver it self is
>> somewhat prepared to support this. This patch hooks up the callbacks to
>> be able to change the MTU from user-space.
>>
>> Signed-off-by: Niklas Söderlund <niklas.soderlund+renesas@ragnatech.se>
>> Acked-by: Sergei Shtylyov <sergei.shtylyov@cogentembedded.com>
>> ---
[...]
>> @@ -3171,6 +3184,13 @@ static int sh_eth_drv_probe(struct platform_device *pdev)
>> }
>> sh_eth_set_default_cpu_data(mdp->cd);
>>
>> + /* User's manua states max MTU should be 2048 but due to the
>
> s/manua/manual/
Looking at it for another time, I'd also reword the subject -- something
like "sh_eth: add support for changing MTU" or "sh_eth: add MTU change support".
MBR, Sergei
next prev parent reply other threads:[~2017-06-10 19:26 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-06-09 20:32 [PATCH v2] sh_eth: add support to change MTU Niklas Söderlund
2017-06-09 20:36 ` Niklas Söderlund
2017-06-10 19:26 ` Sergei Shtylyov [this message]
2017-06-09 20:44 ` Sergei Shtylyov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=239c39ff-cf0e-d332-7b52-098ba8029798@cogentembedded.com \
--to=sergei.shtylyov@cogentembedded.com \
--cc=linux-renesas-soc@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=niklas.soderlund@ragnatech.se \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox