From: David Ahern <dsahern@gmail.com>
To: Alexei Starovoitov <alexei.starovoitov@gmail.com>
Cc: David Miller <davem@davemloft.net>,
netdev@vger.kernel.org, edumazet@google.com, kafai@fb.com
Subject: Re: [PATCH net-next] ipv6: Move ipv6 stubs to a separate header file
Date: Tue, 26 Mar 2019 09:29:56 -0600 [thread overview]
Message-ID: <239e6141-5153-f21c-57d3-e39542477158@gmail.com> (raw)
In-Reply-To: <20190326151123.uz5g72gfxj2nr7fk@ast-mbp>
On 3/26/19 9:11 AM, Alexei Starovoitov wrote:
> On Tue, Mar 26, 2019 at 08:19:06AM -0600, David Ahern wrote:
>> work needed. To be able to reach certain clear steps and still maintain
>> the 20'ish patches in a set requirement, I have sent a few patches which
>> are standalone and basically noise - like this one - to avoid
>> distractions on the real change.
>
> This patch is far from noise. In the thread you said that you'll be
> adding 4 more indirect calls and that rings performance alarms.
> retpoline is expensive. If you want to add more indirect calls to fib lookup
> it's no go. Benchmarks with retpoline=off won't show the difference.
>
As I stated in the email I sent ("net: Improve route scalability via
support for nexthop objects"):
"adding hooks to the ipv6 stubs (bump sernum, send route notifications
and delete routes based on nexthop updates)."
Those plus initialization and release of fib6_nh are all done in the
control path.
next prev parent reply other threads:[~2019-03-26 15:30 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-03-22 13:06 [PATCH net-next] ipv6: Move ipv6 stubs to a separate header file David Ahern
2019-03-22 16:14 ` Alexei Starovoitov
2019-03-22 16:17 ` David Ahern
2019-03-22 17:04 ` Alexei Starovoitov
2019-03-24 1:40 ` David Miller
2019-03-24 3:55 ` Alexei Starovoitov
2019-03-24 12:56 ` David Ahern
2019-03-25 3:26 ` Alexei Starovoitov
2019-03-25 15:39 ` Stephen Suryaputra
2019-03-25 17:02 ` David Ahern
2019-03-26 3:05 ` Alexei Starovoitov
2019-03-26 14:19 ` David Ahern
2019-03-26 15:11 ` Alexei Starovoitov
2019-03-26 15:29 ` David Ahern [this message]
2019-03-26 2:22 ` David Ahern
2019-03-29 17:55 ` David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=239e6141-5153-f21c-57d3-e39542477158@gmail.com \
--to=dsahern@gmail.com \
--cc=alexei.starovoitov@gmail.com \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=kafai@fb.com \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).