Re: [PATCH net-next 0/9] net: bridge: vlan: minor cleanups and annotations

[Nikolay Aleksandrov <razor@blackwall.org>]

On 01/09/2026 15:07, Nikolay Aleksandrov wrote:
> Hi,
> In preparation for a complete vlan fast-path re-work, this set cleans up
> a few minor things - removing legacy code barriers that don't help,
>                       annotating lockless accesses and using proper helpers.
> No functional changes are intended. Sashiko will find many pre-existing
> problems, none of them are related to this set. I will try to fix
> everything pre-existing separately in -net, there will probably be a few
> critical items. So if there are missed places to annotate, or if there're
> actual functional changes, these obviously should be addressed in this set.
> 
> Thanks,
>   Nik
> 
> Nikolay Aleksandrov (9):
>    net: bridge: vlan: drop legacy memory barriers
>    net: bridge: vlan: annotate lockless pvid use
>    net: bridge: mst: use br_get_pvid helper
>    net: bridge: vlan: annotate lockless vlan flags use
>    net: bridge: vlan: annotate lockless use of private flags
>    net: bridge: vlan: annotate lockless use of num_vlans
>    net: bridge: vlan: annotate lockless use of msti
>    net: bridge: vlan: add missing tinfo.tunnel_id annotations
>    net: bridge: vlan: use br_vlan_get_state to get vlan state
> 
>   net/bridge/br_arp_nd_proxy.c   |  6 ++++--
>   net/bridge/br_mst.c            | 12 ++++++-----
>   net/bridge/br_multicast.c      | 18 ++++++++++------
>   net/bridge/br_netlink.c        | 10 ++++-----
>   net/bridge/br_netlink_tunnel.c | 12 +++++------
>   net/bridge/br_private.h        | 16 ++++++++------
>   net/bridge/br_vlan.c           | 39 +++++++++++++++++-----------------
>   net/bridge/br_vlan_options.c   |  6 ++++--
>   net/bridge/br_vlan_tunnel.c    |  2 +-
>   9 files changed, 67 insertions(+), 54 deletions(-)
> 

Me and Ido had a chat and he commented that patch 09 is far from done, I missed state
accesses outside of br_vlan.c, silly mistake. Anyway, I'll fix it up and post v2.

Cheers,
  Nik

---
pw-bot: cr