From mboxrd@z Thu Jan 1 00:00:00 1970 From: Timur Tabi Subject: Re: [patch net-next] net: qcom/emac: fix a sizeof() typo Date: Mon, 13 Feb 2017 07:03:19 -0600 Message-ID: <23c98d90-913d-f590-2677-096bf5dc15ff@codeaurora.org> References: <20170213110021.GA17205@mwanda> <58A19E97.6000704@bfs.de> Mime-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Cc: netdev@vger.kernel.org, linux-kernel@vger.kernel.org, kernel-janitors@vger.kernel.org To: wharms@bfs.de, Dan Carpenter Return-path: In-Reply-To: <58A19E97.6000704@bfs.de> Sender: kernel-janitors-owner@vger.kernel.org List-Id: netdev.vger.kernel.org walter harms wrote: > We have a function where the argument is ignored and the rest is const ? > > emac_ethtool_get_regs_len seems the only user. So it would be fairly easy to > move that into that function. > > @maintainer: > Is there a deeper logic behind this ? I don't understand the question. The patch is valid (I have no idea how I made that mistake). -- Sent by an employee of the Qualcomm Innovation Center, Inc. The Qualcomm Innovation Center, Inc. is a member of the Code Aurora Forum, hosted by The Linux Foundation.