From mboxrd@z Thu Jan  1 00:00:00 1970
From: Heiner Kallweit <hkallweit1@gmail.com>
Subject: Re: [PATCH net-next] net: phy: don't include asm/irq.h directly
Date: Tue, 15 Jan 2019 22:33:06 +0100
Message-ID: <23f72b6f-07e8-45e3-074d-eb82df525956@gmail.com>
References: <b45a616c-2ade-5823-e5da-bcd14b25d7ae@gmail.com>
 <20190115212951.GB26788@lunn.ch>
Mime-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 7bit
Cc: Florian Fainelli <f.fainelli@gmail.com>,
        David Miller <davem@davemloft.net>,
        "netdev@vger.kernel.org" <netdev@vger.kernel.org>
To: Andrew Lunn <andrew@lunn.ch>
Return-path: <netdev-owner@vger.kernel.org>
Received: from mail-wr1-f67.google.com ([209.85.221.67]:40258 "EHLO
        mail-wr1-f67.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
        with ESMTP id S1732877AbfAOVdO (ORCPT
        <rfc822;netdev@vger.kernel.org>); Tue, 15 Jan 2019 16:33:14 -0500
Received: by mail-wr1-f67.google.com with SMTP id p4so4657159wrt.7
        for <netdev@vger.kernel.org>; Tue, 15 Jan 2019 13:33:13 -0800 (PST)
In-Reply-To: <20190115212951.GB26788@lunn.ch>
Content-Language: en-US
Sender: netdev-owner@vger.kernel.org
List-ID: <netdev.vger.kernel.org>

On 15.01.2019 22:29, Andrew Lunn wrote:
>> diff --git a/drivers/net/phy/phy.c b/drivers/net/phy/phy.c
>> index 189cd2048..f95753eda 100644
>> --- a/drivers/net/phy/phy.c
>> +++ b/drivers/net/phy/phy.c
>> @@ -36,8 +36,6 @@
>>  #include <linux/uaccess.h>
>>  #include <linux/atomic.h>
>>  
>> -#include <asm/irq.h>
>> -
> 
> Hi Heiner
> 
> There is a call to request_threaded_irq() and free_irq() in this
> file. So it should probably include linux/irq.h.
> 
Both functions are declared in linux/interrupt.h which is included.
If you look into linux/irq.h a comment at the very beginning states
that this file shouldn't be included by generic code.

>       Andrew
> 
Heiner