* [PATCH net-next] net: phy: don't include asm/irq.h directly
@ 2019-01-15 20:40 Heiner Kallweit
2019-01-15 21:29 ` Andrew Lunn
` (3 more replies)
0 siblings, 4 replies; 6+ messages in thread
From: Heiner Kallweit @ 2019-01-15 20:40 UTC (permalink / raw)
To: Andrew Lunn, Florian Fainelli, David Miller; +Cc: netdev@vger.kernel.org
There's no need to and one shouldn't include asm/irq.h directly.
Signed-off-by: Heiner Kallweit <hkallweit1@gmail.com>
---
drivers/net/phy/mdio_bus.c | 2 --
drivers/net/phy/phy.c | 2 --
drivers/net/phy/phy_device.c | 2 --
3 files changed, 6 deletions(-)
diff --git a/drivers/net/phy/mdio_bus.c b/drivers/net/phy/mdio_bus.c
index 2e59a8419..741f27228 100644
--- a/drivers/net/phy/mdio_bus.c
+++ b/drivers/net/phy/mdio_bus.c
@@ -39,8 +39,6 @@
#include <linux/io.h>
#include <linux/uaccess.h>
-#include <asm/irq.h>
-
#define CREATE_TRACE_POINTS
#include <trace/events/mdio.h>
diff --git a/drivers/net/phy/phy.c b/drivers/net/phy/phy.c
index 189cd2048..f95753eda 100644
--- a/drivers/net/phy/phy.c
+++ b/drivers/net/phy/phy.c
@@ -36,8 +36,6 @@
#include <linux/uaccess.h>
#include <linux/atomic.h>
-#include <asm/irq.h>
-
#define PHY_STATE_STR(_state) \
case PHY_##_state: \
return __stringify(_state); \
diff --git a/drivers/net/phy/phy_device.c b/drivers/net/phy/phy_device.c
index a4df9f873..f7ec6cdf8 100644
--- a/drivers/net/phy/phy_device.c
+++ b/drivers/net/phy/phy_device.c
@@ -37,8 +37,6 @@
#include <linux/uaccess.h>
#include <linux/of.h>
-#include <asm/irq.h>
-
MODULE_DESCRIPTION("PHY library");
MODULE_AUTHOR("Andy Fleming");
MODULE_LICENSE("GPL");
--
2.20.1
^ permalink raw reply related [flat|nested] 6+ messages in thread* Re: [PATCH net-next] net: phy: don't include asm/irq.h directly
2019-01-15 20:40 [PATCH net-next] net: phy: don't include asm/irq.h directly Heiner Kallweit
@ 2019-01-15 21:29 ` Andrew Lunn
2019-01-15 21:33 ` Heiner Kallweit
2019-01-15 21:46 ` Andrew Lunn
` (2 subsequent siblings)
3 siblings, 1 reply; 6+ messages in thread
From: Andrew Lunn @ 2019-01-15 21:29 UTC (permalink / raw)
To: Heiner Kallweit; +Cc: Florian Fainelli, David Miller, netdev@vger.kernel.org
> diff --git a/drivers/net/phy/phy.c b/drivers/net/phy/phy.c
> index 189cd2048..f95753eda 100644
> --- a/drivers/net/phy/phy.c
> +++ b/drivers/net/phy/phy.c
> @@ -36,8 +36,6 @@
> #include <linux/uaccess.h>
> #include <linux/atomic.h>
>
> -#include <asm/irq.h>
> -
Hi Heiner
There is a call to request_threaded_irq() and free_irq() in this
file. So it should probably include linux/irq.h.
Andrew
^ permalink raw reply [flat|nested] 6+ messages in thread* Re: [PATCH net-next] net: phy: don't include asm/irq.h directly
2019-01-15 21:29 ` Andrew Lunn
@ 2019-01-15 21:33 ` Heiner Kallweit
0 siblings, 0 replies; 6+ messages in thread
From: Heiner Kallweit @ 2019-01-15 21:33 UTC (permalink / raw)
To: Andrew Lunn; +Cc: Florian Fainelli, David Miller, netdev@vger.kernel.org
On 15.01.2019 22:29, Andrew Lunn wrote:
>> diff --git a/drivers/net/phy/phy.c b/drivers/net/phy/phy.c
>> index 189cd2048..f95753eda 100644
>> --- a/drivers/net/phy/phy.c
>> +++ b/drivers/net/phy/phy.c
>> @@ -36,8 +36,6 @@
>> #include <linux/uaccess.h>
>> #include <linux/atomic.h>
>>
>> -#include <asm/irq.h>
>> -
>
> Hi Heiner
>
> There is a call to request_threaded_irq() and free_irq() in this
> file. So it should probably include linux/irq.h.
>
Both functions are declared in linux/interrupt.h which is included.
If you look into linux/irq.h a comment at the very beginning states
that this file shouldn't be included by generic code.
> Andrew
>
Heiner
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH net-next] net: phy: don't include asm/irq.h directly
2019-01-15 20:40 [PATCH net-next] net: phy: don't include asm/irq.h directly Heiner Kallweit
2019-01-15 21:29 ` Andrew Lunn
@ 2019-01-15 21:46 ` Andrew Lunn
2019-01-15 22:31 ` Florian Fainelli
2019-01-17 5:09 ` David Miller
3 siblings, 0 replies; 6+ messages in thread
From: Andrew Lunn @ 2019-01-15 21:46 UTC (permalink / raw)
To: Heiner Kallweit; +Cc: Florian Fainelli, David Miller, netdev@vger.kernel.org
On Tue, Jan 15, 2019 at 09:40:51PM +0100, Heiner Kallweit wrote:
> There's no need to and one shouldn't include asm/irq.h directly.
>
> Signed-off-by: Heiner Kallweit <hkallweit1@gmail.com>
Reviewed-by: Andrew Lunn <andrew@lunn.ch>
Andrew
^ permalink raw reply [flat|nested] 6+ messages in thread* Re: [PATCH net-next] net: phy: don't include asm/irq.h directly
2019-01-15 20:40 [PATCH net-next] net: phy: don't include asm/irq.h directly Heiner Kallweit
2019-01-15 21:29 ` Andrew Lunn
2019-01-15 21:46 ` Andrew Lunn
@ 2019-01-15 22:31 ` Florian Fainelli
2019-01-17 5:09 ` David Miller
3 siblings, 0 replies; 6+ messages in thread
From: Florian Fainelli @ 2019-01-15 22:31 UTC (permalink / raw)
To: Heiner Kallweit, Andrew Lunn, David Miller; +Cc: netdev@vger.kernel.org
On 1/15/19 12:40 PM, Heiner Kallweit wrote:
> There's no need to and one shouldn't include asm/irq.h directly.
>
> Signed-off-by: Heiner Kallweit <hkallweit1@gmail.com>
Reviewed-by: Florian Fainelli <f.fainelli@gmail.com>
--
Florian
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH net-next] net: phy: don't include asm/irq.h directly
2019-01-15 20:40 [PATCH net-next] net: phy: don't include asm/irq.h directly Heiner Kallweit
` (2 preceding siblings ...)
2019-01-15 22:31 ` Florian Fainelli
@ 2019-01-17 5:09 ` David Miller
3 siblings, 0 replies; 6+ messages in thread
From: David Miller @ 2019-01-17 5:09 UTC (permalink / raw)
To: hkallweit1; +Cc: andrew, f.fainelli, netdev
From: Heiner Kallweit <hkallweit1@gmail.com>
Date: Tue, 15 Jan 2019 21:40:51 +0100
> There's no need to and one shouldn't include asm/irq.h directly.
>
> Signed-off-by: Heiner Kallweit <hkallweit1@gmail.com>
Applied.
^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2019-01-17 5:09 UTC | newest]
Thread overview: 6+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2019-01-15 20:40 [PATCH net-next] net: phy: don't include asm/irq.h directly Heiner Kallweit
2019-01-15 21:29 ` Andrew Lunn
2019-01-15 21:33 ` Heiner Kallweit
2019-01-15 21:46 ` Andrew Lunn
2019-01-15 22:31 ` Florian Fainelli
2019-01-17 5:09 ` David Miller
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).