* [PATCH net v3] net: bonding: Fix error checking for debugfs_create_dir()
@ 2023-07-17 8:53 Wang Ming
2023-07-17 18:36 ` Tariq Toukan
0 siblings, 1 reply; 3+ messages in thread
From: Wang Ming @ 2023-07-17 8:53 UTC (permalink / raw)
To: Jay Vosburgh, Andy Gospodarek, David S. Miller, Eric Dumazet,
Jakub Kicinski, Paolo Abeni, Yufeng Mo, Guangbin Huang, netdev,
linux-kernel
Cc: opensource.kernel, jay.vosburgh, Wang Ming
The debugfs_create_dir() function returns error pointers,
it never returns NULL. Most incorrect error checks were fixed,
but the one in bond_create_debugfs() was forgotten.
Fixes: 52333512701b ("net: bonding: remove unnecessary braces")
Signed-off-by: Wang Ming <machel@vivo.com>
---
drivers/net/bonding/bond_debugfs.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/net/bonding/bond_debugfs.c b/drivers/net/bonding/bond_debugfs.c
index 594094526648..d4a82f276e87 100644
--- a/drivers/net/bonding/bond_debugfs.c
+++ b/drivers/net/bonding/bond_debugfs.c
@@ -88,7 +88,7 @@ void bond_create_debugfs(void)
{
bonding_debug_root = debugfs_create_dir("bonding", NULL);
- if (!bonding_debug_root)
+ if (IS_ERR(bonding_debug_root))
pr_warn("Warning: Cannot create bonding directory in debugfs\n");
}
--
2.25.1
^ permalink raw reply related [flat|nested] 3+ messages in thread* Re: [PATCH net v3] net: bonding: Fix error checking for debugfs_create_dir()
2023-07-17 8:53 [PATCH net v3] net: bonding: Fix error checking for debugfs_create_dir() Wang Ming
@ 2023-07-17 18:36 ` Tariq Toukan
2023-07-17 19:55 ` Jay Vosburgh
0 siblings, 1 reply; 3+ messages in thread
From: Tariq Toukan @ 2023-07-17 18:36 UTC (permalink / raw)
To: Wang Ming, Jay Vosburgh, Andy Gospodarek, David S. Miller,
Eric Dumazet, Jakub Kicinski, Paolo Abeni, Yufeng Mo,
Guangbin Huang, netdev, linux-kernel
Cc: opensource.kernel, jay.vosburgh, Tariq Toukan
On 17/07/2023 11:53, Wang Ming wrote:
> The debugfs_create_dir() function returns error pointers,
> it never returns NULL. Most incorrect error checks were fixed,
> but the one in bond_create_debugfs() was forgotten.
>
> Fixes: 52333512701b ("net: bonding: remove unnecessary braces")
It's not this commit to blame...
Issue was there in first place, starting in commit f073c7ca29a4
("bonding: add the debugfs facility to the bonding driver").
> Signed-off-by: Wang Ming <machel@vivo.com>
> ---
> drivers/net/bonding/bond_debugfs.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/net/bonding/bond_debugfs.c b/drivers/net/bonding/bond_debugfs.c
> index 594094526648..d4a82f276e87 100644
> --- a/drivers/net/bonding/bond_debugfs.c
> +++ b/drivers/net/bonding/bond_debugfs.c
> @@ -88,7 +88,7 @@ void bond_create_debugfs(void)
> {
> bonding_debug_root = debugfs_create_dir("bonding", NULL);
>
> - if (!bonding_debug_root)
> + if (IS_ERR(bonding_debug_root))
> pr_warn("Warning: Cannot create bonding directory in debugfs\n");
> }
>
^ permalink raw reply [flat|nested] 3+ messages in thread* Re: [PATCH net v3] net: bonding: Fix error checking for debugfs_create_dir()
2023-07-17 18:36 ` Tariq Toukan
@ 2023-07-17 19:55 ` Jay Vosburgh
0 siblings, 0 replies; 3+ messages in thread
From: Jay Vosburgh @ 2023-07-17 19:55 UTC (permalink / raw)
To: Tariq Toukan
Cc: Wang Ming, Andy Gospodarek, David S. Miller, Eric Dumazet,
Jakub Kicinski, Paolo Abeni, Yufeng Mo, Guangbin Huang, netdev,
linux-kernel, opensource.kernel, Tariq Toukan
Tariq Toukan <ttoukan.linux@gmail.com> wrote:
>On 17/07/2023 11:53, Wang Ming wrote:
>> The debugfs_create_dir() function returns error pointers,
>> it never returns NULL. Most incorrect error checks were fixed,
>> but the one in bond_create_debugfs() was forgotten.
>> Fixes: 52333512701b ("net: bonding: remove unnecessary braces")
>
>It's not this commit to blame...
>Issue was there in first place, starting in commit f073c7ca29a4 ("bonding:
>add the debugfs facility to the bonding driver").
Agreed; please upate the Fixes: commit and resubmit, thanks.
-J
>
>> Signed-off-by: Wang Ming <machel@vivo.com>
>> ---
>> drivers/net/bonding/bond_debugfs.c | 2 +-
>> 1 file changed, 1 insertion(+), 1 deletion(-)
>> diff --git a/drivers/net/bonding/bond_debugfs.c
>> b/drivers/net/bonding/bond_debugfs.c
>> index 594094526648..d4a82f276e87 100644
>> --- a/drivers/net/bonding/bond_debugfs.c
>> +++ b/drivers/net/bonding/bond_debugfs.c
>> @@ -88,7 +88,7 @@ void bond_create_debugfs(void)
>> {
>> bonding_debug_root = debugfs_create_dir("bonding", NULL);
>> - if (!bonding_debug_root)
>> + if (IS_ERR(bonding_debug_root))
>> pr_warn("Warning: Cannot create bonding directory in debugfs\n");
>> }
>>
---
-Jay Vosburgh, jay.vosburgh@canonical.com
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2023-07-17 19:55 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2023-07-17 8:53 [PATCH net v3] net: bonding: Fix error checking for debugfs_create_dir() Wang Ming
2023-07-17 18:36 ` Tariq Toukan
2023-07-17 19:55 ` Jay Vosburgh
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).