From: Eric Dumazet <eric.dumazet@gmail.com>
To: David Miller <davem@davemloft.net>, ssuryaextr@gmail.com
Cc: netdev@vger.kernel.org
Subject: Re: [PATCH net] ipv4: recompile ip options in ipv4_link_failure
Date: Sat, 13 Apr 2019 16:44:41 -0700 [thread overview]
Message-ID: <2414eaeb-7b6f-f5cf-e4b4-744b11d5641e@gmail.com> (raw)
In-Reply-To: <20190412.172421.1257922527433996366.davem@davemloft.net>
On 04/12/2019 05:24 PM, David Miller wrote:
> From: Stephen Suryaputra <ssuryaextr@gmail.com>
> Date: Fri, 12 Apr 2019 16:19:27 -0400
>
>> Recompile IP options since IPCB may not be valid anymore when
>> ipv4_link_failure is called from arp_error_report.
>>
>> Refer to the commit 3da1ed7ac398 ("net: avoid use IPCB in cipso_v4_error")
>> and the commit before that (9ef6b42ad6fd) for a similar issue.
>>
>> Signed-off-by: Stephen Suryaputra <ssuryaextr@gmail.com>
>
> Applied.
>
I believe __ip_options_compile() needs to be called from rcu_read_lock()
I will send a fix.
prev parent reply other threads:[~2019-04-13 23:44 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-04-12 20:19 [PATCH net] ipv4: recompile ip options in ipv4_link_failure Stephen Suryaputra
2019-04-13 0:24 ` David Miller
2019-04-13 23:44 ` Eric Dumazet [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=2414eaeb-7b6f-f5cf-e4b4-744b11d5641e@gmail.com \
--to=eric.dumazet@gmail.com \
--cc=davem@davemloft.net \
--cc=netdev@vger.kernel.org \
--cc=ssuryaextr@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).