From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-1.0 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id DCCAAC43219 for ; Thu, 25 Apr 2019 14:35:53 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id EA13520717 for ; Thu, 25 Apr 2019 14:35:53 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726829AbfDYOfw (ORCPT ); Thu, 25 Apr 2019 10:35:52 -0400 Received: from eu-smtp-delivery-151.mimecast.com ([207.82.80.151]:28635 "EHLO eu-smtp-delivery-151.mimecast.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726074AbfDYOfv (ORCPT ); Thu, 25 Apr 2019 10:35:51 -0400 Received: from AcuMS.aculab.com (156.67.243.126 [156.67.243.126]) (Using TLS) by relay.mimecast.com with ESMTP id uk-mta-192-dQrdSxmhOdi6yku6Ghij7A-1; Thu, 25 Apr 2019 15:35:48 +0100 Received: from AcuMS.Aculab.com (fd9f:af1c:a25b:0:43c:695e:880f:8750) by AcuMS.aculab.com (fd9f:af1c:a25b:0:43c:695e:880f:8750) with Microsoft SMTP Server (TLS) id 15.0.1347.2; Thu, 25 Apr 2019 15:35:46 +0100 Received: from AcuMS.Aculab.com ([fe80::43c:695e:880f:8750]) by AcuMS.aculab.com ([fe80::43c:695e:880f:8750%12]) with mapi id 15.00.1347.000; Thu, 25 Apr 2019 15:35:46 +0100 From: David Laight To: 'Willem de Bruijn' CC: "netdev@vger.kernel.org" , "davem@davemloft.net" , "idosch@idosch.org" , "Willem de Bruijn" Subject: RE: [PATCH net] packet: validate address length if non-zero Thread-Topic: [PATCH net] packet: validate address length if non-zero Thread-Index: AQHUmkDdSvpkaV9kXkOyGO8KJ3nLv6ZKP8XAgABHlICAABkn4IAB1QMygADfodCAAEMKAIAAFiPA Date: Thu, 25 Apr 2019 14:35:46 +0000 Message-ID: <24258ef339a7470b84a28854390f1163@AcuMS.aculab.com> References: <20181222215345.128704-1-willemdebruijn.kernel@gmail.com> <28df499bec4146fdbd9d66a6bf7dc621@AcuMS.aculab.com> <62f0a1c528b04e9eaa863179e227165a@AcuMS.aculab.com> <22299f1e84604c36a8a6c4635961cb8a@AcuMS.aculab.com> In-Reply-To: Accept-Language: en-GB, en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-ms-exchange-transport-fromentityheader: Hosted x-originating-ip: [10.202.205.107] MIME-Version: 1.0 X-MC-Unique: dQrdSxmhOdi6yku6Ghij7A-1 X-Mimecast-Spam-Score: 0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: base64 Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org RnJvbTogV2lsbGVtIGRlIEJydWlqbg0KPiBTZW50OiAyNSBBcHJpbCAyMDE5IDE0OjU3DQouLi4N Cj4gPiBJJ3ZlIGp1c3QgZG9uZSBhIGJpdCBvZiBzb2Z0d2FyZSBhcmNoYWVvbG9neS4NCj4gPg0K PiA+IFByaW9yIHRvIDIuNi4xNC1yYzMgdGhlIHNlbmQgY29kZSBpZ25vcmVkIHNsbF9oYWxlbiwg aXQgd2FzIG9ubHkgc2V0IGJ5IHRoZSByZWNlaXZlIGNvZGUuDQo+ID4gU28gaXQgaXMgbm90IHN1 cnByaXNpbmcgdGhhdCBvbGQgYXBwbGljYXRpb24gY29kZSBsZWF2ZXMgaXQgYXMgemVyby4NCj4g Pg0KPiA+IFRoZSBvbGQgcmVjZWl2ZSBjb2RlIGFsc28gYWx3YXlzIHNldCBtc2dfbmFtZWxlbiA9 IHNpemVvZiAoc3RydWN0IHNvY2thZGRyX2xsKS4NCj4gPiBUaGUgcmVjZWl2ZSBjb2RlIG5vdyBz ZXRzOg0KPiA+ICAgbXNnX25hbWVsZW4gPSBvZmZzZXRvZihzdHJ1Y3Qgc29ja2FkZHJfbGwsIHNs bF9hZGRyKSArIHNhZGRyLT5zbGxfaGFsZW47DQo+ID4gRm9yIGV0aGVybmV0IHRoaXMgY2hhbmdl cyB0aGUgbXNnX25hbWVsZW4gZnJvbSAyMCB0byAxOC4NCj4gPiBBIHNpZGUgZWZmZWN0IChubyBv bmUgaGFzIG5vdGljZWQgZm9yIHllYXJzKSBpcyB0aGF0IHlvdSBjYW4ndCBzZW5kIGEgcmVwbHkN Cj4gPiBieSBwYXNzaW5nIGJhY2sgdGhlIHJlY2VpdmVkIGFkZHJlc3MgYnVmZmVyLg0KPiANCj4g R3JlYXQgZmluZCwgdGhhbmtzLiBJIGhhZG4ndCB0aG91Z2h0IG9mIGdvaW5nIGJhY2sgdGhhdCBm YXIsIGJ1dA0KPiBjbGVhcmx5IHNob3VsZCBpbiB0aGVzZSBsZWdhY3kgY2FsbGVyIHF1ZXN0aW9u cy4uDQoNCkZvcnR1bmF0ZWx5IEkgZGlkbid0IGhhdmUgdG8gZmluZCB0aGUgcHJlLWdpdCBzb3Vy Y2VzIDotKQ0KDQo+ID4gTG9va2luZyBhdCBpdCBhbGwgYWdhaW4gaG93IGFib3V0Og0KPiA+ICAg ICAgICAgY2hhciAqYWRkciA9IE5VTEw7DQo+ID4gICAgICAgICAuLi4NCj4gPiAgICAgICAgICAg ICAgICAgICAgICAgICBlcnIgPSAtRUlOVkFMOw0KPiA+ICAgICAgICAgICAgICAgICAgICAgICAg IGlmIChtc2ctPm1zZ19uYW1lbGVuIDwgb2Zmc2V0b2Yoc3RydWN0IHNvY2thZGRyX2xsLCBzbGxf YWRkcikpDQo+ID4gICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICBnb3RvIG91dDsNCj4g PiAgICAgICAgICAgICAgICAgICAgICAgICBwcm90byA9IHNhZGRyLT5zbGxfcHJvdG9jb2w7DQo+ ID4gICAgICAgICAgICAgICAgICAgICAgICAgZGV2ID0gZGV2X2dldF9ieV9pbmRleChzb2NrX25l dChzayksIHNhZGRyLT5zbGxfaWZpbmRleCk7DQo+ID4gICAgICAgICAgICAgICAgICAgICAgICAg aWYgKGRldiAmJiBzb2NrLT50eXBlID09IFNPQ0tfREdSQU0pIHsNCj4gPiAgICAgICAgICAgICAg ICAgICAgICAgICAgICAgICAgIGlmIChtc2ctPm1zZ19uYW1lbGVuIDwgZGV2LT5hZGRyX2xlbiAr IG9mZnNldG9mKHN0cnVjdCBzb2NrYWRkcl9sbCwgc2xsX2FkZHIpKQ0KPiA+ICAgICAgICAgICAg ICAgICAgICAgICAgICAgICAgICAgICAgICAgICBnb3RvIG91dF91bmxvY2s7DQo+ID4gICAgICAg ICAgICAgICAgICAgICAgICAgICAgICAgICBhZGRyID0gc2FkZHItPnNsbF9hZGRyOw0KPiA+ICAg ICAgICAgICAgICAgICAgICAgICAgIH0NCj4gDQo+IFllcywgZ2l2ZW4gdGhlIGFib3ZlLCB0aGlz IGxvb2tzIGdyZWF0IHRvIG1lLg0KPiANCj4gSW4gZ2VuZXJhbCBJJ20gaGVzaXRhbnQgdG8gbG9v c2VuIGludGVyZmFjZSBjb25zdHJhaW50cy4gQXMgeW91IGNhbg0KPiBuZXZlciB0aWdodGVuIHRo ZW0gYWdhaW4uDQoNCkluZGVlZC4NCg0KPiBCdXQgZ2l2ZW4gdGhlIGNoYW5nZSBvbiByZWN2LCBp dCBzZWVtcw0KPiBjb3JyZWN0IGhlcmUuIFRoYXQgaXMgdGVjaG5pY2FsbHkgYSBzZXBhcmF0ZSBp c3N1ZSwgc28gd29ydGggYQ0KPiBzZXBhcmF0ZSBwYXRjaCwgSSB0aGluay4gSWYgdGhhdCdzIG5v dCB0b28gcGVkYW50aWMuIEVsc2UgYXQgbGVhc3QgYW4NCj4gZXh0cmEgRml4ZXMgdGFnLg0KDQpP ciBsZWF2ZSB0aGUgYWJvdmUgdXNpbmcgJ3NpemVvZicgYW5kIGNoYW5nZSB0aGUgcmVjZWl2ZSBj b2RlIHRvIHBhZCB0aGUNCmFkZHJlc3MgdG8gc2l6ZW9mIHN0cnVjdCBzb2NrYWRkcl9sbC4NCldo aWNoIGlzIGRlZmluaXRlbHkgYSBjb21wbGV0ZWx5IGRpZmZlcmVudCBmaXguDQpUaGUgcnggY29k ZSBzZWVtcyB0byBiZToNCg0KCQlpZiAoc29jay0+dHlwZSA9PSBTT0NLX1BBQ0tFVCkgew0KCQkJ X19zb2NrYWRkcl9jaGVja19zaXplKHNpemVvZihzdHJ1Y3Qgc29ja2FkZHJfcGt0KSk7DQoJCQlt c2ctPm1zZ19uYW1lbGVuID0gc2l6ZW9mKHN0cnVjdCBzb2NrYWRkcl9wa3QpOw0KCQl9IGVsc2Ug ew0KCQkJc3RydWN0IHNvY2thZGRyX2xsICpzbGwgPSAmUEFDS0VUX1NLQl9DQihza2IpLT5zYS5s bDsNCg0KCQkJbXNnLT5tc2dfbmFtZWxlbiA9IHNsbC0+c2xsX2hhbGVuICsNCgkJCQlvZmZzZXRv ZihzdHJ1Y3Qgc29ja2FkZHJfbGwsIHNsbF9hZGRyKTsNCgkJfQ0KCQltZW1jcHkobXNnLT5tc2df bmFtZSwgJlBBQ0tFVF9TS0JfQ0Ioc2tiKS0+c2EsDQoJCSAgICAgICBtc2ctPm1zZ19uYW1lbGVu KTsNCg0KSG9wZWZ1bGx5IHRoZSBidWZmZXIgaXMgYWx3YXlzIGJpZyBlbm91Z2ghDQpBc3N1bWlu ZyB0aGF0IHRoZSBjb2RlIHRoYXQgc2V0cyB1cCB0aGUgYWRkcmVzcyB6YXBzIHRoZSBsYXN0IHR3 byBieXRlcw0KdGhlIFNPQ0tfREdSQU0gc2lkZSBqdXN0IG5lZWRzIGEgbWF4KCwgc2l6ZW9mIChz dHJ1Y3Qgc29ja2FkZHJfbGwpKS4NClplcm9pbmcgdGhlIDggYnl0ZSBmaWVsZCBiZWZvcmUgdGhl IG1hYyBhZGRyZXNzIGlzIHB1dCBpbnRvIGl0IGlzIGNoZWFwDQoob25lIDY0Yml0IHdyaXRlIG9u IDY0Yml0IHN5c3RlbXMpLg0KDQpJIGd1ZXNzIHRoaXMgd291bGQgaGF2ZSAnRml4ZXMnIHRhZyBm b3IgdGhlIDIuNi4xNCBnaXQgdGFnIQ0KDQoJRGF2aWQNCg0KLQ0KUmVnaXN0ZXJlZCBBZGRyZXNz IExha2VzaWRlLCBCcmFtbGV5IFJvYWQsIE1vdW50IEZhcm0sIE1pbHRvbiBLZXluZXMsIE1LMSAx UFQsIFVLDQpSZWdpc3RyYXRpb24gTm86IDEzOTczODYgKFdhbGVzKQ0K