From: David Howells <dhowells@redhat.com>
To: Pranith Kumar <bobby.prani@gmail.com>
Cc: dhowells@redhat.com, "David S. Miller" <davem@davemloft.net>,
Dan Carpenter <dan.carpenter@oracle.com>,
netdev@vger.kernel.org (open list:NETWORKING [GENERAL]),
linux-kernel@vger.kernel.org (open list),
paulmck@linux.vnet.ibm.com
Subject: Re: [PATCH 16/16] rxrpc: Replace smp_read_barrier_depends() with lockless_dereference()
Date: Thu, 13 Nov 2014 20:17:39 +0000 [thread overview]
Message-ID: <24350.1415909859@warthog.procyon.org.uk> (raw)
In-Reply-To: <1415906662-4576-17-git-send-email-bobby.prani@gmail.com>
Pranith Kumar <bobby.prani@gmail.com> wrote:
> loop != call->acks_head || stop;
> loop = (loop + 1) & (call->acks_winsz - 1)
> ) {
> - p_txb = call->acks_window + loop;
> - smp_read_barrier_depends();
> + p_txb = lockless_dereference(call)->acks_window + loop;
Nack. You've stuck an implicit barrier on a dereference that doesn't matter.
And similar for other hunks of this patch.
David
next prev parent reply other threads:[~2014-11-13 20:17 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <1415906662-4576-1-git-send-email-bobby.prani@gmail.com>
2014-11-13 19:24 ` [PATCH 15/16] netfilter: Replace smp_read_barrier_depends() with lockless_dereference() Pranith Kumar
2014-11-13 19:24 ` [PATCH 16/16] rxrpc: " Pranith Kumar
2014-11-13 20:17 ` David Howells [this message]
2014-11-13 20:47 ` David Howells
2014-11-13 21:55 ` Pranith Kumar
2014-11-13 23:07 ` David Howells
2014-11-13 20:07 ` [RFC PATCH 00/16] Replace smp_read_barrier_depends() with lockless_derefrence() Paul E. McKenney
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=24350.1415909859@warthog.procyon.org.uk \
--to=dhowells@redhat.com \
--cc=bobby.prani@gmail.com \
--cc=dan.carpenter@oracle.com \
--cc=davem@davemloft.net \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=paulmck@linux.vnet.ibm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).