netdev.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Eric Dumazet <eric.dumazet@gmail.com>
To: "Bartschies, Thomas" <Thomas.Bartschies@cvk.de>,
	'David Ahern' <dsahern@gmail.com>,
	"'netdev@vger.kernel.org'" <netdev@vger.kernel.org>
Subject: Re: big ICMP requests get disrupted on IPSec tunnel activation
Date: Wed, 16 Oct 2019 08:31:46 -0700	[thread overview]
Message-ID: <24354e08-fa07-9383-e8ba-7350b40d3171@gmail.com> (raw)
In-Reply-To: <EB8510AA7A943D43916A72C9B8F4181F62A096BF@cvk038.intra.cvk.de>



On 10/16/19 5:57 AM, Bartschies, Thomas wrote:
> Hello,
> 
> did another test. This time I've changed the order. First triggered the IPSec policy and then tried to ping in parallel with a big packet size.
> Could also reproduce the issue, but the trace was completely different. May be this time I've got the trace for the problematic connection?
> 

This one was probably a false positive.

The other one, I finally understood what was going on.

You told us you removed netfilter, but it seems you still have the ip defrag modules there.

(For a pure fowarding node, no reassembly-defrag should be needed)

When ip_forward() is used, it correctly clears skb->tstamp

But later, ip_do_fragment() might re-use the skbs found attached to the master skb
and we do not init properly their skb->tstamp 

The master skb->tstamp should be copied to the children.

I will send a patch asap.

Thanks.


  reply	other threads:[~2019-10-16 15:31 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-10-16 12:57 big ICMP requests get disrupted on IPSec tunnel activation Bartschies, Thomas
2019-10-16 15:31 ` Eric Dumazet [this message]
2019-10-16 15:40   ` Eric Dumazet
2019-10-16 18:54     ` AW: " Bartschies, Thomas
2019-10-16 19:54       ` Eric Dumazet
  -- strict thread matches above, loose matches on Subject: below --
2019-10-17  4:44 Bartschies, Thomas
2019-09-13  8:59 Bartschies, Thomas
2019-09-13 17:13 ` David Ahern

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=24354e08-fa07-9383-e8ba-7350b40d3171@gmail.com \
    --to=eric.dumazet@gmail.com \
    --cc=Thomas.Bartschies@cvk.de \
    --cc=dsahern@gmail.com \
    --cc=netdev@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).