netdev.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: SF Markus Elfring <elfring@users.sourceforge.net>
To: linux-sctp@vger.kernel.org, netdev@vger.kernel.org,
	"David S. Miller" <davem@davemloft.net>,
	Neil Horman <nhorman@tuxdriver.com>,
	Vlad Yasevich <vyasevich@gmail.com>
Cc: LKML <linux-kernel@vger.kernel.org>, kernel-janitors@vger.kernel.org
Subject: [PATCH 1/5] sctp: Use kmalloc_array() in sctp_init()
Date: Mon, 22 May 2017 18:37:19 +0200	[thread overview]
Message-ID: <24442429-99f7-7d83-5f56-f84776a81880@users.sourceforge.net> (raw)
In-Reply-To: <2845df67-d35d-536a-0a53-b2eb83fe1ba5@users.sourceforge.net>

From: Markus Elfring <elfring@users.sourceforge.net>
Date: Mon, 22 May 2017 17:20:11 +0200

* A multiplication for the size determination of a memory allocation
  indicated that an array data structure should be processed.
  Thus use the corresponding function "kmalloc_array".

  This issue was detected by using the Coccinelle software.

* Replace the specification of a data structure by a pointer dereference
  to make the corresponding size determination a bit safer according to
  the Linux coding style convention.

Signed-off-by: Markus Elfring <elfring@users.sourceforge.net>
---
 net/sctp/protocol.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/net/sctp/protocol.c b/net/sctp/protocol.c
index 989a900383b5..2b1a6215bd2f 100644
--- a/net/sctp/protocol.c
+++ b/net/sctp/protocol.c
@@ -1442,6 +1442,6 @@ static __init int sctp_init(void)
 
 	/* Allocate and initialize the endpoint hash table.  */
 	sctp_ep_hashsize = 64;
-	sctp_ep_hashtable =
-		kmalloc(64 * sizeof(struct sctp_hashbucket), GFP_KERNEL);
+	sctp_ep_hashtable = kmalloc_array(64, sizeof(*sctp_ep_hashtable),
+					  GFP_KERNEL);
 	if (!sctp_ep_hashtable) {
-- 
2.13.0

  reply	other threads:[~2017-05-22 16:37 UTC|newest]

Thread overview: 20+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-05-22 16:35 [PATCH 0/5] net-SCTP: Adjustments for three function implementations SF Markus Elfring
2017-05-22 16:37 ` SF Markus Elfring [this message]
2017-05-22 19:51   ` [PATCH 1/5] sctp: Use kmalloc_array() in sctp_init() Marcelo Ricardo Leitner
2017-05-22 20:57   ` Vlad Yasevich
2017-05-22 16:38 ` [PATCH 2/5] sctp: Delete an error message for a failed memory allocation " SF Markus Elfring
2017-05-22 16:56   ` Marcelo Ricardo Leitner
2017-05-22 19:46     ` SF Markus Elfring
2017-05-22 19:50       ` Marcelo Ricardo Leitner
2017-05-22 19:52   ` Marcelo Ricardo Leitner
2017-05-22 20:59   ` Vlad Yasevich
2017-05-22 16:39 ` [PATCH 3/5] sctp: Fix a typo in a comment line " SF Markus Elfring
2017-05-22 19:52   ` Marcelo Ricardo Leitner
2017-05-22 21:00   ` Vlad Yasevich
2017-05-22 16:40 ` [PATCH 4/5] sctp: Improve a size determination in sctp_inetaddr_event() SF Markus Elfring
2017-05-22 19:52   ` Marcelo Ricardo Leitner
2017-05-22 21:00   ` Vlad Yasevich
2017-05-22 16:41 ` [PATCH 5/5] sctp: Adjust one function call together with a variable assignment SF Markus Elfring
2017-05-22 19:53   ` Marcelo Ricardo Leitner
2017-05-22 21:00   ` Vlad Yasevich
2017-05-23  6:34 ` [PATCH 0/5] net-SCTP: Adjustments for three function implementations Xin Long

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=24442429-99f7-7d83-5f56-f84776a81880@users.sourceforge.net \
    --to=elfring@users.sourceforge.net \
    --cc=davem@davemloft.net \
    --cc=kernel-janitors@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-sctp@vger.kernel.org \
    --cc=netdev@vger.kernel.org \
    --cc=nhorman@tuxdriver.com \
    --cc=vyasevich@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).