* [PATCH] net: phy: micrel: KSZ8795 do not set SUPPORTED_[Asym_]Pause
@ 2017-01-27 20:39 Sean Nyekjaer
2017-01-27 20:51 ` Florian Fainelli
2017-01-29 23:45 ` David Miller
0 siblings, 2 replies; 3+ messages in thread
From: Sean Nyekjaer @ 2017-01-27 20:39 UTC (permalink / raw)
To: netdev; +Cc: Sean Nyekjaer, f.fainelli
As pr commit "net: phy: phy drivers should not set SUPPORTED_[Asym_]Pause"
this phy driver should not set these feature bits.
Signed-off-by: Sean Nyekjaer <sean.nyekjaer@prevas.dk>
Fixes: 9d162ed69f51 ("net: phy: micrel: add support for KSZ8795")
---
drivers/net/phy/micrel.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/net/phy/micrel.c b/drivers/net/phy/micrel.c
index e55809c5beb7..6742070ca676 100644
--- a/drivers/net/phy/micrel.c
+++ b/drivers/net/phy/micrel.c
@@ -1012,7 +1012,7 @@ static struct phy_driver ksphy_driver[] = {
.phy_id = PHY_ID_KSZ8795,
.phy_id_mask = MICREL_PHY_ID_MASK,
.name = "Micrel KSZ8795",
- .features = (SUPPORTED_Pause | SUPPORTED_Asym_Pause),
+ .features = PHY_BASIC_FEATURES,
.flags = PHY_HAS_MAGICANEG | PHY_HAS_INTERRUPT,
.config_init = kszphy_config_init,
.config_aneg = ksz8873mll_config_aneg,
--
2.11.0
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH] net: phy: micrel: KSZ8795 do not set SUPPORTED_[Asym_]Pause
2017-01-27 20:39 [PATCH] net: phy: micrel: KSZ8795 do not set SUPPORTED_[Asym_]Pause Sean Nyekjaer
@ 2017-01-27 20:51 ` Florian Fainelli
2017-01-29 23:45 ` David Miller
1 sibling, 0 replies; 3+ messages in thread
From: Florian Fainelli @ 2017-01-27 20:51 UTC (permalink / raw)
To: Sean Nyekjaer, netdev
On 01/27/2017 12:39 PM, Sean Nyekjaer wrote:
> As pr commit "net: phy: phy drivers should not set SUPPORTED_[Asym_]Pause"
> this phy driver should not set these feature bits.
>
> Signed-off-by: Sean Nyekjaer <sean.nyekjaer@prevas.dk>
> Fixes: 9d162ed69f51 ("net: phy: micrel: add support for KSZ8795")
Reviewed-by: Florian Fainelli <f.fainelli@gmail.com>
--
Florian
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] net: phy: micrel: KSZ8795 do not set SUPPORTED_[Asym_]Pause
2017-01-27 20:39 [PATCH] net: phy: micrel: KSZ8795 do not set SUPPORTED_[Asym_]Pause Sean Nyekjaer
2017-01-27 20:51 ` Florian Fainelli
@ 2017-01-29 23:45 ` David Miller
1 sibling, 0 replies; 3+ messages in thread
From: David Miller @ 2017-01-29 23:45 UTC (permalink / raw)
To: sean.nyekjaer; +Cc: netdev, f.fainelli
From: Sean Nyekjaer <sean.nyekjaer@prevas.dk>
Date: Fri, 27 Jan 2017 21:39:03 +0100
> As pr commit "net: phy: phy drivers should not set SUPPORTED_[Asym_]Pause"
> this phy driver should not set these feature bits.
>
> Signed-off-by: Sean Nyekjaer <sean.nyekjaer@prevas.dk>
> Fixes: 9d162ed69f51 ("net: phy: micrel: add support for KSZ8795")
Applied.
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2017-01-29 23:45 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2017-01-27 20:39 [PATCH] net: phy: micrel: KSZ8795 do not set SUPPORTED_[Asym_]Pause Sean Nyekjaer
2017-01-27 20:51 ` Florian Fainelli
2017-01-29 23:45 ` David Miller
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).