From: Arnd Bergmann <arnd@arndb.de>
To: Lada Trimasova <Lada.Trimasova@synopsys.com>
Cc: netdev@vger.kernel.org, linux-kernel@vger.kernel.org,
Alexey Brodkin <Alexey.Brodkin@synopsys.com>,
Noam Camus <noamc@ezchip.com>, Tal Zilcer <talz@ezchip.com>
Subject: Re: [PATCH] net: ezchip: adapt driver to little endian architecture
Date: Fri, 26 Feb 2016 21:10:31 +0100 [thread overview]
Message-ID: <24793363.yg41IbJKTo@wuerfel> (raw)
In-Reply-To: <1456513509-30844-1-git-send-email-ltrimas@synopsys.com>
On Friday 26 February 2016 22:05:09 Lada Trimasova wrote:
> for (i = 0; i < len; i++, reg++) {
> u32 buf = nps_enet_reg_get(priv, NPS_ENET_REG_RX_BUF);
> + buf = be32_to_cpu(buf);
> put_unaligned(buf, reg);
> }
I think most of the changes can make use of the put_unaligned_be32()
etc helpers that might also be more efficient.
Arnd
next prev parent reply other threads:[~2016-02-26 20:10 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-02-26 19:05 [PATCH] net: ezchip: adapt driver to little endian architecture Lada Trimasova
2016-02-26 20:10 ` Arnd Bergmann [this message]
2016-02-26 20:25 ` David Miller
2016-02-26 20:12 ` Arnd Bergmann
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=24793363.yg41IbJKTo@wuerfel \
--to=arnd@arndb.de \
--cc=Alexey.Brodkin@synopsys.com \
--cc=Lada.Trimasova@synopsys.com \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=noamc@ezchip.com \
--cc=talz@ezchip.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox