From mboxrd@z Thu Jan 1 00:00:00 1970 From: Daniel Borkmann Subject: Re: [bpf-next v2 8/9] bpf: Provide helper to do forwarding lookups in kernel FIB table Date: Mon, 7 May 2018 16:10:03 +0200 Message-ID: <247aa1c4-e860-db72-fbb4-9da6c3a3f84c@iogearbox.net> References: <20180504025432.23451-1-dsahern@gmail.com> <20180504025432.23451-9-dsahern@gmail.com> <20180507153552.5063a4b2@redhat.com> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit Cc: netdev@vger.kernel.org, borkmann@iogearbox.net, ast@kernel.org, davem@davemloft.net, shm@cumulusnetworks.com, roopa@cumulusnetworks.com, toke@toke.dk, john.fastabend@gmail.com To: Jesper Dangaard Brouer , David Ahern Return-path: Received: from www62.your-server.de ([213.133.104.62]:55804 "EHLO www62.your-server.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752539AbeEGOKG (ORCPT ); Mon, 7 May 2018 10:10:06 -0400 In-Reply-To: <20180507153552.5063a4b2@redhat.com> Content-Language: en-US Sender: netdev-owner@vger.kernel.org List-ID: On 05/07/2018 03:35 PM, Jesper Dangaard Brouer wrote: > On Thu, 3 May 2018 19:54:31 -0700 David Ahern wrote: > >> diff --git a/net/core/filter.c b/net/core/filter.c >> index 6877426c23a6..cf0d27acf1d1 100644 >> --- a/net/core/filter.c >> +++ b/net/core/filter.c > [...] >> +static const struct bpf_func_proto bpf_xdp_fib_lookup_proto = { >> + .func = bpf_xdp_fib_lookup, >> + .gpl_only = true, > > Is it a deliberate choice to require BPF-progs using this helper to be > GPL licensed? > > Asking as this seems to be the first network related helper with this > requirement, while this is typical for tracing related helpers. Good point, we should remove that. In networking it's only the perf event output helpers tying into tracing bits. After all, if you do a route lookup via netlink from user space there's no such restriction at all.