[PATCH net v1] net:bonding:Fix error checking for debugfs_create_dir()

[PATCH net v1] net:bonding:Fix error checking for debugfs_create_dir()

[Wang Ming]

The debugfs_create_dir() function returns error pointers,
it never returns NULL. Most incorrect error checks were fixed,
but the one in bond_create_debugfs() was forgotten.

Fix the remaining error check.

Signed-off-by: Wang Ming <machel@vivo.com>

Fixes: 52333512701b ("net: bonding: remove unnecessary braces")
---
 drivers/net/bonding/bond_debugfs.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/net/bonding/bond_debugfs.c b/drivers/net/bonding/bond_debugfs.c
index 594094526648..d4a82f276e87 100644
--- a/drivers/net/bonding/bond_debugfs.c
+++ b/drivers/net/bonding/bond_debugfs.c
@@ -88,7 +88,7 @@ void bond_create_debugfs(void)
 {
 	bonding_debug_root = debugfs_create_dir("bonding", NULL);
 
-	if (!bonding_debug_root)
+	if (IS_ERR(bonding_debug_root))
 		pr_warn("Warning: Cannot create bonding directory in debugfs\n");
 }
 
-- 
2.25.1

Re: [PATCH net v1] net:bonding:Fix error checking for debugfs_create_dir()

[Jay Vosburgh]

Wang Ming <machel@vivo.com> wrote:

>The debugfs_create_dir() function returns error pointers,
>it never returns NULL. Most incorrect error checks were fixed,
>but the one in bond_create_debugfs() was forgotten.
>
>Fix the remaining error check.
>
>Signed-off-by: Wang Ming <machel@vivo.com>

	Seems fine to me; note that almost nobody uses this as bonding
debugfs is hidden behind !CONFIG_NET_NS.

Acked-by: Jay Vosburgh <jay.vosburgh@canonical.com>

	-J

>Fixes: 52333512701b ("net: bonding: remove unnecessary braces")
>---
> drivers/net/bonding/bond_debugfs.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
>diff --git a/drivers/net/bonding/bond_debugfs.c b/drivers/net/bonding/bond_debugfs.c
>index 594094526648..d4a82f276e87 100644
>--- a/drivers/net/bonding/bond_debugfs.c
>+++ b/drivers/net/bonding/bond_debugfs.c
>@@ -88,7 +88,7 @@ void bond_create_debugfs(void)
> {
> 	bonding_debug_root = debugfs_create_dir("bonding", NULL);
> 
>-	if (!bonding_debug_root)
>+	if (IS_ERR(bonding_debug_root))
> 		pr_warn("Warning: Cannot create bonding directory in debugfs\n");
> }
> 
>-- 
>2.25.1
>
>

回复: [PATCH net v1] net:bonding:Fix error checking for debugfs_create_dir()

[王明-软件底层技术部]

I think we can remove the check on it, don't you agree? Maybe I should resubmit a new patch
Regards
Wang Ming

-----邮件原件-----
发件人: Jay Vosburgh <jay.vosburgh@canonical.com> 
发送时间: 2023年7月13日 23:49
收件人: 王明-软件底层技术部 <machel@vivo.com>
抄送: Andy Gospodarek <andy@greyhouse.net>; David S. Miller <davem@davemloft.net>; Eric Dumazet <edumazet@google.com>; Jakub Kicinski <kuba@kernel.org>; Paolo Abeni <pabeni@redhat.com>; Yufeng Mo <moyufeng@huawei.com>; Guangbin Huang <huangguangbin2@huawei.com>; netdev@vger.kernel.org; linux-kernel@vger.kernel.org; opensource.kernel <opensource.kernel@vivo.com>
主题: Re: [PATCH net v1] net:bonding:Fix error checking for debugfs_create_dir()

[????????? jay.vosburgh@canonical.com ????????? https://aka.ms/LearnAboutSenderIdentification?????????????]

Wang Ming <machel@vivo.com> wrote:

>The debugfs_create_dir() function returns error pointers, it never 
>returns NULL. Most incorrect error checks were fixed, but the one in 
>bond_create_debugfs() was forgotten.
>
>Fix the remaining error check.
>
>Signed-off-by: Wang Ming <machel@vivo.com>

        Seems fine to me; note that almost nobody uses this as bonding debugfs is hidden behind !CONFIG_NET_NS.

Acked-by: Jay Vosburgh <jay.vosburgh@canonical.com>

        -J

>Fixes: 52333512701b ("net: bonding: remove unnecessary braces")
>---
> drivers/net/bonding/bond_debugfs.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
>diff --git a/drivers/net/bonding/bond_debugfs.c 
>b/drivers/net/bonding/bond_debugfs.c
>index 594094526648..d4a82f276e87 100644
>--- a/drivers/net/bonding/bond_debugfs.c
>+++ b/drivers/net/bonding/bond_debugfs.c
>@@ -88,7 +88,7 @@ void bond_create_debugfs(void)  {
>       bonding_debug_root = debugfs_create_dir("bonding", NULL);
>
>-      if (!bonding_debug_root)
>+      if (IS_ERR(bonding_debug_root))
>               pr_warn("Warning: Cannot create bonding directory in 
> debugfs\n"); }
>
>--
>2.25.1
>
>

Re: [PATCH] net: bonding: Fix error checking for debugfs_create_dir()

[Markus Elfring]

> The debugfs_create_dir() function returns error pointers,
> it never returns NULL. Most incorrect error checks were fixed,
> but the one in bond_create_debugfs() was forgotten.
>
> Fix the remaining error check.
>
> Signed-off-by: Wang Ming <machel@vivo.com>
>
> Fixes: 52333512701b ("net: bonding: remove unnecessary braces")

Would any other tag ordering be preferred?


How do you think about to use a subject like “[PATCH v2] net: bonding:
Fix an error check in bond_create_debugfs()”?

Regards,
Markus