public inbox for netdev@vger.kernel.org
 help / color / mirror / Atom feed
From: Andrew Lunn <andrew@lunn.ch>
To: Qingfang Deng <dqfext@gmail.com>
Cc: Paolo Abeni <pabeni@redhat.com>, Jakub Kicinski <kuba@kernel.org>,
	Dianne Skoll <dianne@skoll.ca>, Shuah Khan <shuah@kernel.org>,
	"David S. Miller" <davem@davemloft.net>,
	Eric Dumazet <edumazet@google.com>,
	Simon Horman <horms@kernel.org>,
	Felix Maurer <fmaurer@redhat.com>,
	Sebastian Andrzej Siewior <bigeasy@linutronix.de>,
	"Matthieu Baerts (NGI0)" <matttbe@kernel.org>,
	linux-kernel@vger.kernel.org, linux-kselftest@vger.kernel.org,
	linux-ppp@vger.kernel.org, netdev@vger.kernel.org,
	Paul Mackerras <paulus@ozlabs.org>, Jaco Kroon <jaco@uls.co.za>
Subject: Re: [PATCH net-next v7] selftests: net: add tests for PPP
Date: Thu, 2 Apr 2026 16:37:01 +0200	[thread overview]
Message-ID: <24aea6cc-d599-4935-8a75-34f38b852d1e@lunn.ch> (raw)
In-Reply-To: <CALW65jZszAVHNSYgo9Fav8J-Ph9dXzR34CYr1-Ar776mOy4Lbw@mail.gmail.com>

On Thu, Apr 02, 2026 at 08:04:23PM +0800, Qingfang Deng wrote:
> On Thu, Apr 2, 2026 at 7:17 PM Paolo Abeni <pabeni@redhat.com> wrote:
> >
> > On 4/2/26 12:13 PM, Qingfang Deng wrote:
> >
> > > What distro do you run CI tests on? On Ubuntu 24.04, "rp-pppoe.so" is
> > > a symlink to "pppoe.so" in apt package "ppp". Maybe an additional
> > > package is required for the distro you use, or I may work around that
> > > by manually creating the symlink.
> >
> > It's fedora 43 with ppp and pppoe installed.
> >
> > ppp provides pppoe.so, and AFAICS nothink provides rp-pppoe.so, and the
> > pppoe-server is looking for a non existing /etc/ppp/plugins/rp-pppoe.so
> > plugin.
> >
> > Before I mess with the nipa testbed, could you please double check that
> >
> > ln -n /usr/lib64/pppd/2.5.1/pppoe.so /etc/ppp/plugins/rp-pppoe.so
> >
> > should solve?
> 
> Hard links will also work.
> Alternatively, if your rp-pppoe version is 4.0, you can use the new
> option `-g` to specify the full path of the pppoe.so plugin.

It should be possible for anybody to run these self tests. So we don't
want specially crafted setups, but generic setups which will work for
as many people as possible.

It looks like v4.0 we released 2024-09-09. So can we make that the
minimum version? Fail the test if an older version is found? Can the
test poke around the file system and find rp-pppoe.so and pass it
using -g?

      Andrew

  reply	other threads:[~2026-04-02 14:37 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-03-30  3:55 [PATCH net-next v7] selftests: net: add tests for PPP Qingfang Deng
2026-04-01 15:10 ` Jakub Kicinski
2026-04-01 15:45   ` Qingfang Deng
2026-04-02  0:56     ` Jakub Kicinski
2026-04-02  2:26       ` Qingfang Deng
2026-04-02  2:52         ` Jakub Kicinski
2026-04-02  9:48         ` Paolo Abeni
2026-04-02 10:13           ` Qingfang Deng
2026-04-02 11:17             ` Paolo Abeni
2026-04-02 12:04               ` Qingfang Deng
2026-04-02 14:37                 ` Andrew Lunn [this message]
2026-04-02 14:55                   ` Jakub Kicinski

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=24aea6cc-d599-4935-8a75-34f38b852d1e@lunn.ch \
    --to=andrew@lunn.ch \
    --cc=bigeasy@linutronix.de \
    --cc=davem@davemloft.net \
    --cc=dianne@skoll.ca \
    --cc=dqfext@gmail.com \
    --cc=edumazet@google.com \
    --cc=fmaurer@redhat.com \
    --cc=horms@kernel.org \
    --cc=jaco@uls.co.za \
    --cc=kuba@kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-kselftest@vger.kernel.org \
    --cc=linux-ppp@vger.kernel.org \
    --cc=matttbe@kernel.org \
    --cc=netdev@vger.kernel.org \
    --cc=pabeni@redhat.com \
    --cc=paulus@ozlabs.org \
    --cc=shuah@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox