From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-wr0-f172.google.com ([209.85.128.172]:45334 "EHLO mail-wr0-f172.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751633AbeB0Wvx (ORCPT ); Tue, 27 Feb 2018 17:51:53 -0500 Received: by mail-wr0-f172.google.com with SMTP id p104so421976wrc.12 for ; Tue, 27 Feb 2018 14:51:53 -0800 (PST) Subject: Re: [PATCH net-next 11/11] ipmr, ip6mr: Unite dumproute flows To: Yuval Mintz , netdev@vger.kernel.org Cc: mlxsw@mellanox.com, kuznet@ms2.inr.ac.ru, yoshfuji@linux-ipv6.org References: <1519757908-32863-1-git-send-email-yuvalm@mellanox.com> <1519757908-32863-12-git-send-email-yuvalm@mellanox.com> From: Nikolay Aleksandrov Message-ID: <24c22a91-4f16-b9be-7cac-28087c6b73a1@cumulusnetworks.com> Date: Wed, 28 Feb 2018 00:51:50 +0200 MIME-Version: 1.0 In-Reply-To: <1519757908-32863-12-git-send-email-yuvalm@mellanox.com> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit Sender: netdev-owner@vger.kernel.org List-ID: On 27/02/18 20:58, Yuval Mintz wrote: > The various MFC entries are being held in the same kind of mr_tables > for both ipmr and ip6mr, and their traversal logic is identical. > Also, with the exception of the addresses [and other small tidbits] > the major bulk of the nla setting is identical. > > Unite as much of the dumping as possible between the two. > Notice this requires creating an mr_table iterator for each, as the > for-each preprocessor macro can't be used by the common logic. > > Signed-off-by: Yuval Mintz > --- > include/linux/mroute_base.h | 29 ++++++++ > net/ipv4/ipmr.c | 161 +++++++++++--------------------------------- > net/ipv4/ipmr_base.c | 123 +++++++++++++++++++++++++++++++++ > net/ipv6/ip6mr.c | 156 +++++++++++------------------------------- > 4 files changed, 230 insertions(+), 239 deletions(-) > Acked-by: Nikolay Aleksandrov