From: David Ahern <dsahern@gmail.com>
To: Roman Mashak <mrv@mojatatu.com>, davem@davemloft.net
Cc: stephen@networkplumber.org, netdev@vger.kernel.org
Subject: Re: [PATCH net-next 1/1] bridge: return error code when deleting Vlan
Date: Wed, 11 Oct 2017 19:59:47 -0600 [thread overview]
Message-ID: <24cb1770-9b4f-0008-cddb-d3f909ef2239@gmail.com> (raw)
In-Reply-To: <1507757385-32256-1-git-send-email-mrv@mojatatu.com>
On 10/11/17 3:29 PM, Roman Mashak wrote:
> Signed-off-by: Roman Mashak <mrv@mojatatu.com>
> ---
> net/bridge/br_netlink.c | 6 +++---
> 1 file changed, 3 insertions(+), 3 deletions(-)
>
> diff --git a/net/bridge/br_netlink.c b/net/bridge/br_netlink.c
> index f0e8268..a1e1ca8 100644
> --- a/net/bridge/br_netlink.c
> +++ b/net/bridge/br_netlink.c
> @@ -527,11 +527,11 @@ static int br_vlan_info(struct net_bridge *br, struct net_bridge_port *p,
>
> case RTM_DELLINK:
> if (p) {
> - nbp_vlan_delete(p, vinfo->vid);
> + err = nbp_vlan_delete(p, vinfo->vid);
> if (vinfo->flags & BRIDGE_VLAN_INFO_MASTER)
> - br_vlan_delete(p->br, vinfo->vid);
> + err = br_vlan_delete(p->br, vinfo->vid);
err is reset here. What if nbp_vlan_delete fails and br_vlan_delete
succeeds?
> } else {
> - br_vlan_delete(br, vinfo->vid);
> + err = br_vlan_delete(br, vinfo->vid);
> }
> break;
> }
>
prev parent reply other threads:[~2017-10-12 1:59 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-10-11 21:29 [PATCH net-next 1/1] bridge: return error code when deleting Vlan Roman Mashak
2017-10-12 1:59 ` David Ahern [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=24cb1770-9b4f-0008-cddb-d3f909ef2239@gmail.com \
--to=dsahern@gmail.com \
--cc=davem@davemloft.net \
--cc=mrv@mojatatu.com \
--cc=netdev@vger.kernel.org \
--cc=stephen@networkplumber.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox