From: David Ahern <dsahern@gmail.com>
To: Dan Carpenter <dan.carpenter@oracle.com>,
"David S. Miller" <davem@davemloft.net>
Cc: Jiri Pirko <jiri@mellanox.com>,
Ido Schimmel <idosch@mellanox.com>,
Petr Machata <petrm@mellanox.com>,
Jakub Kicinski <jakub.kicinski@netronome.com>,
Nikolay Aleksandrov <nikolay@cumulusnetworks.com>,
Parav Pandit <parav@mellanox.com>,
Roopa Prabhu <roopa@cumulusnetworks.com>,
Johannes Berg <johannes.berg@intel.com>,
Michal Kubecek <mkubecek@suse.cz>,
netdev@vger.kernel.org, linux-rdma@vger.kernel.org,
kernel-janitors@vger.kernel.org
Subject: Re: [PATCH net] net: rtnetlink: prevent underflows in do_setvfinfo()
Date: Wed, 20 Nov 2019 09:41:01 -0700 [thread overview]
Message-ID: <24d0482c-f23f-83b1-e79e-fb84694d0a54@gmail.com> (raw)
In-Reply-To: <20191120123438.vxn2ngnxzpcaqot4@kili.mountain>
On 11/20/19 5:34 AM, Dan Carpenter wrote:
> I reported this bug to the linux-rdma mailing list in April and this
> patch wasn't considered very elegant. I can see how that's true. The
> developer offered to write a fix which would update all the drivers to
> use u32 throughout. I reminded him in September that this bug still
> needs to be fixed.
Since the uapi (ifla_vf_mac, ifla_vf_vlan, ...) all have u32, I agree
with that comment -- it seems like the ndo functions should be changed
from 'int vf' to 'u32 vf'.
next prev parent reply other threads:[~2019-11-20 16:41 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-11-20 12:34 [PATCH net] net: rtnetlink: prevent underflows in do_setvfinfo() Dan Carpenter
2019-11-20 16:41 ` David Ahern [this message]
2019-11-20 18:07 ` Dan Carpenter
2019-11-21 22:44 ` David Miller
2019-11-22 7:21 ` Parav Pandit
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=24d0482c-f23f-83b1-e79e-fb84694d0a54@gmail.com \
--to=dsahern@gmail.com \
--cc=dan.carpenter@oracle.com \
--cc=davem@davemloft.net \
--cc=idosch@mellanox.com \
--cc=jakub.kicinski@netronome.com \
--cc=jiri@mellanox.com \
--cc=johannes.berg@intel.com \
--cc=kernel-janitors@vger.kernel.org \
--cc=linux-rdma@vger.kernel.org \
--cc=mkubecek@suse.cz \
--cc=netdev@vger.kernel.org \
--cc=nikolay@cumulusnetworks.com \
--cc=parav@mellanox.com \
--cc=petrm@mellanox.com \
--cc=roopa@cumulusnetworks.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).